Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(form): Convert to RFC #13180

Merged
merged 8 commits into from
May 15, 2020
Merged

chore(form): Convert to RFC #13180

merged 8 commits into from
May 15, 2020

Conversation

assuncaocharles
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

BREAKING CHANGES

Converting Form from class component to functional. Any props are not longer passed to styles function.

Related to #12237

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label May 15, 2020
@size-auditor
Copy link

size-auditor bot commented May 15, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c045e7cb078bf8eed471e39bba237abe36a33e76 (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 15, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 754 758 5000
Checkbox 1439 1493 5000
CheckboxBase 1197 1209 5000
CheckboxNext 1521 1461 5000
ChoiceGroup 4557 4575 5000
ComboBox 835 846 1000
CommandBar 6686 6599 1000
ContextualMenu 11044 10970 1000
DefaultButton 1002 972 5000
DetailsRow 3100 3066 5000
DetailsRow (fast icons) 3142 3184 5000
DetailsRow without styles 2807 2947 5000
Dialog 1342 1346 1000
DocumentCardTitle with truncation 1470 1406 1000
Dropdown 2254 2352 5000
FocusZone 1414 1414 5000
IconButton 1576 1537 5000
Label 280 292 5000
Link 435 411 5000
LinkNext 380 408 5000
MenuButton 1297 1261 5000
Nav 2878 2829 1000
Panel 1304 1281 1000
Persona 762 789 1000
Pivot 1228 1183 1000
PrimaryButton 1119 1105 5000
SearchBox 1204 1156 5000
Slider 1397 1365 5000
Spinner 315 338 5000
SplitButton 3027 2793 5000
Stack 434 457 5000
Stack with Intrinsic children 980 963 5000
Stack with Text children 3872 3794 5000
TagPicker 2523 2516 5000
Text 363 334 5000
TextField 1313 1264 5000
Toggle 796 795 5000
button 63 56 5000

Perf Analysis (Fluent)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 111 131 0.85:1 analysis
FormMinimalPerf.default 399 767 0.52:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.45 1:1 2000 902
🦄 Button.Fluent 0.1 0.17 0.59:1 5000 518
🔧 Checkbox.Fluent 0.62 0.33 1.88:1 1000 617
🔧 Dialog.Fluent 0.33 0.19 1.74:1 5000 1633
🔧 Dropdown.Fluent 2.9 0.41 7.07:1 1000 2904
🔧 Icon.Fluent 0.13 0.05 2.6:1 5000 671
🎯 Image.Fluent 0.07 0.09 0.78:1 5000 370
🔧 Slider.Fluent 1.26 0.31 4.06:1 1000 1261
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 327
🦄 Tooltip.Fluent 0.09 13.02 0.01:1 5000 425

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 146 126 1.16:1
BoxMinimalPerf.default 324 289 1.12:1
TreeWith60ListItems.default 204 182 1.12:1
GridMinimalPerf.default 702 639 1.1:1
PopupMinimalPerf.default 226 205 1.1:1
CardMinimalPerf.default 558 519 1.08:1
IconMinimalPerf.default 667 619 1.08:1
Icon.Fluent 671 622 1.08:1
RadioGroupMinimalPerf.default 572 536 1.07:1
TextMinimalPerf.default 358 334 1.07:1
MenuMinimalPerf.default 668 631 1.06:1
ReactionMinimalPerf.default 351 332 1.06:1
ToolbarMinimalPerf.default 790 742 1.06:1
Image.Fluent 370 350 1.06:1
Tooltip.Fluent 425 401 1.06:1
AnimationMinimalPerf.default 626 598 1.05:1
ChatMinimalPerf.default 609 581 1.05:1
InputMinimalPerf.default 934 887 1.05:1
ListMinimalPerf.default 459 436 1.05:1
TableMinimalPerf.default 392 372 1.05:1
TreeMinimalPerf.default 1182 1130 1.05:1
ButtonMinimalPerf.default 158 152 1.04:1
ItemLayoutMinimalPerf.default 1603 1538 1.04:1
ListNestedPerf.default 878 841 1.04:1
CarouselMinimalPerf.default 446 433 1.03:1
ListCommonPerf.default 948 919 1.03:1
ProviderMinimalPerf.default 565 551 1.03:1
SliderMinimalPerf.default 1249 1214 1.03:1
Avatar.Fluent 902 878 1.03:1
Slider.Fluent 1261 1225 1.03:1
AvatarMinimalPerf.default 461 452 1.02:1
ButtonSlotsPerf.default 584 573 1.02:1
ChatDuplicateMessagesPerf.default 368 360 1.02:1
DialogMinimalPerf.default 1628 1603 1.02:1
FlexMinimalPerf.default 270 264 1.02:1
SplitButtonMinimalPerf.default 3193 3134 1.02:1
TextAreaMinimalPerf.default 466 455 1.02:1
Checkbox.Fluent 617 604 1.02:1
DropdownMinimalPerf.default 2960 2931 1.01:1
ProviderMergeThemesPerf.default 1409 1391 1.01:1
HierarchicalTreeMinimalPerf.default 967 964 1:1
ListWith60ListItems.default 1079 1080 1:1
MenuButtonMinimalPerf.default 1466 1462 1:1
PortalMinimalPerf.default 288 288 1:1
StatusMinimalPerf.default 668 666 1:1
CustomToolbarPrototype.default 3158 3148 1:1
TooltipMinimalPerf.default 661 664 1:1
VideoMinimalPerf.default 607 605 1:1
CheckboxMinimalPerf.default 2617 2640 0.99:1
LoaderMinimalPerf.default 695 701 0.99:1
Dropdown.Fluent 2904 2928 0.99:1
AlertMinimalPerf.default 275 282 0.98:1
DividerMinimalPerf.default 335 343 0.98:1
DropdownManyItemsPerf.default 1224 1244 0.98:1
HeaderMinimalPerf.default 479 487 0.98:1
Dialog.Fluent 1633 1664 0.98:1
AttachmentSlotsPerf.default 1046 1082 0.97:1
EmbedMinimalPerf.default 1900 1967 0.97:1
HeaderSlotsPerf.default 1407 1450 0.97:1
LayoutMinimalPerf.default 538 554 0.97:1
SegmentMinimalPerf.default 331 341 0.97:1
ChatWithPopoverPerf.default 469 488 0.96:1
RefMinimalPerf.default 162 168 0.96:1
Button.Fluent 518 537 0.96:1
Text.Fluent 327 339 0.96:1
LabelMinimalPerf.default 381 399 0.95:1
ImageMinimalPerf.default 340 363 0.94:1

assuncaocharles and others added 2 commits May 15, 2020 15:52
@assuncaocharles @pompomon
Update packages/fluentui/react-northstar/src/components/Form/Form.tsx
c9dbabc 
Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>
@assuncaocharles
Update accessibility
8600f51
@assuncaocharles assuncaocharles merged commit 0e38808 into microsoft:master May 15, 2020
@assuncaocharles assuncaocharles deleted the chore/form-rfc branch May 15, 2020 17:40
miroslavstastny pushed a commit to levithomason/fluentui that referenced this pull request Jun 8, 2020
@assuncaocharles @pompomon @miroslavstastny
chore(form): Convert to RFC (microsoft#13180)
23695b6 
* chore(form): Convert to RFC

* chore(form): Add changelog

* chore(Form): Remove imports

* chore(Form): Fix Test

* Update packages/fluentui/react-northstar/src/components/Form/Form.tsx

Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>

* Update accessibility

Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompomon pompomon pompomon approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@ecraig12345 ecraig12345

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@assuncaocharles @msft-github-bot @pompomon @ecraig12345