Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(HierarchicalTreeItem): Convert to RFC #13184

Merged
merged 8 commits into from
May 18, 2020
Merged

chore(HierarchicalTreeItem): Convert to RFC #13184

merged 8 commits into from
May 18, 2020

Conversation

assuncaocharles
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

BREAKING CHANGES

Converting HierarchicalTreeItem from class component to functional. Any props are not longer passed to styles function.

Related to #12237

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label May 15, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 15, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 807 800 5000
Checkbox 1458 1491 5000
CheckboxBase 1233 1279 5000
CheckboxNext 1493 1469 5000
ChoiceGroup 4762 4641 5000
ComboBox 908 963 1000
CommandBar 7853 7566 1000
ContextualMenu 16250 16083 1000
DefaultButton 1021 983 5000
DetailsRow 3245 3279 5000
DetailsRow (fast icons) 3342 3269 5000
DetailsRow without styles 3052 3011 5000
Dialog 1441 1420 1000
DocumentCardTitle with truncation 1616 1682 1000
Dropdown 2314 2364 5000
FocusZone 1593 1542 5000
IconButton 1629 1601 5000
Label 298 283 5000
Link 426 468 5000
LinkNext 425 433 5000
MenuButton 1364 1337 5000
Nav 3051 3150 1000
Panel 1431 1444 1000
Persona 810 834 1000
Pivot 1271 1292 1000
PrimaryButton 1182 1152 5000
SearchBox 1206 1205 5000
Slider 1402 1463 5000
Spinner 371 383 5000
SplitButton 2972 2947 5000
Stack 451 449 5000
Stack with Intrinsic children 1077 1058 5000
Stack with Text children 3852 3938 5000
TagPicker 2742 2675 5000
Text 360 346 5000
TextField 1275 1271 5000
Toggle 828 827 5000
button 74 75 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
Text.Fluent 328 306 1.07:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.47 0.44 1.07:1 2000 941
🦄 Button.Fluent 0.1 0.17 0.59:1 5000 508
🔧 Checkbox.Fluent 0.65 0.34 1.91:1 1000 647
🔧 Dialog.Fluent 0.33 0.19 1.74:1 5000 1655
🔧 Dropdown.Fluent 3.2 0.43 7.44:1 1000 3203
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 719
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 343
🔧 Slider.Fluent 1.38 0.34 4.06:1 1000 1379
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 328
🦄 Tooltip.Fluent 0.09 19.94 0:1 5000 444

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 170 151 1.13:1
Icon.Fluent 719 648 1.11:1
ChatMinimalPerf.default 608 567 1.07:1
AlertMinimalPerf.default 297 279 1.06:1
LabelMinimalPerf.default 382 359 1.06:1
GridMinimalPerf.default 663 634 1.05:1
Avatar.Fluent 941 894 1.05:1
Button.Fluent 508 486 1.05:1
ChatDuplicateMessagesPerf.default 411 395 1.04:1
HeaderMinimalPerf.default 469 451 1.04:1
TableMinimalPerf.default 374 359 1.04:1
AttachmentMinimalPerf.default 141 137 1.03:1
ChatWithPopoverPerf.default 522 508 1.03:1
ItemLayoutMinimalPerf.default 1595 1552 1.03:1
PopupMinimalPerf.default 250 243 1.03:1
ProviderMergeThemesPerf.default 1831 1770 1.03:1
RadioGroupMinimalPerf.default 551 534 1.03:1
SplitButtonMinimalPerf.default 3342 3255 1.03:1
TreeMinimalPerf.default 1153 1116 1.03:1
TreeWith60ListItems.default 217 211 1.03:1
Image.Fluent 343 332 1.03:1
CardMinimalPerf.default 540 528 1.02:1
CarouselMinimalPerf.default 465 456 1.02:1
DialogMinimalPerf.default 1731 1692 1.02:1
ListMinimalPerf.default 427 420 1.02:1
SegmentMinimalPerf.default 326 320 1.02:1
TextAreaMinimalPerf.default 438 429 1.02:1
Checkbox.Fluent 647 636 1.02:1
Slider.Fluent 1379 1347 1.02:1
BoxMinimalPerf.default 316 312 1.01:1
FormMinimalPerf.default 375 371 1.01:1
HeaderSlotsPerf.default 1366 1349 1.01:1
HierarchicalTreeMinimalPerf.default 950 937 1.01:1
InputMinimalPerf.default 978 972 1.01:1
ListCommonPerf.default 940 932 1.01:1
LoaderMinimalPerf.default 749 742 1.01:1
Tooltip.Fluent 444 439 1.01:1
AnimationMinimalPerf.default 574 574 1:1
AvatarMinimalPerf.default 502 502 1:1
MenuMinimalPerf.default 641 638 1:1
MenuButtonMinimalPerf.default 1465 1470 1:1
StatusMinimalPerf.default 634 633 1:1
CustomToolbarPrototype.default 3621 3612 1:1
ToolbarMinimalPerf.default 796 798 1:1
CheckboxMinimalPerf.default 2884 2905 0.99:1
DropdownManyItemsPerf.default 1294 1308 0.99:1
SliderMinimalPerf.default 1356 1371 0.99:1
Dialog.Fluent 1655 1666 0.99:1
Dropdown.Fluent 3203 3230 0.99:1
ButtonSlotsPerf.default 598 608 0.98:1
LayoutMinimalPerf.default 523 536 0.98:1
ListWith60ListItems.default 1104 1121 0.98:1
TextMinimalPerf.default 316 322 0.98:1
VideoMinimalPerf.default 580 593 0.98:1
AttachmentSlotsPerf.default 1084 1123 0.97:1
DropdownMinimalPerf.default 3210 3297 0.97:1
ImageMinimalPerf.default 332 341 0.97:1
ListNestedPerf.default 843 870 0.97:1
RefMinimalPerf.default 195 201 0.97:1
TooltipMinimalPerf.default 675 699 0.97:1
AccordionMinimalPerf.default 134 139 0.96:1
DividerMinimalPerf.default 325 340 0.96:1
EmbedMinimalPerf.default 1947 2018 0.96:1
ProviderMinimalPerf.default 636 663 0.96:1
ReactionMinimalPerf.default 356 371 0.96:1
IconMinimalPerf.default 615 656 0.94:1
PortalMinimalPerf.default 285 312 0.91:1
FlexMinimalPerf.default 270 412 0.66:1

@size-auditor
Copy link

size-auditor bot commented May 15, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9970e6587d1ab998d7cb5bb680918ea94deddd07 (build)

assuncaocharles and others added 2 commits May 18, 2020 16:32
@assuncaocharles @layershifter
Update packages/fluentui/react-northstar/src/components/HierarchicalT…
ccae6a4 
…ree/HierarchicalTreeItem.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@assuncaocharles @layershifter
Update packages/fluentui/react-northstar/src/components/HierarchicalT…
ffc8125 
…ree/HierarchicalTreeItem.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@assuncaocharles assuncaocharles merged commit 27704ed into microsoft:master May 18, 2020
@assuncaocharles assuncaocharles deleted the chore/hierarchical-tree-item-rfc branch May 18, 2020 17:01
miroslavstastny pushed a commit to levithomason/fluentui that referenced this pull request Jun 8, 2020
@assuncaocharles @layershifter @miroslavstastny
chore(HierarchicalTreeItem): Convert to RFC (microsoft#13184)
b4cccd7 
* chore(HierarchicalTreeItem): Convert to RFC

* chore(HierarchicalTreeItem): Add changelog

* chore(HierarchicalTreeItem): fix tests

* chore(HierarchicalTreeItem): fix test

* Update packages/fluentui/react-northstar/src/components/HierarchicalTree/HierarchicalTreeItem.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

* Update packages/fluentui/react-northstar/src/components/HierarchicalTree/HierarchicalTreeItem.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompomon pompomon pompomon approved these changes

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@ecraig12345 ecraig12345

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@assuncaocharles @msft-github-bot @pompomon @layershifter @ecraig12345