FileTypeIcon: Add empty alt text to img

[erichdev]

Pull request checklist

• Addresses an existing issue: Fixes #0000
• Include a change request file using $ yarn change

Description of changes

Add empty alt text to <img/> used for FileTypeIcons

Focus areas to test

(optional)

[msft-github-bot]

Perf Analysis

No significant results to display.

All results

Scenario	Master Ticks	PR Ticks	Iterations	Status
BaseButton	761	731	5000
Checkbox	1443	1474	5000
CheckboxBase	1168	1211	5000
CheckboxNext	1396	1407	5000
ChoiceGroup	4662	4591	5000
ComboBox	867	894	1000
CommandBar	7106	7434	1000
ContextualMenu	13330	13427	1000
DefaultButton	971	967	5000
DetailsRow	3179	3117	5000
DetailsRow (fast icons)	3121	3165	5000
DetailsRow without styles	2918	2962	5000
Dialog	1378	1360	1000
DocumentCardTitle with truncation	1604	1602	1000
Dropdown	2161	2208	5000
FocusZone	1539	1581	5000
IconButton	1540	1577	5000
Label	282	270	5000
Link	413	420	5000
LinkNext	419	408	5000
MenuButton	1325	1318	5000
Nav	2947	2885	1000
Panel	1332	1338	1000
Persona	790	783	1000
Pivot	1209	1193	1000
PrimaryButton	1128	1121	5000
SearchBox	1135	1182	5000
Slider	1358	1369	5000
Spinner	359	359	5000
SplitButton	2776	2815	5000
Stack	432	430	5000
Stack with Intrinsic children	1017	1021	5000
Stack with Text children	3789	3754	5000
TagPicker	2503	2493	5000
Text	346	355	5000
TextField	1280	1269	5000
Toggle	814	805	5000
button	53	60	5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AttachmentMinimalPerf.default	132	132	1:1	analysis

Perf comparison

Status	Scenario	Fluent TPI	Fabric TPI	Ratio	Iterations	Ticks
🔧	Avatar.Fluent	0.46	0.45	1.02:1	2000	918
🦄	Button.Fluent	0.1	0.17	0.59:1	5000	486
🔧	Checkbox.Fluent	0.62	0.31	2:1	1000	618
🔧	Dialog.Fluent	0.33	0.19	1.74:1	5000	1629
🔧	Dropdown.Fluent	3.15	0.41	7.68:1	1000	3145
🔧	Icon.Fluent	0.13	0.05	2.6:1	5000	654
🎯	Image.Fluent	0.07	0.1	0.7:1	5000	348
🔧	Slider.Fluent	1.36	0.34	4:1	1000	1360
🔧	Text.Fluent	0.06	0.02	3:1	5000	317
🦄	Tooltip.Fluent	0.08	16.93	0:1	5000	424

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
CarouselMinimalPerf.default	450	418	1.08:1
RefMinimalPerf.default	207	192	1.08:1
TextMinimalPerf.default	334	308	1.08:1
RadioGroupMinimalPerf.default	527	497	1.06:1
ChatDuplicateMessagesPerf.default	404	383	1.05:1
HeaderSlotsPerf.default	1407	1346	1.05:1
ListNestedPerf.default	845	814	1.04:1
ListWith60ListItems.default	1124	1084	1.04:1
Image.Fluent	348	334	1.04:1
ButtonMinimalPerf.default	153	149	1.03:1
EmbedMinimalPerf.default	1922	1867	1.03:1
ImageMinimalPerf.default	340	330	1.03:1
ListMinimalPerf.default	435	421	1.03:1
MenuMinimalPerf.default	625	604	1.03:1
ProviderMergeThemesPerf.default	1656	1612	1.03:1
ReactionMinimalPerf.default	338	329	1.03:1
IconMinimalPerf.default	595	580	1.03:1
BoxMinimalPerf.default	300	295	1.02:1
CardMinimalPerf.default	521	513	1.02:1
ChatMinimalPerf.default	583	574	1.02:1
HierarchicalTreeMinimalPerf.default	907	886	1.02:1
LabelMinimalPerf.default	369	363	1.02:1
LayoutMinimalPerf.default	514	506	1.02:1
MenuButtonMinimalPerf.default	1470	1446	1.02:1
PopupMinimalPerf.default	249	245	1.02:1
PortalMinimalPerf.default	295	288	1.02:1
SplitButtonMinimalPerf.default	3229	3181	1.02:1
TableMinimalPerf.default	348	340	1.02:1
TextAreaMinimalPerf.default	422	413	1.02:1
ToolbarMinimalPerf.default	771	756	1.02:1
TreeMinimalPerf.default	1130	1113	1.02:1
AlertMinimalPerf.default	293	289	1.01:1
ChatWithPopoverPerf.default	512	509	1.01:1
DialogMinimalPerf.default	1664	1650	1.01:1
ListCommonPerf.default	926	920	1.01:1
Button.Fluent	486	479	1.01:1
CheckboxMinimalPerf.default	2836	2833	1:1
DropdownManyItemsPerf.default	1264	1263	1:1
GridMinimalPerf.default	630	627	1:1
InputMinimalPerf.default	944	942	1:1
ProviderMinimalPerf.default	642	644	1:1
SegmentMinimalPerf.default	306	305	1:1
SliderMinimalPerf.default	1357	1355	1:1
StatusMinimalPerf.default	615	615	1:1
CustomToolbarPrototype.default	3543	3558	1:1
Avatar.Fluent	918	915	1:1
Checkbox.Fluent	618	617	1:1
Dialog.Fluent	1629	1628	1:1
Dropdown.Fluent	3145	3151	1:1
Icon.Fluent	654	655	1:1
Slider.Fluent	1360	1361	1:1
Tooltip.Fluent	424	426	1:1
AnimationMinimalPerf.default	583	587	0.99:1
AttachmentSlotsPerf.default	1055	1069	0.99:1
AvatarMinimalPerf.default	488	491	0.99:1
ButtonSlotsPerf.default	581	586	0.99:1
DividerMinimalPerf.default	305	307	0.99:1
HeaderMinimalPerf.default	438	444	0.99:1
TooltipMinimalPerf.default	668	672	0.99:1
DropdownMinimalPerf.default	3111	3159	0.98:1
FlexMinimalPerf.default	254	258	0.98:1
ItemLayoutMinimalPerf.default	1528	1563	0.98:1
Text.Fluent	317	322	0.98:1
LoaderMinimalPerf.default	710	735	0.97:1
VideoMinimalPerf.default	538	555	0.97:1
FormMinimalPerf.default	343	357	0.96:1
TreeWith60ListItems.default	201	210	0.96:1
AccordionMinimalPerf.default	126	136	0.93:1

[size-auditor]

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4e6191ce33cfd662c1b9b582487276be4b5867ea (build)

[ecraig12345]

Wasn't sure about this at first but based on the spec (plus this page and this example) apparently it's okay as long as there's some description of the image elsewhere.

@xugao Since you've worked on a11y more recently does that also sound right to you?

[msft-github-bot]

🎉@uifabric/file-type-icons@v7.2.49 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official NPM Release