chore(MenuDivider): use compose()
#13207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 27704edfdb5f6e183cd745200fc984f2d2bd13ee (build) |
mnajdova
reviewed
May 18, 2020
…thub.com/microsoft/fluentui into chore/menudivider-compose
layershifter
force-pushed
the
chore/menudivider-compose
branch
from
6027b2b
to
aa1182c
Compare
mnajdova
reviewed
May 18, 2020
packages/fluentui/react-northstar/src/themes/teams/components/Menu/menuDividerStyles.ts
Show resolved
Hide resolved
mnajdova
reviewed
May 18, 2020
|
|
||
| export type MenuDividerStylesProps = Required<Pick<MenuDividerProps, 'vertical' | 'inSubmenu' | 'primary'>> & { | ||
| export type MenuDividerStylesProps = Required< | ||
| Pick<MenuDividerProps, 'vertical' | 'inSubmenu' | 'pills' | 'primary' | 'pointing'> |
There was a problem hiding this comment.
Should we add secondary here? I know we are not currently using it inside the theme, but if we have the prop I believe it should be added here too..
mnajdova
reviewed
May 18, 2020
| }), | ||
| }), | ||
| } as ComponentSlotStylesPrepared<MenuStylesProps, MenuVariables>; | ||
| }; |
There was a problem hiding this comment.
Please add this to the PR description breaking changes
mnajdova
reviewed
May 18, 2020
| @@ -44,6 +44,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Update `padding` and `margin` styles for `Card` @pompomon ([#13158](https://github.com/microsoft/fluentui/pull/13158)) | |||
| - Add `expandabble` prop and styles for `Card` @pompomon ([#13092](https://github.com/microsoft/fluentui/pull/13092)) | |||
| - Use `compose()` in `MenuItem` and added dedicated slot's components `MenuItemIcon`, `MenuItemContent`, `MenuItemIndicator` and `MenuItemWrapper` @mnajdova ([#13117](https://github.com/microsoft/fluentui/pull/13117)) | |||
| - Use `compose()` in `MenuDivider` @layershifter ([#13207](https://github.com/microsoft/fluentui/pull/13207)) | |||
There was a problem hiding this comment.
Probably deserves also breaking changes section because of the styles being moved from Menu's divider slot to MenuDivider inside the theme. Styles overrides will be broken on client's side
mnajdova
approved these changes
May 18, 2020
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
* chore(MenuDivider): use `compose()` * fix exports * fix options usage * move styles to MenuDivider * remove unused styles * add secondary * add changelog entry * add breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeBREAKING CHANGES
Move the style for the slot's of the
MenuDividerfrommenuItemStyles.Before
After
Description of changes
This PR uses
compose()inMenuDivider.Focus areas to test
(optional)