feat(Menu): Add children api support #13227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assuncaocharles
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 387865b75c5a33a576800a15cd663f767964165a (build) |
jurokapsiar
reviewed
May 19, 2020
mnajdova
reviewed
May 22, 2020
mnajdova
reviewed
May 22, 2020
mnajdova
reviewed
May 22, 2020
mnajdova
reviewed
May 22, 2020
packages/fluentui/react-northstar/src/components/Menu/MenuItem.tsx
Outdated
Show resolved
Hide resolved
…harles/fluentui into feat/menu-children-api
mnajdova
reviewed
May 22, 2020
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
layershifter
approved these changes
May 22, 2020
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
* feat(Menu): Add children api support * feat(Menu): Pointing example * feat(Menu): Pointing example remove items array * feat(Menu): Underlined example * feat(Menu): IconOnly example * feat(Menu): Icon&Content Example * feat(Menu): Divider Example * feat(Menu): Disabled Example * feat(Menu): Vertical submenu * feat(Menu): Vertical submenu fix * feat(Menu): partially fix submenu * feat(Menu): Fix submenu * feat(Menu): Menu as toolbar example * feat(Menu): Menu as toolbar example * feat(Menu): Menu as toolbar example * feat(Menu): with submenu * feat(Menu): with submenu controlled * feat(Menu): With Tooltips * feat(Menu): Evaluate accessibility * feat(menu): fix divider * chore(Menu): fix build * chore(Menu): fix sbmenu * chore(Menu): fix sbmenu * chore(Menu): fix sbmenu with controlled * chore(Menu): fix Menu toolbar * feat(Menu): parentComponent Slot * feat(Menu): fix tests * feat(Menu): fix tests * feat(Menu): fix tests * feat(Menu): fix tests * Update packages/fluentui/docs/src/examples/components/Menu/Slots/MenuExampleDividerHorizontal.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Slots/MenuExampleSlot.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleToolbar.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleToolbar.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleWithSubmenu.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Usage/MenuExampleWithSubmenu.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/examples/components/Menu/Variations/MenuExampleVerticalPrimary.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Menu/Menu.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Menu/menuContext.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * feat(Menu): Review * feat(Menu): fix prop * feat(Menu): fix build errors * feat(Menu): rename example * feat(Menu): delete examples with submenu * feat(Menu): typo * feat(Menu): remove return statement * feat(Menu): Revert parentComponent slot * Update packages/fluentui/docs/src/examples/components/Menu/Slots/MenuExampleDividerHorizontal.tsx Co-authored-by: Marija Najdova <mnajdova@gmail.com> * feat(Menu): Acessibility for item and divider * feat(Menu): Acessibility for item and divider * feat(Menu): MenuExampleTabList RFC * feat(Menu): onItemClick using actualProps * feat(Menu): onItemClick instead actualProps * fix types * Update packages/fluentui/react-northstar/src/components/Menu/Menu.tsx Co-authored-by: Marija Najdova <mnajdova@gmail.com> * feat(Menu): pass parentProps to slotProps * feat(Menu): onItemClick stable * feat(Menu): remove unnused * feat(Menu): add changelog * feat(Menu): fix screen * feat(Menu): fix tests * feat(Menu): change divider content condition * feat(Menu): fix item click * feat(Menu): fix item click * feat(Menu): itemClick as null * feat(Menu): itemClick as fixed * feat(Menu): remove onclick from props * feat(Menu): improve onlclick invoke Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Adding Children API support to Menu
Focus areas to test
(optional)