-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compose): add shorthandConfig to options #13240
Merged
mnajdova
merged 11 commits into
microsoft:master
from
mnajdova:feat/add-shorthand-config-compose
May 20, 2020
Merged
feat(compose): add shorthandConfig to options #13240
mnajdova
merged 11 commits into
microsoft:master
from
mnajdova:feat/add-shorthand-config-compose
May 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
pompomon
as code owners
May 20, 2020 08:20
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
layershifter
approved these changes
May 20, 2020
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 30fa92e7c750651fa609aa6c924b83155bebe203 (build) |
🎉 Handy links: |
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
* -moved shorthand config * -fixed import * -reverted menu example changes * -update api * Change files * -added tests * -changed imports * Update packages/fluentui/react-northstar/src/utils/factories.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * ts fixes * -updated changelog * -lint Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shorthandConfig
option was added to compose. If you are usingcompose
in your component, make sure that you move the staticshorthandConfig
to the compose options. For backward compatibility, the factories are still handling the shorthandConfig defined as static prop too.Before
After