Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Knobs): Fix knobs labels #13248

Merged
merged 2 commits into from
May 20, 2020
Merged

Conversation

pompomon
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Based on AccessibilityInsights report, fixing knob labels for docs

@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 20, 2020

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 862 839 5000
Checkbox 1689 1678 5000
CheckboxBase 1411 1471 5000
CheckboxNext 1683 1740 5000
ChoiceGroup 5240 5276 5000
ComboBox 1081 1006 1000
CommandBar 7535 7757 1000
ContextualMenu 14988 14510 1000
DefaultButton 1145 1128 5000
DetailsRow 3512 3683 5000
DetailsRow (fast icons) 3642 3629 5000
DetailsRow without styles 3452 3355 5000
Dialog 1583 1559 1000
DocumentCardTitle with truncation 1647 1665 1000
Dropdown 2646 2586 5000
FocusZone 1728 1734 5000
IconButton 1832 1840 5000
Label 315 320 5000
Link 516 497 5000
LinkNext 510 490 5000
MenuButton 1521 1497 5000
Nav 3404 3326 1000
Panel 1546 1498 1000
Persona 919 873 1000
Pivot 1356 1452 1000
PrimaryButton 1248 1301 5000
SearchBox 1459 1422 5000
Slider 1641 1588 5000
SliderNext 1598 1657 5000
Spinner 440 403 5000
SplitButton 3268 3244 5000
Stack 502 494 5000
Stack with Intrinsic children 1188 1223 5000
Stack with Text children 4624 4573 5000
TagPicker 2859 2975 5000
Text 434 456 5000
TextField 1463 1499 5000
Toggle 930 1001 5000
ToggleNext 981 954 5000
button 69 68 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.55 0.49 1.12:1 2000 1105
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 644
🔧 Checkbox.Fluent 0.69 0.39 1.77:1 1000 688
🔧 Dialog.Fluent 0.33 0.21 1.57:1 5000 1657
🔧 Dropdown.Fluent 3.26 0.44 7.41:1 1000 3259
🔧 Icon.Fluent 0.17 0.05 3.4:1 5000 856
🎯 Image.Fluent 0.08 0.11 0.73:1 5000 422
🔧 Slider.Fluent 1.54 0.39 3.95:1 1000 1543
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 367
🦄 Tooltip.Fluent 0.09 18.29 0:1 5000 474

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PopupMinimalPerf.default 296 255 1.16:1
FlexMinimalPerf.default 344 301 1.14:1
LayoutMinimalPerf.default 695 616 1.13:1
ImageMinimalPerf.default 447 406 1.1:1
AttachmentMinimalPerf.default 179 164 1.09:1
Avatar.Fluent 1105 1010 1.09:1
ButtonSlotsPerf.default 683 630 1.08:1
TooltipMinimalPerf.default 786 727 1.08:1
Button.Fluent 644 595 1.08:1
DropdownMinimalPerf.default 3513 3287 1.07:1
FormMinimalPerf.default 475 442 1.07:1
LabelMinimalPerf.default 462 431 1.07:1
ProviderMergeThemesPerf.default 2020 1884 1.07:1
Slider.Fluent 1543 1444 1.07:1
ChatDuplicateMessagesPerf.default 445 421 1.06:1
ListMinimalPerf.default 570 540 1.06:1
SliderMinimalPerf.default 1496 1416 1.06:1
Image.Fluent 422 400 1.06:1
BoxMinimalPerf.default 429 407 1.05:1
ToolbarMinimalPerf.default 943 901 1.05:1
TreeMinimalPerf.default 1377 1308 1.05:1
TreeWith60ListItems.default 236 225 1.05:1
Dialog.Fluent 1657 1574 1.05:1
ListCommonPerf.default 1136 1094 1.04:1
MenuButtonMinimalPerf.default 1727 1659 1.04:1
AnimationMinimalPerf.default 740 720 1.03:1
ChatWithPopoverPerf.default 566 550 1.03:1
DialogMinimalPerf.default 1644 1595 1.03:1
DividerMinimalPerf.default 398 386 1.03:1
PortalMinimalPerf.default 123 119 1.03:1
TextAreaMinimalPerf.default 587 570 1.03:1
AlertMinimalPerf.default 358 351 1.02:1
ItemLayoutMinimalPerf.default 1841 1797 1.02:1
LoaderMinimalPerf.default 864 847 1.02:1
MenuMinimalPerf.default 807 793 1.02:1
Icon.Fluent 856 839 1.02:1
HeaderSlotsPerf.default 1656 1637 1.01:1
ListWith60ListItems.default 1210 1200 1.01:1
CustomToolbarPrototype.default 3835 3815 1.01:1
Checkbox.Fluent 688 683 1.01:1
ChatMinimalPerf.default 696 694 1:1
DropdownManyItemsPerf.default 1472 1469 1:1
GridMinimalPerf.default 815 814 1:1
HierarchicalTreeMinimalPerf.default 487 485 1:1
RadioGroupMinimalPerf.default 658 660 1:1
SplitButtonMinimalPerf.default 3670 3675 1:1
IconMinimalPerf.default 748 748 1:1
CardMinimalPerf.default 653 661 0.99:1
ListNestedPerf.default 973 982 0.99:1
VideoMinimalPerf.default 692 699 0.99:1
Text.Fluent 367 369 0.99:1
Tooltip.Fluent 474 477 0.99:1
AttachmentSlotsPerf.default 1246 1268 0.98:1
AvatarMinimalPerf.default 568 578 0.98:1
EmbedMinimalPerf.default 2174 2225 0.98:1
ProviderMinimalPerf.default 697 711 0.98:1
ReactionMinimalPerf.default 421 428 0.98:1
StatusMinimalPerf.default 763 783 0.97:1
SegmentMinimalPerf.default 387 402 0.96:1
TextMinimalPerf.default 383 399 0.96:1
AccordionMinimalPerf.default 145 153 0.95:1
ButtonMinimalPerf.default 187 197 0.95:1
CheckboxMinimalPerf.default 3105 3263 0.95:1
Dropdown.Fluent 3259 3439 0.95:1
CarouselMinimalPerf.default 521 557 0.94:1
RefMinimalPerf.default 223 239 0.93:1
InputMinimalPerf.default 981 1067 0.92:1
TableMinimalPerf.default 424 463 0.92:1
HeaderMinimalPerf.default 550 604 0.91:1

@size-auditor
Copy link

size-auditor bot commented May 20, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7a46a160d09c20bb462f97fa277f725cfb3c2261 (build)

@msft-github-bot
Copy link
Contributor

Hello @pompomon!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 10 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@pompomon pompomon merged commit d369a0b into microsoft:master May 20, 2020
@pompomon pompomon deleted the docs/fix-knob-a11y branch May 20, 2020 15:29
miroslavstastny pushed a commit to levithomason/fluentui that referenced this pull request Jun 8, 2020
* Fix knobs labels

* Update Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants