chore(Header): Convert to RFC #13253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assuncaocharles
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 73cbfd0c0d41af4839d32070f2b6134cc4b3f471 (build) |
packages/fluentui/react-northstar/src/components/Header/Header.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
packages/fluentui/react-northstar/src/components/Header/Header.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
May 21, 2020
pompomon
reviewed
May 21, 2020
packages/fluentui/react-northstar/src/components/Header/Header.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
pompomon
approved these changes
May 21, 2020
….tsx Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>
|
Hello @assuncaocharles! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
* chore(Header): Convert to RFC * chore(Header): Type accessibility and add changelog * chore(Header): Conditional variables access * Update packages/fluentui/react-northstar/src/components/Header/Header.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Header/Header.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/react-northstar/src/components/Header/Header.tsx Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com> * chore(Header): fix prop Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeBREAKING CHANGES
This PR converts
Headercomponent to be functional. Restricting props set that will be passed to styles functions.Related to #12237
Prop sets
HeadercoloralignhasDescriptionFocus areas to test
(optional)