chore: reexport themes separately #13268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 77ade9a313abc59753fb7550cd050ffc38678d44 (build) |
dzearing
reviewed
May 21, 2020
| // | ||
| export { themes }; | ||
| export { default as teamsTheme } from './themes/teams'; |
There was a problem hiding this comment.
This would be a breaking change for downstream consumers importing themes currently. Make sure to add a CHANGELOG note.
dzearing
approved these changes
May 21, 2020
miroslavstastny
approved these changes
May 21, 2020
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
* chore: reexport themes separately * add changelog entry
mike-solomon
added a commit
to mike-solomon/fluentui
that referenced
this pull request
Jun 24, 2020
Right now, if you try and copy the code from the Quickstart guide, you'll end up with an error about "teamsTheme" not being defined. This is because we're importing "themes" instead of "teamsTheme". I suspect this was just glanced over in this PR: microsoft#13268
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeBREAKING CHANGES
This PR removes
themesexport from@fluentui/react-northstar. Instead of it please use direct exports of themes.Before
After
Description of changes
fluentui/packages/fluentui/react-northstar/src/index.ts
Lines 1 to 6 in 57c30dd
Existing reexport breaks treeshaking because it fails
ModuleConcatenationprocess in Webpack:If Webpack fails to concatenate modules it makes dead-code elimination via Terser almost useless 💣
Measures are taken from
packages/fluentui/docs/src/examples/components/Accordion/Performance/AccordionDefault.bsize.tsxwith enabledconcatenateModulesinwebpack.config.stats.ts.Before
873KB
After
704KB (-169KB/20%)
As a side-effect it also decouples themes. As namespace reexports are handled by Webpack in a different way than in Rollup they were all included to bundles.