Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(RadioGroupItem): Convert to RFC #13301

Merged
merged 5 commits into from
May 25, 2020
Merged

chore(RadioGroupItem): Convert to RFC #13301

merged 5 commits into from
May 25, 2020

Conversation

assuncaocharles
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

BREAKING CHANGES

This PR converts RadioGroupItem component to be functional. Restricting props set that will be passed to styles functions.

Related to #12237

Prop sets

RadioGroupItem
vertical
disabled
checked

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label May 23, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 23, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 894 846 5000
Checkbox 1676 1609 5000
CheckboxBase 1379 1359 5000
CheckboxNext 1628 1599 5000
ChoiceGroup 5260 5110 5000
ComboBox 947 955 1000
CommandBar 7724 7724 1000
ContextualMenu 11766 12090 1000
DefaultButton 1110 1113 5000
DetailsRow 3582 3638 5000
DetailsRow (fast icons) 3480 3676 5000
DetailsRow without styles 3291 3346 5000
Dialog 1557 1524 1000
DocumentCardTitle with truncation 1833 1841 1000
Dropdown 2409 2415 5000
FocusZone 1688 1591 5000
IconButton 1773 1802 5000
Label 305 315 5000
Link 442 486 5000
LinkNext 474 463 5000
MenuButton 1422 1449 5000
Nav 3379 3188 1000
Panel 1472 1482 1000
Persona 848 859 1000
Pivot 1446 1430 1000
PrimaryButton 1275 1262 5000
SearchBox 1347 1315 5000
Slider 1573 1514 5000
SliderNext 1578 1538 5000
Spinner 416 406 5000
SplitButton 3176 3199 5000
Stack 495 490 5000
Stack with Intrinsic children 1924 1905 5000
Stack with Text children 5243 4976 5000
TagPicker 2870 2786 5000
Text 407 415 5000
TextField 1443 1433 5000
Toggle 880 945 5000
ToggleNext 935 913 5000
button 79 87 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.7 0.48 1.46:1 2000 1408
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 589
🔧 Checkbox.Fluent 1.08 0.37 2.92:1 1000 1077
🔧 Dialog.Fluent 0.61 0.22 2.77:1 5000 3074
🔧 Dropdown.Fluent 6.57 0.47 13.98:1 1000 6572
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 684
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 374
🔧 Slider.Fluent 2.9 0.35 8.29:1 1000 2902
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 362
🦄 Tooltip.Fluent 0.09 14.71 0.01:1 5000 451

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 119 106 1.12:1
AccordionMinimalPerf.default 155 145 1.07:1
FormMinimalPerf.default 427 403 1.06:1
RadioGroupMinimalPerf.default 669 635 1.05:1
EmbedMinimalPerf.default 3555 3413 1.04:1
HeaderMinimalPerf.default 366 352 1.04:1
TextAreaMinimalPerf.default 494 477 1.04:1
ButtonSlotsPerf.default 785 764 1.03:1
ListCommonPerf.default 1238 1201 1.03:1
ToolbarMinimalPerf.default 791 771 1.03:1
TreeMinimalPerf.default 1468 1430 1.03:1
VideoMinimalPerf.default 641 621 1.03:1
Dialog.Fluent 3074 2979 1.03:1
ProviderMinimalPerf.default 832 814 1.02:1
CarouselMinimalPerf.default 527 524 1.01:1
ChatMinimalPerf.default 590 584 1.01:1
ChatWithPopoverPerf.default 683 673 1.01:1
CheckboxMinimalPerf.default 5361 5286 1.01:1
DialogMinimalPerf.default 3040 3021 1.01:1
DropdownManyItemsPerf.default 2253 2221 1.01:1
DropdownMinimalPerf.default 6519 6466 1.01:1
HierarchicalTreeMinimalPerf.default 438 432 1.01:1
ListWith60ListItems.default 1668 1646 1.01:1
MenuMinimalPerf.default 814 804 1.01:1
StatusMinimalPerf.default 691 682 1.01:1
CustomToolbarPrototype.default 4934 4872 1.01:1
Dropdown.Fluent 6572 6484 1.01:1
Text.Fluent 362 360 1.01:1
Tooltip.Fluent 451 446 1.01:1
BoxMinimalPerf.default 346 346 1:1
ButtonMinimalPerf.default 177 177 1:1
CardMinimalPerf.default 579 579 1:1
FlexMinimalPerf.default 288 287 1:1
HeaderSlotsPerf.default 811 811 1:1
InputMinimalPerf.default 1590 1590 1:1
ItemLayoutMinimalPerf.default 2788 2793 1:1
LabelMinimalPerf.default 414 412 1:1
ListMinimalPerf.default 472 471 1:1
ListNestedPerf.default 1169 1168 1:1
MenuButtonMinimalPerf.default 1799 1796 1:1
SliderMinimalPerf.default 2911 2922 1:1
TableMinimalPerf.default 391 391 1:1
TextMinimalPerf.default 359 359 1:1
Button.Fluent 589 590 1:1
AnimationMinimalPerf.default 782 793 0.99:1
AttachmentSlotsPerf.default 1285 1295 0.99:1
GridMinimalPerf.default 1430 1448 0.99:1
LayoutMinimalPerf.default 912 921 0.99:1
DividerMinimalPerf.default 334 341 0.98:1
ProviderMergeThemesPerf.default 1744 1774 0.98:1
RefMinimalPerf.default 189 192 0.98:1
SegmentMinimalPerf.default 351 357 0.98:1
SplitButtonMinimalPerf.default 3850 3929 0.98:1
IconMinimalPerf.default 695 706 0.98:1
Checkbox.Fluent 1077 1094 0.98:1
ReactionMinimalPerf.default 385 395 0.97:1
TooltipMinimalPerf.default 738 758 0.97:1
Slider.Fluent 2902 3016 0.96:1
AlertMinimalPerf.default 322 338 0.95:1
Avatar.Fluent 1408 1480 0.95:1
AvatarMinimalPerf.default 751 799 0.94:1
ImageMinimalPerf.default 377 403 0.94:1
LoaderMinimalPerf.default 1144 1213 0.94:1
Icon.Fluent 684 729 0.94:1
Image.Fluent 374 398 0.94:1
ChatDuplicateMessagesPerf.default 533 571 0.93:1
PopupMinimalPerf.default 245 264 0.93:1
AttachmentMinimalPerf.default 151 164 0.92:1
TreeWith60ListItems.default 284 323 0.88:1

@size-auditor
Copy link

size-auditor bot commented May 23, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 56db85a8a435bfafe0354bf5b74eb56be92e3a35 (build)

@assuncaocharles assuncaocharles merged commit 2cc65e3 into microsoft:master May 25, 2020
@assuncaocharles assuncaocharles deleted the chore/radio-group-item-rfc branch May 25, 2020 14:15
miroslavstastny pushed a commit to levithomason/fluentui that referenced this pull request Jun 8, 2020
@assuncaocharles @miroslavstastny
chore(RadioGroupItem): Convert to RFC (microsoft#13301)
d18c58a 
* chore(RadioGroupItem): Convert to RFC

* chore(RadioGroupItem): Add Changelog

* chore(RadioGroupItem): add deo to the hook

* chore(RadioGroupItem): change condition

* chore(RadioGroupItem): Move on change trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@ecraig12345 ecraig12345

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@assuncaocharles @msft-github-bot @layershifter @ecraig12345