Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ToolbarMenuDivider): use compose() #13318

Merged
merged 6 commits into from
May 26, 2020
Merged

feat(ToolbarMenuDivider): use compose() #13318

merged 6 commits into from
May 26, 2020

Conversation

mnajdova
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label May 26, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 26, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 833 834 5000
Checkbox 1622 1622 5000
CheckboxBase 1278 1353 5000
CheckboxNext 1597 1611 5000
ChoiceGroup 5252 5127 5000
ComboBox 954 977 1000
CommandBar 8137 8110 1000
ContextualMenu 14511 14074 1000
DefaultButton 1067 1070 5000
DetailsRow 3565 3512 5000
DetailsRow (fast icons) 3545 3662 5000
DetailsRow without styles 3423 3383 5000
Dialog 1473 1483 1000
DocumentCardTitle with truncation 1922 2035 1000
Dropdown 2651 2516 5000
FocusZone 1816 1758 5000
IconButton 1721 1730 5000
Label 338 316 5000
Link 452 465 5000
LinkNext 477 439 5000
MenuButton 1387 1439 5000
Nav 3244 3242 1000
Panel 1432 1431 1000
Persona 821 858 1000
Pivot 1416 1386 1000
PrimaryButton 1240 1231 5000
SearchBox 1273 1281 5000
Slider 1515 1569 5000
SliderNext 1566 1511 5000
Spinner 434 380 5000
SplitButton 3034 3265 5000
Stack 440 504 5000
Stack with Intrinsic children 1962 1851 5000
Stack with Text children 4984 5118 5000
TagPicker 2846 2793 5000
Text 404 393 5000
TextField 1432 1389 5000
Toggle 909 889 5000
ToggleNext 908 894 5000
button 73 78 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.7 0.5 1.4:1 2000 1396
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 535
🔧 Checkbox.Fluent 1.14 0.36 3.17:1 1000 1139
🔧 Dialog.Fluent 0.57 0.22 2.59:1 5000 2873
🔧 Dropdown.Fluent 6.41 0.45 14.24:1 1000 6409
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 704
🎯 Image.Fluent 0.08 0.11 0.73:1 5000 384
🔧 Slider.Fluent 2.94 0.35 8.4:1 1000 2939
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 352
🦄 Tooltip.Fluent 0.1 19.51 0.01:1 5000 500

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
Image.Fluent 384 342 1.12:1
ToolbarMinimalPerf.default 816 740 1.1:1
AttachmentMinimalPerf.default 154 143 1.08:1
HeaderMinimalPerf.default 358 332 1.08:1
ImageMinimalPerf.default 369 342 1.08:1
PopupMinimalPerf.default 273 253 1.08:1
RefMinimalPerf.default 201 186 1.08:1
AlertMinimalPerf.default 338 319 1.06:1
BoxMinimalPerf.default 333 313 1.06:1
ChatDuplicateMessagesPerf.default 570 538 1.06:1
ProviderMergeThemesPerf.default 1846 1744 1.06:1
ListMinimalPerf.default 486 464 1.05:1
PortalMinimalPerf.default 123 117 1.05:1
TextMinimalPerf.default 349 333 1.05:1
TextAreaMinimalPerf.default 471 450 1.05:1
Icon.Fluent 704 673 1.05:1
Tooltip.Fluent 500 477 1.05:1
ChatWithPopoverPerf.default 721 696 1.04:1
SliderMinimalPerf.default 2900 2794 1.04:1
TableMinimalPerf.default 384 370 1.04:1
Button.Fluent 535 516 1.04:1
Text.Fluent 352 339 1.04:1
AnimationMinimalPerf.default 737 715 1.03:1
EmbedMinimalPerf.default 3507 3389 1.03:1
InputMinimalPerf.default 1645 1600 1.03:1
RadioGroupMinimalPerf.default 587 571 1.03:1
TooltipMinimalPerf.default 760 739 1.03:1
CardMinimalPerf.default 575 563 1.02:1
ChatMinimalPerf.default 583 572 1.02:1
CheckboxMinimalPerf.default 5170 5089 1.02:1
DialogMinimalPerf.default 3007 2949 1.02:1
FlexMinimalPerf.default 295 289 1.02:1
HierarchicalTreeMinimalPerf.default 398 392 1.02:1
LabelMinimalPerf.default 390 384 1.02:1
ListNestedPerf.default 1120 1103 1.02:1
MenuMinimalPerf.default 857 837 1.02:1
MenuButtonMinimalPerf.default 1793 1759 1.02:1
IconMinimalPerf.default 678 662 1.02:1
Dialog.Fluent 2873 2821 1.02:1
Dropdown.Fluent 6409 6301 1.02:1
AttachmentSlotsPerf.default 1264 1248 1.01:1
ButtonSlotsPerf.default 765 755 1.01:1
DividerMinimalPerf.default 332 329 1.01:1
HeaderSlotsPerf.default 781 776 1.01:1
ListCommonPerf.default 1167 1157 1.01:1
ProviderMinimalPerf.default 844 839 1.01:1
VideoMinimalPerf.default 593 590 1.01:1
Avatar.Fluent 1396 1382 1.01:1
Checkbox.Fluent 1139 1126 1.01:1
DropdownMinimalPerf.default 6415 6390 1:1
StatusMinimalPerf.default 671 672 1:1
CustomToolbarPrototype.default 4904 4909 1:1
AccordionMinimalPerf.default 124 125 0.99:1
LayoutMinimalPerf.default 799 806 0.99:1
LoaderMinimalPerf.default 1123 1133 0.99:1
TreeWith60ListItems.default 276 280 0.99:1
Slider.Fluent 2939 2962 0.99:1
DropdownManyItemsPerf.default 2180 2227 0.98:1
FormMinimalPerf.default 390 397 0.98:1
ItemLayoutMinimalPerf.default 2596 2643 0.98:1
ListWith60ListItems.default 1581 1614 0.98:1
ReactionMinimalPerf.default 356 365 0.98:1
TreeMinimalPerf.default 1283 1311 0.98:1
ButtonMinimalPerf.default 177 182 0.97:1
SplitButtonMinimalPerf.default 3968 4073 0.97:1
AvatarMinimalPerf.default 735 763 0.96:1
CarouselMinimalPerf.default 517 536 0.96:1
GridMinimalPerf.default 1310 1370 0.96:1
SegmentMinimalPerf.default 311 354 0.88:1

@size-auditor
Copy link

size-auditor bot commented May 26, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c54bb12af75845cbcc4d702f158d648a9513af3b (build)

@layershifter layershifter merged commit ef1e33d into microsoft:master May 26, 2020
miroslavstastny pushed a commit to levithomason/fluentui that referenced this pull request Jun 8, 2020
@mnajdova @miroslavstastny
feat(ToolbarMenuDivider): use compose() (microsoft#13318)
d26ea3c 
* -use compose() in ToolbarMenuDivider

* -added compose example

* -added cast

* -updated changelog

* -test fix?

* stupid thing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@pompomon pompomon Awaiting requested review from pompomon

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

Assignees

@ecraig12345 ecraig12345

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnajdova @msft-github-bot @layershifter @ecraig12345