Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ToolbarMenu): use compose() #13320

Merged
merged 7 commits into from
May 28, 2020
Merged

feat(ToolbarMenu): use compose() #13320

merged 7 commits into from
May 28, 2020

Conversation

layershifter
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label May 26, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 26, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 828 826 5000
ButtonNext 443 458 5000
Checkbox 1592 1561 5000
CheckboxBase 1398 1268 5000
CheckboxNext 1518 1562 5000
ChoiceGroup 5039 5004 5000
ComboBox 923 961 1000
CommandBar 7962 7875 1000
ContextualMenu 13502 13207 1000
DefaultButton 1070 1067 5000
DetailsRow 3394 3522 5000
DetailsRow (fast icons) 3531 3429 5000
DetailsRow without styles 3251 3249 5000
Dialog 1506 1515 1000
DocumentCardTitle with truncation 1962 1945 1000
Dropdown 2478 2477 5000
FocusZone 1742 1776 5000
IconButton 1717 1703 5000
Label 315 304 5000
Link 444 476 5000
LinkNext 453 443 5000
MenuButton 1439 1390 5000
Nav 3254 3256 1000
Panel 1481 1480 1000
Persona 834 838 1000
Pivot 1431 1400 1000
PrimaryButton 1233 1230 5000
SearchBox 1217 1276 5000
Slider 1483 1473 5000
SliderNext 1915 1877 5000
Spinner 411 405 5000
SplitButton 3147 3089 5000
Stack 495 486 5000
Stack with Intrinsic children 1892 1845 5000
Stack with Text children 5102 4934 5000
TagPicker 2801 2893 5000
Text 386 400 5000
TextField 1387 1434 5000
Toggle 871 895 5000
ToggleNext 838 858 5000
button 80 82 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 123 139 0.88:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.67 0.48 1.4:1 2000 1345
🦄 Button.Fluent 0.11 0.18 0.61:1 5000 535
🔧 Checkbox.Fluent 1.07 0.34 3.15:1 1000 1068
🎯 Dialog.Fluent 0.15 0.21 0.71:1 5000 729
🔧 Dropdown.Fluent 6.32 0.45 14.04:1 1000 6316
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 712
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 355
🔧 Slider.Fluent 2.87 0.33 8.7:1 1000 2873
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 331
🦄 Tooltip.Fluent 0.09 18.85 0:1 5000 470

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatMinimalPerf.default 736 584 1.26:1
PortalMinimalPerf.default 125 111 1.13:1
IconMinimalPerf.default 699 654 1.07:1
BoxMinimalPerf.default 341 323 1.06:1
ButtonSlotsPerf.default 753 716 1.05:1
ListMinimalPerf.default 473 451 1.05:1
CheckboxMinimalPerf.default 5197 4994 1.04:1
FormMinimalPerf.default 384 371 1.04:1
HeaderSlotsPerf.default 774 744 1.04:1
TableMinimalPerf.default 382 368 1.04:1
TooltipMinimalPerf.default 745 717 1.04:1
RefMinimalPerf.default 206 200 1.03:1
TextAreaMinimalPerf.default 450 439 1.03:1
Icon.Fluent 712 691 1.03:1
AttachmentSlotsPerf.default 1206 1180 1.02:1
AvatarMinimalPerf.default 723 711 1.02:1
HierarchicalTreeMinimalPerf.default 415 406 1.02:1
LoaderMinimalPerf.default 1140 1118 1.02:1
ReactionMinimalPerf.default 369 362 1.02:1
VideoMinimalPerf.default 605 594 1.02:1
Image.Fluent 355 347 1.02:1
ButtonMinimalPerf.default 168 167 1.01:1
EmbedMinimalPerf.default 3472 3425 1.01:1
InputMinimalPerf.default 1606 1588 1.01:1
LayoutMinimalPerf.default 392 389 1.01:1
MenuButtonMinimalPerf.default 1744 1721 1.01:1
RadioGroupMinimalPerf.default 387 385 1.01:1
SegmentMinimalPerf.default 321 317 1.01:1
SplitButtonMinimalPerf.default 3938 3917 1.01:1
TextMinimalPerf.default 338 335 1.01:1
CustomToolbarPrototype.default 4852 4796 1.01:1
Button.Fluent 535 530 1.01:1
Dialog.Fluent 729 720 1.01:1
Text.Fluent 331 329 1.01:1
AnimationMinimalPerf.default 709 707 1:1
CarouselMinimalPerf.default 519 517 1:1
DividerMinimalPerf.default 342 341 1:1
DropdownManyItemsPerf.default 2175 2174 1:1
ImageMinimalPerf.default 352 353 1:1
ItemLayoutMinimalPerf.default 2327 2323 1:1
ListNestedPerf.default 1087 1091 1:1
MenuMinimalPerf.default 829 828 1:1
ProviderMinimalPerf.default 838 838 1:1
CardMinimalPerf.default 564 569 0.99:1
DropdownMinimalPerf.default 6394 6441 0.99:1
FlexMinimalPerf.default 284 287 0.99:1
LabelMinimalPerf.default 401 406 0.99:1
ProviderMergeThemesPerf.default 1909 1935 0.99:1
SliderMinimalPerf.default 2875 2904 0.99:1
TableManyItemsPerf.default 2343 2364 0.99:1
ToolbarMinimalPerf.default 810 821 0.99:1
Dropdown.Fluent 6316 6384 0.99:1
Slider.Fluent 2873 2892 0.99:1
ChatWithPopoverPerf.default 530 543 0.98:1
GridMinimalPerf.default 1291 1321 0.98:1
ChatDuplicateMessagesPerf.default 519 537 0.97:1
DialogMinimalPerf.default 716 737 0.97:1
HeaderMinimalPerf.default 331 342 0.97:1
ListCommonPerf.default 1149 1179 0.97:1
PopupMinimalPerf.default 260 267 0.97:1
ListWith60ListItems.default 1551 1624 0.96:1
StatusMinimalPerf.default 650 674 0.96:1
Avatar.Fluent 1345 1400 0.96:1
Checkbox.Fluent 1068 1116 0.96:1
TreeMinimalPerf.default 1289 1355 0.95:1
Tooltip.Fluent 470 495 0.95:1
AlertMinimalPerf.default 319 343 0.93:1
AttachmentMinimalPerf.default 140 150 0.93:1
TreeWith60ListItems.default 241 283 0.85:1

@size-auditor
Copy link

size-auditor bot commented May 26, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4e3fefb7dd55487762db270e554d280b16fa6580 (build)

@mnajdova
Merge branch 'master' into chore/toobar-menu-compose
036f2fd 
# Conflicts:
#	packages/fluentui/react-northstar/src/components/Toolbar/ToolbarItem.tsx
#	packages/fluentui/react-northstar/src/components/Toolbar/ToolbarMenu.tsx
#	packages/fluentui/react-northstar/src/components/Toolbar/ToolbarMenuItem.tsx
@mnajdova
-added slots and slotsProps to ToolbarMenu
bd090cd
@mnajdova
-updated changelog
6b9dcf0
@mnajdova
-fixed popup issue
240e26b
@mnajdova
Merge branch 'master' into chore/toobar-menu-compose
1d650ee 
# Conflicts:
#	packages/fluentui/react-northstar/src/components/Toolbar/ToolbarMenu.tsx
@mnajdova mnajdova merged commit 03e03eb into master May 28, 2020
@layershifter layershifter deleted the chore/toobar-menu-compose branch June 2, 2020 11:46
miroslavstastny pushed a commit to levithomason/fluentui that referenced this pull request Jun 8, 2020
@layershifter @mnajdova @miroslavstastny
feat(ToolbarMenu): use compose() (microsoft#13320)
3baaeb1 
* feat(ToolbarMenu): use compose()

* fix import

* -added slots and slotsProps to ToolbarMenu

* -updated changelog

* -fixed popup issue

Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@ecraig12345 ecraig12345

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@layershifter @msft-github-bot @mnajdova @ecraig12345