feat(ToolbarItem): use compose() #13321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
mnajdova
commented
May 26, 2020
| @@ -126,7 +127,7 @@ const ToolbarRadioGroup: React.FC<WithAsProp<ToolbarRadioGroupProps>> & | |||
| return ToolbarDivider.create(item); | |||
| } | |||
|
|
|||
| const toolbarItem = ToolbarItem.create(item, { | |||
| const toolbarItem = createShorthand(ToolbarItem, item, { | |||
There was a problem hiding this comment.
ToolbarItem.create was removed
mnajdova
commented
May 26, 2020
| @@ -186,6 +186,9 @@ ToolbarMenu.defaultProps = { | |||
| }; | |||
|
|
|||
| ToolbarMenu.create = createShorthandFactory({ Component: ToolbarMenu, mappedArrayProp: 'items' }); | |||
| ToolbarMenu.shorthandConfig = { | |||
There was a problem hiding this comment.
We need this in the ToolbarItem
There was a problem hiding this comment.
Can we removed after compose is added in ToolbarMenu
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
packages/fluentui/react-northstar/src/components/Toolbar/ToolbarItemIcon.tsx
Outdated
Show resolved
Hide resolved
packages/fluentui/react-northstar/src/components/Toolbar/ToolbarItemWrapper.tsx
Outdated
Show resolved
Hide resolved
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1dc036b4710ae47094ba6c8bd5d3f4e3a09e9ea7 (build) |
…eat/toolbar-item-compose
…va/office-ui-fabric-react into feat/toolbar-item-compose � Conflicts: � packages/fluentui/CHANGELOG.md
# Conflicts: # packages/fluentui/CHANGELOG.md # packages/fluentui/react-northstar/src/components/Toolbar/ToolbarRadioGroup.tsx
-added missing variables
# Conflicts: # packages/fluentui/CHANGELOG.md # packages/fluentui/docs/src/examples/components/Toolbar/Visual/ToolbarExampleCompose.shorthand.tsx # packages/fluentui/react-northstar/src/components/Toolbar/Toolbar.tsx
-expanded example
mnajdova
commented
May 27, 2020
| ); | ||
| }; | ||
| const renderOverflowItem = overflowItem => | ||
| createShorthand(composeOptions.slots.overflowItem, overflowItem, { |
There was a problem hiding this comment.
Oops we forgot ToolbarItem here..
layershifter
approved these changes
May 27, 2020
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
* wip * added icon and fixed menu * -updated changelog * push changes related to refs * -merge conflicts fixes * -expanded example -added missing variables * -fixed e2e * -resolved merge conflicts * -fixed toolbar radio group -expanded example Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compose functionality to
ToolbarItem.BREAKING CHANGES
Restructured
classNameexports for theToolbarItem'swrapper, which is now a component.Before
After