Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(RadioGroup): Convert to RFC #13338

Merged
merged 5 commits into from
May 27, 2020
Merged

chore(RadioGroup): Convert to RFC #13338

merged 5 commits into from
May 27, 2020

Conversation

assuncaocharles
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

BREAKING CHANGES

Converting RadioGroup from class component to functional. Any props are not longer passed to styles function.

Related to #12237

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label May 27, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 27, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 840 840 5000
ButtonNext 458 452 5000
Checkbox 1570 1550 5000
CheckboxBase 1342 1244 5000
CheckboxNext 1535 1607 5000
ChoiceGroup 4990 4972 5000
ComboBox 933 949 1000
CommandBar 7880 7769 1000
ContextualMenu 13821 13958 1000
DefaultButton 1087 1052 5000
DetailsRow 3455 3558 5000
DetailsRow (fast icons) 3313 3417 5000
DetailsRow without styles 3237 3258 5000
Dialog 1454 1520 1000
DocumentCardTitle with truncation 1923 1941 1000
Dropdown 2390 2447 5000
FocusZone 1783 1762 5000
IconButton 1663 1703 5000
Label 319 332 5000
Link 458 473 5000
LinkNext 456 443 5000
MenuButton 1354 1392 5000
Nav 3227 3234 1000
Panel 1419 1454 1000
Persona 833 822 1000
Pivot 1343 1379 1000
PrimaryButton 1198 1178 5000
SearchBox 1225 1223 5000
Slider 1472 1492 5000
SliderNext 1855 1849 5000
Spinner 391 386 5000
SplitButton 3202 3092 5000
Stack 478 470 5000
Stack with Intrinsic children 1820 1787 5000
Stack with Text children 4868 4833 5000
TagPicker 2799 2727 5000
Text 392 377 5000
TextField 1383 1355 5000
Toggle 881 885 5000
ToggleNext 853 875 5000
button 68 70 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
RadioGroupMinimalPerf.default 406 567 0.72:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.71 0.49 1.45:1 2000 1426
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 534
🔧 Checkbox.Fluent 1.11 0.36 3.08:1 1000 1111
🔧 Dialog.Fluent 0.57 0.22 2.59:1 5000 2847
🔧 Dropdown.Fluent 6.55 0.47 13.94:1 1000 6550
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 681
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 354
🔧 Slider.Fluent 2.89 0.37 7.81:1 1000 2891
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 341
🦄 Tooltip.Fluent 0.1 19.8 0.01:1 5000 489

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 191 169 1.13:1
IconMinimalPerf.default 691 620 1.11:1
AttachmentMinimalPerf.default 162 149 1.09:1
TextAreaMinimalPerf.default 449 416 1.08:1
Avatar.Fluent 1426 1332 1.07:1
TableMinimalPerf.default 394 373 1.06:1
Image.Fluent 354 333 1.06:1
CarouselMinimalPerf.default 543 515 1.05:1
AlertMinimalPerf.default 344 331 1.04:1
CardMinimalPerf.default 564 540 1.04:1
DialogMinimalPerf.default 2939 2839 1.04:1
DividerMinimalPerf.default 341 328 1.04:1
EmbedMinimalPerf.default 3467 3345 1.04:1
HeaderMinimalPerf.default 360 346 1.04:1
AnimationMinimalPerf.default 723 705 1.03:1
AvatarMinimalPerf.default 761 740 1.03:1
ChatMinimalPerf.default 610 593 1.03:1
ListWith60ListItems.default 1585 1545 1.03:1
SegmentMinimalPerf.default 341 330 1.03:1
ToolbarMinimalPerf.default 784 762 1.03:1
BoxMinimalPerf.default 330 325 1.02:1
ItemLayoutMinimalPerf.default 2677 2616 1.02:1
ListCommonPerf.default 1142 1118 1.02:1
LoaderMinimalPerf.default 1127 1100 1.02:1
Dropdown.Fluent 6550 6431 1.02:1
DropdownMinimalPerf.default 6408 6349 1.01:1
GridMinimalPerf.default 1358 1341 1.01:1
MenuButtonMinimalPerf.default 1689 1676 1.01:1
ReactionMinimalPerf.default 377 372 1.01:1
SplitButtonMinimalPerf.default 3958 3909 1.01:1
StatusMinimalPerf.default 666 662 1.01:1
Icon.Fluent 681 676 1.01:1
Slider.Fluent 2891 2857 1.01:1
Tooltip.Fluent 489 485 1.01:1
CheckboxMinimalPerf.default 5204 5180 1:1
FlexMinimalPerf.default 287 286 1:1
HierarchicalTreeMinimalPerf.default 409 411 1:1
ImageMinimalPerf.default 343 344 1:1
LabelMinimalPerf.default 393 393 1:1
PortalMinimalPerf.default 114 114 1:1
RefMinimalPerf.default 206 205 1:1
CustomToolbarPrototype.default 4926 4907 1:1
Text.Fluent 341 340 1:1
AccordionMinimalPerf.default 139 140 0.99:1
ButtonSlotsPerf.default 764 771 0.99:1
TextMinimalPerf.default 338 343 0.99:1
TooltipMinimalPerf.default 731 737 0.99:1
Checkbox.Fluent 1111 1126 0.99:1
ChatDuplicateMessagesPerf.default 543 555 0.98:1
InputMinimalPerf.default 1577 1603 0.98:1
LayoutMinimalPerf.default 797 810 0.98:1
ListMinimalPerf.default 466 477 0.98:1
PopupMinimalPerf.default 261 266 0.98:1
ProviderMergeThemesPerf.default 1842 1881 0.98:1
ProviderMinimalPerf.default 845 862 0.98:1
VideoMinimalPerf.default 573 586 0.98:1
Button.Fluent 534 544 0.98:1
Dialog.Fluent 2847 2903 0.98:1
DropdownManyItemsPerf.default 2158 2229 0.97:1
ListNestedPerf.default 1093 1124 0.97:1
MenuMinimalPerf.default 825 851 0.97:1
TreeMinimalPerf.default 1280 1313 0.97:1
HeaderSlotsPerf.default 741 774 0.96:1
TreeWith60ListItems.default 281 293 0.96:1
AttachmentSlotsPerf.default 1199 1261 0.95:1
ChatWithPopoverPerf.default 685 722 0.95:1
SliderMinimalPerf.default 2765 2907 0.95:1
FormMinimalPerf.default 370 394 0.94:1

assuncaocharles and others added 2 commits May 27, 2020 10:13
@assuncaocharles @layershifter
Update packages/fluentui/react-northstar/src/components/RadioGroup/Ra…
5319d0c 
…dioGroup.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@assuncaocharles @layershifter
Update packages/fluentui/react-northstar/src/components/RadioGroup/Ra…
2712bdb 
…dioGroup.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@size-auditor
Copy link

size-auditor bot commented May 27, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9498d7737f66ebaa3a520b1055f85e678c49a8d9 (build)

@assuncaocharles assuncaocharles merged commit 3ba379e into microsoft:master May 27, 2020
@assuncaocharles assuncaocharles deleted the chore/radio-group-rfc branch May 27, 2020 09:54
miroslavstastny pushed a commit to levithomason/fluentui that referenced this pull request Jun 8, 2020
@assuncaocharles @layershifter @miroslavstastny
chore(RadioGroup): Convert to RFC (microsoft#13338)
6371a0c 
* chore(RadioGroup): Convert to RFC

* chore(RadioGroup): Add changelog

* Update packages/fluentui/react-northstar/src/components/RadioGroup/RadioGroup.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

* Update packages/fluentui/react-northstar/src/components/RadioGroup/RadioGroup.tsx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@ecraig12345 ecraig12345

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@assuncaocharles @msft-github-bot @layershifter @ecraig12345