compose: adding mergeProps utility to react-compose
#13360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/create-options-resolver
…ate files, removing react-is usage which wasn't in the package.json, no need to pull an external dependency to check if we're a forwardref.
…fice-ui-fabric-react into feat/compose-cleanup
…eat/create-options-resolver # Conflicts: # packages/react-compose/src/mergeComposeOptions.ts # packages/react-compose/src/types.ts
…eat/create-options-resolver
khmakoto
reviewed
May 27, 2020
khmakoto
approved these changes
May 27, 2020
xugao
reviewed
May 27, 2020
xugao
reviewed
May 27, 2020
xugao
reviewed
May 27, 2020
xugao
reviewed
May 27, 2020
dzearing
changed the title
resolve callback to options to resolve conformance concernsresolve callback to options
Perf Analysis
All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
khmakoto
reviewed
May 30, 2020
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
…eat/create-options-resolver
…eat/create-options-resolver
…aring/office-ui-fabric-react into feat/create-options-resolver
… is not accurate any more.
|
I did some sleuthing with webpack bailouts to understand why the bundle size jumped so much.
|
|
I believe this is ready to go in. |
xugao
approved these changes
Jun 1, 2020
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
* Updating typings. * Fixing the template variable names, splitting out utils.ts into separate files, removing react-is usage which wasn't in the package.json, no need to pull an external dependency to check if we're a forwardref. * Change files * Missed one merge conflict. * reducing changes * Update @fluentui-react-compose-2020-05-27-08-46-47-feat-compose-cleanup.json * pr feedback * more * Moving classname changes to separate branch * cleanup. * Change files * pass build * cleanup * pr updates. * updates * Updates to tests. * more tests, types, etc. * More tests. * Updating api * Updates resolve to be mergeProps, removes from the compose options, deletes unused code. * Rename * Updates to rename mapPropsToSlotProps. * Update @fluentui-react-compose-2020-05-27-12-54-51-feat-create-options-resolver.json * Update packages/react-compose/src/mergeProps.ts Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * fix. * fixes. * Change files * api updates. * renames * oi * Update to package.json * undo. * Button updates to address screener issues; private copy of mergeProps is not accurate any more. * Change files * Reduce bundle size by 3k by removing side effect code. * Change files * screener fix. Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits out more of my draft PR, and adds a
mergePropshelper to the compose package. This helper will help resolveslotsandslotPropsand effectively can replace theresolveSlotPropsthat is nested withinmergeComposeOptions. Expected usage:I have not removed the existing implementation so that the v0 code is not busted, but once this is in, that code can be updated.
I am going through the shorthand factory tests right now to validate I didn't miss any, and will be adding more tests to this PR but wanted to get this going sooner for early feedback.