perf: use mergeVariablesOverrides() to avoid cache breaks when variables are not passed #13374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les are not passed
layershifter
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
…ithub.com/microsoft/fluentui into perf/use-simple-merge-vars
mnajdova
reviewed
May 28, 2020
| mergeComponentVariables() is always creating a function even if the arguments are undefined we have this temporary | ||
| fix in place to avoid creating empty function because it is breaking caching we should either fix | ||
| mergeComponentVariables(), or handle this in a more generic way. | ||
| */ |
There was a problem hiding this comment.
Do we still need this comment?
There was a problem hiding this comment.
I would say yes to provide a context why this is a solution
mnajdova
reviewed
May 28, 2020
| fix in place to avoid creating empty function because it is breaking caching we should either fix | ||
| mergeComponentVariables(), or handle this in a more generic way. | ||
| */ | ||
| export default function mergeVariablesOverrides( |
There was a problem hiding this comment.
should we add this under @fluentui/styles with the other merge functions?
There was a problem hiding this comment.
I don't have there any preference, however I placed it here as it's more attached to component's specifics
mnajdova
reviewed
May 28, 2020
| }); | ||
| }); | ||
| }; | ||
|
|
||
| const renderHeader = () => { | ||
| if (!header) { |
There was a problem hiding this comment.
Should we really remove this check?
There was a problem hiding this comment.
Yup, as .create() call few lines below handles this:
fluentui/packages/fluentui/react-northstar/src/components/Table/Table.tsx
Lines 111 to 124 in e5adec2
mnajdova
reviewed
May 28, 2020
| ...overrideProps, | ||
| }), | ||
| defaultProps: () => getA11yProps('cell', {}), | ||
| overrideProps: predefinedProps => ({ |
mnajdova
approved these changes
May 28, 2020
|
Hello @layershifter! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 42 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e5adec2a91f1b920d1b0a2ab5e29828f2a7f4c30 (build) |
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
…les are not passed (microsoft#13374) * perf: use mergeVariablesOverrides() to avoid cache breaks when variables are not passed * add changelog entry * fix ts issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Fixes an issues that we have found with improved telemetry, see #13346 (comment).
This PR introduces
mergeVariablesOverrides()which we already uses inAttachmentto avoid creation of variables functions even if there is no overrides as that breaks caching.Focus areas to test
(optional)