Removing side effect code from @uifabric/utilities #13415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 0513e0aff999cfb32938ed1b431500235a8a2e90 (build) |
xugao
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
could you also move code in here : https://github.com/microsoft/fluentui/blob/master/packages/utilities/src/memoize.ts#L3
Thanks!
|
@xugao Nice catch, done! |
|
Hello @dzearing! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
xugao
approved these changes
Jun 1, 2020
|
🎉 Handy links: |
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
Found some super old side effect code that is causing webpack to bail out of optimizations. Restructuring code to execute only in needed circumstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some super old side effect code that is causing webpack to bail out of optimizations.
Restructuring code to execute only in needed circumstances.