Dialog: Fixing broken deprecated props and adding snapshot tests for them #13425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschect
approved these changes
Jun 1, 2020
|
@msft-github-bot merge in 1 minute. |
|
Hello @khmakoto! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
micahgodbolt
approved these changes
Jun 1, 2020
Asset size changes
Baseline commit: 49592828383aeb1a4c9b199c99dad89ab2fafbae (build) |
|
🎉 Handy links: |
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
…them (microsoft#13425) #### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [x] Include a change request file using `$ yarn change` #### Description of changes microsoft#12045 broke the use of some deprecated props in `Dialog` by overriding them with default props. This PR fixes this issue and adds snapshot tests for the deprecated props so that this doesn't happen again. #### Focus areas to test (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
#12045 broke the use of some deprecated props in
Dialogby overriding them with default props. This PR fixes this issue and adds snapshot tests for the deprecated props so that this doesn't happen again.Focus areas to test
(optional)