feat(Popup): add show/hide animations #13439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
mnajdova
commented
Jun 2, 2020
| @@ -540,7 +545,7 @@ const Popup: React.FC<PopupProps> & | |||
| const element = ( | |||
| <> | |||
| {triggerElement} | |||
| {open && (inline ? contentElement : <PortalInner mountNode={mountNode}>{contentElement}</PortalInner>)} | |||
| {inline ? contentElement : <PortalInner mountNode={mountNode}>{contentElement}</PortalInner>} | |||
There was a problem hiding this comment.
The Animation component is responsible for mounting/removing the element now, so no need for this check
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d4ec6202be3cee08373ab8636cdc6fa76a448aac (build) |
|
The Edited: the PR #13509 is in, so we may continue with this one. |
packages/fluentui/react-northstar/src/components/Popup/Popup.tsx
Outdated
Show resolved
Hide resolved
| import * as React from 'react'; | ||
|
|
||
| export * from 'react-transition-group'; | ||
| export const Transition = props => { |
There was a problem hiding this comment.
Are there TransitionProps ? Can we use them?
layershifter
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is simply adding animations for showing/hiding popups. No customization are allowed at this moment, if we need to we can add them as a follow up