Picker/PeoplePicker: Fix issue where default value wouldn't trigger suggestions #13480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhuntington
reviewed
Jun 4, 2020
packages/office-ui-fabric-react/src/components/pickers/BasePicker.test.tsx
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx
Outdated
Show resolved
Hide resolved
| * This should be called when the user does something other than use text entry to trigger suggestions. | ||
| * | ||
| */ | ||
| private _userTriggeredSuggestions = () => { |
There was a problem hiding this comment.
👍 for moving this. Also a valuable refactor target in the future as there are tons of paths through these branches.
|
|
||
| this.updateSuggestionsList(suggestions); | ||
|
|
||
| this.setState({ |
There was a problem hiding this comment.
This seems to be new logic and not just a refactor. Intentional?
There was a problem hiding this comment.
Correct! This fixes an issue where a default value in the picker wouldn't have triggered a resolve suggestions.
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 24e7759686ef88224d23ba35ac0e3add895357b6 (build) |
|
can you fill in a description of what the behavior was before/after? how do we test? |
khmakoto
reviewed
Jun 5, 2020
packages/office-ui-fabric-react/src/components/pickers/BasePicker.test.tsx
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/pickers/BasePicker.test.tsx
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/pickers/BasePicker.test.tsx
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/pickers/BasePicker.test.tsx
Show resolved
Hide resolved
dzearing
reviewed
Jun 5, 2020
Comment on lines
594
to
596
| if (this.props.inputProps !== undefined && this.props.inputProps.onClick !== undefined) { | ||
| this.props.inputProps.onClick(ev); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (this.props.inputProps !== undefined && this.props.inputProps.onClick !== undefined) { | |
| this.props.inputProps.onClick(ev); | |
| } | |
| this.props.inputProps?.onClick?(ev); |
I think that would work :)
dzearing
reviewed
Jun 5, 2020
Comment on lines
551
to
553
| if (this.props.inputProps && this.props.inputProps.onFocus) { | ||
| this.props.inputProps.onFocus(ev as React.FocusEvent<HTMLInputElement>); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (this.props.inputProps && this.props.inputProps.onFocus) { | |
| this.props.inputProps.onFocus(ev as React.FocusEvent<HTMLInputElement>); | |
| } | |
| this.props.inputProps?.onFocus?(ev as React.FocusEvent<HTMLInputElement>); |
There was a problem hiding this comment.
Did we get these fixed? I think it was an issue with babel if I remember correctly.
dzearing
approved these changes
Jun 5, 2020
…ker.test.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
khmakoto
approved these changes
Jun 5, 2020
|
🎉 Handy links: |
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
…uggestions (microsoft#13480) * Minor picker refactor, fix an issue where default value wouldn't trigger resolving value * Change files * update api * fix comments * remove unneeded test * fix minor issue * Update packages/office-ui-fabric-react/src/components/pickers/BasePicker.test.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Original Behavior: If the picker's input contained some default value via
inputProps: {defaultVisibleValue: 'foo'}}when the picker received focus, it would not show suggestions.The fix: The picker now attempts to callback to get suggestions if it currently contains a text value and does not have any current suggestions.
Focus areas to test
(optional)