Dialog: min height for title to ensure subtext doesn't overlap 'close' button.

[jdhuntington]

• Addresses an existing issue: Fixes Dialog with no title and with close option is misaligned #13458
• Include a change request file using $ yarn change

[msft-github-bot]

Perf Analysis

No significant results to display.

All results

Scenario	Master Ticks	PR Ticks	Iterations	Status
BaseButton	784	838	5000
ButtonNext	388	370	5000
Checkbox	1514	1539	5000
CheckboxBase	1275	1225	5000
CheckboxNext	1589	1520	5000
ChoiceGroup	5012	4928	5000
ComboBox	900	898	1000
CommandBar	7266	7491	1000
ContextualMenu	13012	14737	1000
DefaultButton	1016	987	5000
DetailsRow	3225	3300	5000
DetailsRow (fast icons)	3557	3589	5000
DetailsRow without styles	3191	3309	5000
Dialog	1441	1463	1000
DocumentCardTitle with truncation	1920	1899	1000
Dropdown	2223	2299	5000
FocusZone	1773	1672	5000
IconButton	1724	1716	5000
Label	318	326	5000
Link	470	471	5000
LinkNext	466	470	5000
MenuButton	1432	1410	5000
Nav	3173	3206	1000
Panel	1455	1423	1000
Persona	839	816	1000
Pivot	1395	1381	1000
PivotNext	1289	1260	1000
PrimaryButton	1182	1126	5000
SearchBox	1257	1247	5000
Slider	1463	1489	5000
SliderNext	1947	1950	5000
Spinner	412	396	5000
SplitButton	2976	3081	5000
Stack	464	474	5000
Stack with Intrinsic children	1793	1736	5000
Stack with Text children	4551	4784	5000
TagPicker	2765	2805	5000
Text	384	388	5000
TextField	1379	1419	5000
ThemeProvider	2824	2882	5000
Toggle	872	876	5000
ToggleNext	831	872	5000
button	73	80	5000

Perf Analysis (Fluent)

Perf comparison

Status	Scenario	Fluent TPI	Fabric TPI	Ratio	Iterations	Ticks
🎯	Avatar.Fluent	0.46	0.51	0.9:1	2000	922
🦄	Button.Fluent	0.1	0.19	0.53:1	5000	513
🔧	Checkbox.Fluent	0.6	0.35	1.71:1	1000	596
🦄	Dialog.Fluent	0.14	0.21	0.67:1	5000	716
🔧	Dropdown.Fluent	3.23	0.44	7.34:1	1000	3230
🔧	Icon.Fluent	0.14	0.05	2.8:1	5000	687
🦄	Image.Fluent	0.07	0.11	0.64:1	5000	343
🔧	Slider.Fluent	1.46	0.34	4.29:1	1000	1463
🔧	Text.Fluent	0.07	0.02	3.5:1	5000	352
🦄	Tooltip.Fluent	0.09	19.25	0:1	5000	464

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
Text.Fluent	352	322	1.09:1
AttachmentMinimalPerf.default	145	134	1.08:1
DividerMinimalPerf.default	346	321	1.08:1
AccordionMinimalPerf.default	148	138	1.07:1
AvatarMinimalPerf.default	493	459	1.07:1
ListWith60ListItems.default	1092	1035	1.06:1
LabelMinimalPerf.default	383	365	1.05:1
PopupMinimalPerf.default	252	240	1.05:1
RadioGroupMinimalPerf.default	412	394	1.05:1
ReactionMinimalPerf.default	361	343	1.05:1
Image.Fluent	343	326	1.05:1
CarouselMinimalPerf.default	438	421	1.04:1
DropdownManyItemsPerf.default	1372	1317	1.04:1
FormMinimalPerf.default	389	375	1.04:1
ListMinimalPerf.default	475	455	1.04:1
TextMinimalPerf.default	341	327	1.04:1
Dialog.Fluent	716	691	1.04:1
Icon.Fluent	687	662	1.04:1
AttachmentSlotsPerf.default	1147	1114	1.03:1
LoaderMinimalPerf.default	713	695	1.03:1
SegmentMinimalPerf.default	334	323	1.03:1
SliderMinimalPerf.default	1588	1537	1.03:1
Avatar.Fluent	922	892	1.03:1
BoxMinimalPerf.default	343	336	1.02:1
CardMinimalPerf.default	534	525	1.02:1
EmbedMinimalPerf.default	1880	1838	1.02:1
HierarchicalTreeMinimalPerf.default	410	402	1.02:1
ItemLayoutMinimalPerf.default	1306	1280	1.02:1
MenuMinimalPerf.default	821	806	1.02:1
ButtonMinimalPerf.default	172	170	1.01:1
ChatDuplicateMessagesPerf.default	404	400	1.01:1
DropdownMinimalPerf.default	3186	3145	1.01:1
FlexMinimalPerf.default	284	281	1.01:1
InputMinimalPerf.default	1032	1024	1.01:1
SplitButtonMinimalPerf.default	3384	3350	1.01:1
TextAreaMinimalPerf.default	441	437	1.01:1
CustomToolbarPrototype.default	3869	3831	1.01:1
Tooltip.Fluent	464	461	1.01:1
ButtonSlotsPerf.default	587	588	1:1
CheckboxMinimalPerf.default	2753	2749	1:1
GridMinimalPerf.default	654	655	1:1
ListNestedPerf.default	846	848	1:1
RefMinimalPerf.default	206	205	1:1
StatusMinimalPerf.default	665	667	1:1
TableManyItemsPerf.default	2113	2112	1:1
TreeWith60ListItems.default	211	212	1:1
Dropdown.Fluent	3230	3246	1:1
ChatWithPopoverPerf.default	434	439	0.99:1
ImageMinimalPerf.default	348	353	0.99:1
LayoutMinimalPerf.default	385	387	0.99:1
ListCommonPerf.default	921	931	0.99:1
ProviderMinimalPerf.default	851	861	0.99:1
IconMinimalPerf.default	631	636	0.99:1
AnimationMinimalPerf.default	612	624	0.98:1
TreeMinimalPerf.default	832	851	0.98:1
Button.Fluent	513	524	0.98:1
DialogMinimalPerf.default	700	723	0.97:1
HeaderSlotsPerf.default	736	756	0.97:1
TableMinimalPerf.default	358	368	0.97:1
ToolbarMinimalPerf.default	869	893	0.97:1
MenuButtonMinimalPerf.default	1157	1209	0.96:1
PortalMinimalPerf.default	102	106	0.96:1
ProviderMergeThemesPerf.default	2072	2155	0.96:1
Checkbox.Fluent	596	624	0.96:1
ChatMinimalPerf.default	561	590	0.95:1
HeaderMinimalPerf.default	332	351	0.95:1
Slider.Fluent	1463	1546	0.95:1
AlertMinimalPerf.default	278	296	0.94:1
VideoMinimalPerf.default	600	660	0.91:1
TooltipMinimalPerf.default	670	745	0.9:1

[size-auditor]

Asset size changes

Project	Bundle	Baseline Size	New Size	Difference
office-ui-fabric-react	office-ui-fabric-react-Dialog	197.897 kB	197.925 kB	28 bytes
office-ui-fabric-react	fluentui-react-next-Dialog	197.856 kB	197.884 kB	28 bytes

 Over Tolerance (1024 B)  Over Baseline  Below Baseline  New   Removed 1 kB = 1000 B

Baseline commit: 24e7759686ef88224d23ba35ac0e3add895357b6 (build)

[msft-github-bot]

🎉office-ui-fabric-react@v7.118.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official NPM Release
• Test the release with Developer Demo Site