Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PivotItem: Fixing typing error in headerButtonProps #13550

Merged
merged 5 commits into from Jun 11, 2020
Merged

PivotItem: Fixing typing error in headerButtonProps #13550

merged 5 commits into from Jun 11, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

#13128 aimed to expand the typings of headerButtonProps to accept IButtonProps but there was a bug in the type introduced. This PR fixes that bug.

Focus areas to test

(optional)

@khmakoto khmakoto requested a review from behowell June 10, 2020 21:21
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 981 1004 5000
ButtonNext mount 448 478 5000
Checkbox mount 1900 1846 5000
CheckboxBase mount 1500 1607 5000
CheckboxNext mount 1854 1848 5000
ChoiceGroup mount 5713 5799 5000
ComboBox mount 1041 1105 1000
CommandBar mount 8358 8435 1000
ContextualMenu mount 14400 14541 1000
DefaultButton mount 1246 1245 5000
DetailsRow mount 3989 3897 5000
DetailsRowFast mount 4037 3973 5000
DetailsRowNoStyles mount 3702 3850 5000
Dialog mount 1739 1713 1000
DocumentCardTitle mount 1978 1957 1000
Dropdown mount 2847 2783 5000
FocusZone mount 1991 1996 5000
IconButton mount 2049 2012 5000
Label mount 380 414 5000
Link mount 589 546 5000
LinkNext mount 570 580 5000
MenuButton mount 1663 1688 5000
Nav mount 3684 3653 1000
Panel mount 1617 1637 1000
Persona mount 945 931 1000
Pivot mount 1629 1522 1000
PivotNext mount 1566 1542 1000
PrimaryButton mount 1461 1464 5000
SearchBox mount 1517 1510 5000
Slider mount 1734 1833 5000
SliderNext mount 2227 2289 5000
Spinner mount 518 488 5000
SplitButton mount 3572 3565 5000
Stack mount 582 630 5000
StackWithIntrinsicChildren mount 2165 2119 5000
StackWithTextChildren mount 5661 5746 5000
TagPicker mount 3148 3226 5000
Text mount 496 475 5000
TextField mount 1674 1687 5000
ThemeProvider mount 3193 3196 5000
ThemeProvider virtual-rerender 604 544 5000
Toggle mount 1075 986 5000
ToggleNext mount 1107 1068 5000
button mount 128 116 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.56 0.57 0.98:1 2000 1113
🦄 Button.Fluent 0.14 0.22 0.64:1 5000 676
🔧 Checkbox.Fluent 0.67 0.39 1.72:1 1000 673
🎯 Dialog.Fluent 0.17 0.24 0.71:1 5000 862
🔧 Dropdown.Fluent 3.76 0.51 7.37:1 1000 3758
🔧 Icon.Fluent 0.16 0.06 2.67:1 5000 803
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 431
🔧 Slider.Fluent 1.76 0.42 4.19:1 1000 1764
🔧 Text.Fluent 0.09 0.03 3:1 5000 427
🦄 Tooltip.Fluent 0.12 19.39 0.01:1 5000 577

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TableMinimalPerf.default 484 426 1.14:1
Text.Fluent 427 382 1.12:1
SegmentMinimalPerf.default 411 374 1.1:1
VideoMinimalPerf.default 763 695 1.1:1
HeaderSlotsPerf.default 946 868 1.09:1
AttachmentMinimalPerf.default 185 175 1.06:1
GridMinimalPerf.default 879 832 1.06:1
HeaderMinimalPerf.default 435 414 1.05:1
LoaderMinimalPerf.default 837 808 1.04:1
ProviderMergeThemesPerf.default 2354 2270 1.04:1
TextAreaMinimalPerf.default 569 547 1.04:1
TreeMinimalPerf.default 1056 1016 1.04:1
Avatar.Fluent 1113 1066 1.04:1
Dropdown.Fluent 3758 3597 1.04:1
ChatDuplicateMessagesPerf.default 484 472 1.03:1
InputMinimalPerf.default 1161 1125 1.03:1
ItemLayoutMinimalPerf.default 1530 1488 1.03:1
PortalMinimalPerf.default 129 125 1.03:1
RadioGroupMinimalPerf.default 481 466 1.03:1
AccordionMinimalPerf.default 156 153 1.02:1
AnimationMinimalPerf.default 731 714 1.02:1
BoxMinimalPerf.default 385 379 1.02:1
DividerMinimalPerf.default 387 381 1.02:1
DropdownManyItemsPerf.default 1536 1513 1.02:1
LayoutMinimalPerf.default 479 468 1.02:1
CustomToolbarPrototype.default 4455 4363 1.02:1
Tooltip.Fluent 577 564 1.02:1
AvatarMinimalPerf.default 569 565 1.01:1
ChatWithPopoverPerf.default 491 485 1.01:1
DropdownMinimalPerf.default 3571 3551 1.01:1
HierarchicalTreeMinimalPerf.default 532 526 1.01:1
ListNestedPerf.default 1008 1001 1.01:1
ReactionMinimalPerf.default 448 445 1.01:1
TooltipMinimalPerf.default 842 831 1.01:1
ChatMinimalPerf.default 683 681 1:1
CheckboxMinimalPerf.default 3160 3165 1:1
DialogMinimalPerf.default 837 841 1:1
FlexMinimalPerf.default 339 338 1:1
MenuMinimalPerf.default 990 991 1:1
TextMinimalPerf.default 394 394 1:1
Button.Fluent 676 677 1:1
Dialog.Fluent 862 858 1:1
Slider.Fluent 1764 1769 1:1
ButtonSlotsPerf.default 655 661 0.99:1
ListMinimalPerf.default 540 543 0.99:1
Checkbox.Fluent 673 679 0.99:1
AttachmentSlotsPerf.default 1316 1347 0.98:1
CardMinimalPerf.default 671 682 0.98:1
CarouselMinimalPerf.default 530 541 0.98:1
EmbedMinimalPerf.default 2134 2181 0.98:1
FormMinimalPerf.default 476 485 0.98:1
ImageMinimalPerf.default 433 440 0.98:1
LabelMinimalPerf.default 454 465 0.98:1
ListWith60ListItems.default 1220 1243 0.98:1
RefMinimalPerf.default 230 234 0.98:1
SplitButtonMinimalPerf.default 3890 3971 0.98:1
PopupMinimalPerf.default 286 295 0.97:1
IconMinimalPerf.default 733 755 0.97:1
Icon.Fluent 803 825 0.97:1
MenuButtonMinimalPerf.default 1395 1456 0.96:1
StatusMinimalPerf.default 748 778 0.96:1
TableManyItemsPerf.default 2510 2610 0.96:1
Image.Fluent 431 448 0.96:1
ButtonMinimalPerf.default 194 204 0.95:1
SliderMinimalPerf.default 1736 1825 0.95:1
ToolbarMinimalPerf.default 1023 1073 0.95:1
TreeWith60ListItems.default 232 248 0.94:1
ListCommonPerf.default 1046 1133 0.92:1
ProviderMinimalPerf.default 899 988 0.91:1
AlertMinimalPerf.default 308 342 0.9:1

@size-auditor
Copy link

size-auditor bot commented Jun 10, 2020

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 2eb44fc

Possible causes

  • The baseline build 2eb44fc is broken
  • The Size Auditor run for the baseline build 2eb44fc was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@msft-github-bot
Copy link
Contributor

Hello @khmakoto!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@msft-github-bot msft-github-bot merged commit e9b2826 into microsoft:master Jun 11, 2020
@khmakoto khmakoto deleted the pivotItemHeaderButtonType branch June 11, 2020 16:34
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.120.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoard bcoard bcoard approved these changes

@behowell behowell behowell approved these changes

Assignees

@jdhuntington jdhuntington

Labels
AutoMerge Component: Pivot PR: API Modified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@khmakoto @msft-github-bot @bcoard @behowell @jdhuntington