Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coachmark: Migrate Coachmark and associated components to function components #13626

Merged
merged 73 commits into from
Aug 5, 2020
Merged

Coachmark: Migrate Coachmark and associated components to function components #13626

merged 73 commits into from
Aug 5, 2020

Commits on Jun 9, 2020

  1. Copy Coachmark code to react-next to stage migration

    @MLoughry
    MLoughry committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    21c2584 View commit details
    Browse the repository at this point in the history

  2. Change files

    @MLoughry
    MLoughry committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    578df06 View commit details
    Browse the repository at this point in the history

  3. Migrate Beak to function component

    @MLoughry
    MLoughry committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    879d2fd View commit details
    Browse the repository at this point in the history

  4. Add stub function component for PositioningContainer

    @MLoughry
    MLoughry committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    3b2317f View commit details
    Browse the repository at this point in the history

  5. Hoist default props and contentHost ref

    @MLoughry
    MLoughry committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    daa5f10 View commit details
    Browse the repository at this point in the history

  6. Hoist several refs

    @MLoughry
    MLoughry committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    639b6a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into react-nex… 

    …t-copy/Coachmark
    @MLoughry
    MLoughry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    7dd9ccf View commit details
    Browse the repository at this point in the history

  2. Fix lint issues

    @MLoughry
    MLoughry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    e758260 View commit details
    Browse the repository at this point in the history

  3. Hoist event logic

    @MLoughry
    MLoughry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    688c4e9 View commit details
    Browse the repository at this point in the history

  4. Update API

    @MLoughry
    MLoughry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    3e18ce7 View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @MLoughry
    MLoughry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    7a62abd View commit details
    Browse the repository at this point in the history

  6. Hoist heightOffset logic

    @MLoughry
    MLoughry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    b3c760c View commit details
    Browse the repository at this point in the history

  7. Finish migration (with issues)

    @MLoughry
    MLoughry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    d864edc View commit details
    Browse the repository at this point in the history

  8. Revert to LKG, fixing example import

    @MLoughry
    MLoughry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    b7e8c81 View commit details
    Browse the repository at this point in the history

  9. Hoist positionedHost ref

    @MLoughry
    MLoughry committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    180ae9d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Hoist target refs

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    7a7a34f View commit details
    Browse the repository at this point in the history

  2. Hoist positions state

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    31c1d40 View commit details
    Browse the repository at this point in the history

  3. Hoist setInitialFocus

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    21b61f2 View commit details
    Browse the repository at this point in the history

  4. Hoist maxHeight

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    0f7acff View commit details
    Browse the repository at this point in the history

  5. Hoist auto-dismiss events

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    b5539fd View commit details
    Browse the repository at this point in the history

  6. Hoist heightOffset

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    9876e5f View commit details
    Browse the repository at this point in the history

  7. Complete PositioningContainer migration

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    cdaaa8d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of github.com:microsoft/fluentui into react-nex… 

    …t-copy/Coachmark
    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    681336f View commit details
    Browse the repository at this point in the history

  9. Remove extraneous shouldComponentUpdate

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    82efc99 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'react-next-copy/Coachmark' into functional/Coachmark

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    2bf0648 View commit details
    Browse the repository at this point in the history

  11. Hoist generic function

    @MLoughry
    MLoughry committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    ffafadc View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Create stub function component

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    a0ee77c View commit details
    Browse the repository at this point in the history

  2. Hoist entityInnerHostElementRef

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    561732d View commit details
    Browse the repository at this point in the history

  3. Hoist isCollapsed state

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    7ddcbf5 View commit details
    Browse the repository at this point in the history

  4. Hoist positioned data

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    9ef37ea View commit details
    Browse the repository at this point in the history

  5. Hoist beak positioning logic

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    2ac8300 View commit details
    Browse the repository at this point in the history

  6. Hoist dismiss public method

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    fd6498a View commit details
    Browse the repository at this point in the history

  7. Hoist document event logic

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    9affc04 View commit details
    Browse the repository at this point in the history

  8. Hoist proximity handlers

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    8f04fb3 View commit details
    Browse the repository at this point in the history

  9. Hoist aria text logic

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    0a0db60 View commit details
    Browse the repository at this point in the history

  10. Cleanup unused state

    @MLoughry
    MLoughry committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    a89ed7b View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Hoist autofocus logic

    @MLoughry
    MLoughry committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    6373c6a View commit details
    Browse the repository at this point in the history

  2. Hoist last of state

    @MLoughry
    MLoughry committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    41dcd54 View commit details
    Browse the repository at this point in the history

  3. Finish migration

    @MLoughry
    MLoughry committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    ef8d8c2 View commit details
    Browse the repository at this point in the history

  4. Forward ref

    @MLoughry
    MLoughry committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    88ebd1f View commit details
    Browse the repository at this point in the history

  5. Update API

    @MLoughry
    MLoughry committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    dd2b21f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    2c820d0 View commit details
    Browse the repository at this point in the history

  7. Change files

    @MLoughry
    MLoughry committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    2ce5e13 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    8943fd0 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    cf7232e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    1c1228f View commit details
    Browse the repository at this point in the history

  2. Add Screener test

    @MLoughry
    MLoughry committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    7ed9e54 View commit details
    Browse the repository at this point in the history

  3. Fix lint error

    @MLoughry
    MLoughry committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    f029a1e View commit details
    Browse the repository at this point in the history

  4. Fix cropping of Coachmark story

    @MLoughry
    MLoughry committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    21af779 View commit details
    Browse the repository at this point in the history

  5. Fix case where Coahmark starts expanded

    @MLoughry
    MLoughry committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    26478ff View commit details
    Browse the repository at this point in the history

  6. Fix API file

    @MLoughry
    MLoughry committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    f7d63c3 View commit details
    Browse the repository at this point in the history

  7. Pull from react-next

    @MLoughry
    MLoughry committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    4397c67 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    a88cd4c View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    d917560 View commit details
    Browse the repository at this point in the history

  2. Fix bad merge

    @MLoughry
    MLoughry committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    ed37972 View commit details
    Browse the repository at this point in the history

  3. Duplicate Coachamrk Screener test for OUFR

    @MLoughry
    MLoughry committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    ee705cd View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    806ca73 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Remove headers

    @MLoughry
    MLoughry committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    b437a81 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    8d1869a View commit details
    Browse the repository at this point in the history

  3. Handle removed props

    @MLoughry
    MLoughry committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    b136a1e View commit details
    Browse the repository at this point in the history

  4. Deprecate Beak componentRef

    @MLoughry
    MLoughry committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    f6d5677 View commit details
    Browse the repository at this point in the history

  5. Update packages/react-next/src/components/Coachmark/Coachmark.base.tsx 

    Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
    @MLoughry @ecraig12345
    MLoughry and ecraig12345 committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    a59ce5b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'functional/Coachmark' of github.com:MLoughry/office-ui-… 

    …fabric-react into functional/Coachmark
    @MLoughry
    MLoughry committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    0e7c864 View commit details
    Browse the repository at this point in the history

  7. Fix eslint deprecation errors

    @MLoughry
    MLoughry committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    d97b7fe View commit details
    Browse the repository at this point in the history

  8. Change files

    @MLoughry
    MLoughry committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    b3f5264 View commit details
    Browse the repository at this point in the history

  9. Update API

    @MLoughry
    MLoughry committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    ff64863 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    eb916f1 View commit details
    Browse the repository at this point in the history

  2. Fix build error

    @MLoughry
    MLoughry committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    1281ef2 View commit details
    Browse the repository at this point in the history

  3. Fix build issues

    @MLoughry
    MLoughry committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    b1636ad View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    8de68f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    9413063 View commit details
    Browse the repository at this point in the history

  2. Remove rejected screener story

    @MLoughry
    MLoughry committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    2c85db9 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. Merge branch 'master' of github.com:microsoft/fluentui into functiona… 

    …l/Coachmark
    @MLoughry
    MLoughry committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    889ece0 View commit details
    Browse the repository at this point in the history