MenuButton: Creating component using compose #13812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khmakoto
requested review from
dzearing,
xugao,
mnajdova,
ecraig12345,
miroslavstastny,
jurokapsiar,
layershifter,
joschect and
behowell
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e8270ad:
|
Asset size changes
Baseline commit: 5622cd353f0dc368f8ffe4d59af2ee40c60f5053 (build) |
dzearing
reviewed
Jun 26, 2020
joschect
reviewed
Jun 26, 2020
| import { ButtonProps, ButtonTokens } from '../Button/Button.types'; | ||
|
|
||
| export interface MenuButtonProps extends Omit<ButtonProps, 'icon' | 'iconPosition' | 'loader'> { | ||
| /** |
There was a problem hiding this comment.
Out of curiosity, why can't a menu button have an icon to the left?
There was a problem hiding this comment.
I wanted to omit extra icons when having a MenuButton besides the menuIcon itself.
This brings a good point of discussion though:
- Should we allow the
menuIconto be on the left as well? - Should we allow for an
iconbesides themenuIcon? - If so, should we allow that
iconto be able to exist before and after the content or just before?
xugao
reviewed
Jun 26, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.tsx
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jun 26, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.tsx
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jun 26, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.tsx
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jun 26, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.tsx
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jun 26, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.tsx
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jun 26, 2020
packages/react-button/src/components/MenuButton/MenuButtonBase.tsx
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jun 26, 2020
packages/react-button/src/components/MenuButton/MenuButtonBase.tsx
Outdated
Show resolved
Hide resolved
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
xugao
reviewed
Jun 29, 2020
packages/react-button/src/components/MenuButton/MenuButton.scss
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jun 29, 2020
xugao
reviewed
Jun 29, 2020
xugao
reviewed
Jun 29, 2020
packages/react-button/src/components/MenuButton/useMenuButton.ts
Outdated
Show resolved
Hide resolved
xugao
approved these changes
Jun 29, 2020
xugao
reviewed
Jun 30, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.ts
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jun 30, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.ts
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jun 30, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.ts
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jul 8, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.ts
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jul 8, 2020
packages/react-button/src/components/MenuButton/MenuButton.types.ts
Outdated
Show resolved
Hide resolved
… slot to mergeSlotProp call.
xugao
approved these changes
Jul 8, 2020
joschect
approved these changes
Jul 8, 2020
dzearing
approved these changes
Jul 8, 2020
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This is a first stab at a
MenuButtoncomponent usingcompose. At the moment I'm making using ofContextualMenuto build this but only on the opinionated version and we can swap it for whatever once we have a more refined newMenucomponent.Focus areas to test
(optional)