Button: Adding visual regression tests for focused scenarios #13832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d433ef8:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 796868d7faad91ca11150b9c8c5c3efb80e543ac (build) |
xugao
reviewed
Jun 29, 2020
| "document.getElementsByClassName('testWrapper')[0].classList.add('ms-Fabric--isFocusVisible')", | ||
| ) | ||
| .executeScript("document.getElementsByTagName('button')[0].focus()") | ||
| .snapshot('focus', { cropTo: '.testWrapper' }) |
There was a problem hiding this comment.
i don't see new screener screenshots for the focus step?
There was a problem hiding this comment.
What do you mean? If you click on the screener results they are there:
xugao
approved these changes
Jun 30, 2020
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR adds visual regression tests for scenarios where the
Buttonhas been focused.Focus areas to test
(optional)