Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical stacked bar chart: fit container updated to chart #13860

Merged

Conversation

jameelakowsar
Copy link
Contributor

@jameelakowsar jameelakowsar commented Jun 30, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

In Vertical stacked bar chart,
Fit container - auto adjust of height and width of chart when resize of parent div of chart code updated.

Focus areas to test

Vertical stacked bar chart

Vertical stacked bar chart image

image

Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) added 3 commits June 30, 2020 16:08
@jameelakowsar jameelakowsar changed the title User/v jasha/vs barchart enhancements Vertical stacked bar chart: fit container updated to chart Jun 30, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5282d00:

Sandbox Source
Fluent UI Button Configuration

@size-auditor
Copy link

size-auditor bot commented Jun 30, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 6525619bf5e6c844406ed3cb9ad3103237eff89f (build)

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 946 946 5000
ButtonNext mount 612 635 5000
Checkbox mount 1661 1679 5000
CheckboxBase mount 1398 1497 5000
CheckboxNext mount 1711 1691 5000
ChoiceGroup mount 5389 5409 5000
ComboBox mount 921 924 1000
CommandBar mount 7942 7858 1000
ContextualMenu mount 15146 14886 1000
DefaultButton mount 1151 1170 5000
DetailsRow mount 3767 3720 5000
DetailsRowFast mount 3800 3779 5000
DetailsRowNoStyles mount 3515 3540 5000
Dialog mount 1626 1590 1000
DocumentCardTitle mount 1824 1876 1000
Dropdown mount 2723 2680 5000
FocusZone mount 1843 1886 5000
IconButton mount 1903 1887 5000
Label mount 351 376 5000
Link mount 458 499 5000
LinkNext mount 493 492 5000
MenuButton mount 1547 1556 5000
Nav mount 3349 3363 1000
Panel mount 1506 1549 1000
Persona mount 909 906 1000
Pivot mount 1484 1470 1000
PivotNext mount 1424 1398 1000
PrimaryButton mount 1361 1356 5000
SearchBox mount 1385 1389 5000
SearchBoxNext mount 1491 1452 5000
Slider mount 1652 1647 5000
SliderNext mount 2141 2086 5000
Spinner mount 457 457 5000
SplitButton mount 3294 3402 5000
Stack mount 552 571 5000
StackWithIntrinsicChildren mount 2123 2139 5000
StackWithTextChildren mount 5401 5461 5000
TagPicker mount 3056 2992 5000
Text mount 473 436 5000
TextField mount 1542 1528 5000
ThemeProvider mount 3088 2873 5000
ThemeProvider virtual-rerender 535 497 5000
Toggle mount 950 926 5000
ToggleNext mount 885 932 5000
button mount 112 116 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.46 0.5 0.92:1 2000 922
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 592
🔧 Checkbox.Fluent 0.68 0.37 1.84:1 1000 680
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 802
🔧 Dropdown.Fluent 3.41 0.52 6.56:1 1000 3408
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 745
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 404
🔧 Slider.Fluent 1.62 0.37 4.38:1 1000 1617
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 348
🦄 Tooltip.Fluent 0.1 19.05 0.01:1 5000 498

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ListWith60ListItems.default 1358 1108 1.23:1
AccordionMinimalPerf.default 154 139 1.11:1
LabelMinimalPerf.default 454 415 1.09:1
PortalMinimalPerf.default 133 122 1.09:1
AttachmentMinimalPerf.default 180 166 1.08:1
TableMinimalPerf.default 443 412 1.08:1
TreeWith60ListItems.default 237 220 1.08:1
ListCommonPerf.default 1046 974 1.07:1
TreeMinimalPerf.default 946 884 1.07:1
AvatarMinimalPerf.default 512 481 1.06:1
FormMinimalPerf.default 453 429 1.06:1
ListMinimalPerf.default 498 469 1.06:1
AnimationMinimalPerf.default 412 393 1.05:1
DropdownManyItemsPerf.default 1469 1403 1.05:1
LayoutMinimalPerf.default 423 402 1.05:1
MenuButtonMinimalPerf.default 1634 1563 1.05:1
TableManyItemsPerf.default 2437 2314 1.05:1
VideoMinimalPerf.default 687 657 1.05:1
ButtonSlotsPerf.default 643 616 1.04:1
EmbedMinimalPerf.default 2075 1990 1.04:1
HeaderMinimalPerf.default 388 373 1.04:1
MenuMinimalPerf.default 898 861 1.04:1
Checkbox.Fluent 680 651 1.04:1
CardMinimalPerf.default 614 598 1.03:1
HeaderSlotsPerf.default 841 813 1.03:1
RefMinimalPerf.default 215 209 1.03:1
Image.Fluent 404 391 1.03:1
ButtonMinimalPerf.default 187 183 1.02:1
CarouselMinimalPerf.default 497 486 1.02:1
DialogMinimalPerf.default 804 789 1.02:1
DropdownMinimalPerf.default 3432 3356 1.02:1
FlexMinimalPerf.default 288 281 1.02:1
IconMinimalPerf.default 714 699 1.02:1
ChatDuplicateMessagesPerf.default 451 445 1.01:1
CheckboxMinimalPerf.default 2950 2932 1.01:1
ListNestedPerf.default 927 914 1.01:1
PopupMinimalPerf.default 666 662 1.01:1
ProviderMergeThemesPerf.default 1927 1900 1.01:1
RadioGroupMinimalPerf.default 453 448 1.01:1
SplitButtonMinimalPerf.default 3980 3938 1.01:1
TextAreaMinimalPerf.default 515 512 1.01:1
TooltipMinimalPerf.default 790 786 1.01:1
Button.Fluent 592 585 1.01:1
BoxMinimalPerf.default 371 370 1:1
DividerMinimalPerf.default 376 375 1:1
ItemLayoutMinimalPerf.default 1336 1338 1:1
SliderMinimalPerf.default 1644 1646 1:1
StatusMinimalPerf.default 731 733 1:1
Avatar.Fluent 922 924 1:1
Dropdown.Fluent 3408 3422 1:1
GridMinimalPerf.default 765 776 0.99:1
HierarchicalTreeMinimalPerf.default 446 452 0.99:1
ImageMinimalPerf.default 397 402 0.99:1
InputMinimalPerf.default 1070 1086 0.99:1
LoaderMinimalPerf.default 760 764 0.99:1
ProviderMinimalPerf.default 901 912 0.99:1
CustomToolbarPrototype.default 3758 3811 0.99:1
AlertMinimalPerf.default 314 319 0.98:1
SegmentMinimalPerf.default 359 365 0.98:1
Icon.Fluent 745 764 0.98:1
Slider.Fluent 1617 1643 0.98:1
AttachmentSlotsPerf.default 1175 1207 0.97:1
ToolbarMinimalPerf.default 989 1020 0.97:1
Dialog.Fluent 802 830 0.97:1
Tooltip.Fluent 498 513 0.97:1
TextMinimalPerf.default 330 343 0.96:1
ChatMinimalPerf.default 609 647 0.94:1
Text.Fluent 348 370 0.94:1
ChatWithPopoverPerf.default 467 501 0.93:1
ReactionMinimalPerf.default 394 427 0.92:1

Copy link
Contributor

@Raghurk Raghurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Raghurk Raghurk merged commit 1f2048c into microsoft:master Jul 8, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v2.5.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants