Add new codemods package #13884
Merged
Add new codemods package #13884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f785759:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b4adf81c515bd8fcee8264da0dd93d23f881f3cd (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
khmakoto
reviewed
Jul 2, 2020
packages/codemods/src/codeMods/__tests__/ComponentToCompat/ComponentToCompat.test.ts
Outdated
Show resolved
Hide resolved
packages/codemods/src/codeMods/__tests__/ComponentToCompat/ComponentToCompat.test.ts
Outdated
Show resolved
Hide resolved
ecraig12345
requested changes
Jul 6, 2020
packages/codemods/src/codeMods/__tests__/ComponentToCompat/ComponentToCompat.test.ts
Outdated
Show resolved
Hide resolved
packages/codemods/src/codeMods/__tests__/ComponentToCompat/ComponentToCompat.test.ts
Outdated
Show resolved
Hide resolved
dzearing
reviewed
Jul 6, 2020
dzearing
reviewed
Jul 6, 2020
packages/codemods/src/codeMods/mods/PersonaToAvatar/PersonaToAvatar.mod.ts
Outdated
Show resolved
Hide resolved
dzearing
reviewed
Jul 6, 2020
Comment on lines
164
to
170
| replacePersonaImport(file); | ||
| replaceIPersonaPropsImport(file); | ||
| replacePersonaSizeImport(file); | ||
| renamePrimaryTextProp(file); | ||
| renameRenderCoin(file); |
There was a problem hiding this comment.
These right here; in my suggestion above, could these be just replacement types in a config?
Some of them probably not. E.g. renameRenderCoin finds Persona jsx elements and renames onRenderCoin to onRenderAvatarCoin (which I think is wrong btw.)
There was a problem hiding this comment.
So, you may need a custom type which does some sort of manual work programatically. But whatever we can do to simplify and keep the codemod data driven is good.
There was a problem hiding this comment.
This is more of a proof of concept for right now that I should make more clear.
As for the config, we could potentially allow some of these to take in a json blob. For the start we should get the api of the functions correct. Trip and I are working on that.
ecraig12345
reviewed
Jul 7, 2020
packages/codemods/src/codeMods/mods/ComponentToCompat/CompatHelpers.ts
Outdated
Show resolved
Hide resolved
packages/codemods/src/codeMods/__tests__/ComponentToCompat/ComponentToCompat.test.ts
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| it('correctly repaths from index', () => { | ||
| const file = project.getSourceFileOrThrow('ImportsStuff.tsx'); |
There was a problem hiding this comment.
I'm having trouble understanding what some of the rest of these do too, since you're using fake files which don't actually reference OUFR.
There was a problem hiding this comment.
It's making sure that the utilities/each individual piece does the job that it's supposed to do. That way when they all get put together it will work as expected.
There was a problem hiding this comment.
Part of what I meant by that was that it would be helpful to have more comments explaining what each one does. And I'm still having trouble how it works with fake files which don't actually reference OUFR.
packages/codemods/src/codeMods/__tests__/ComponentToCompat/ComponentToCompat.test.ts
Outdated
Show resolved
Hide resolved
ecraig12345
reviewed
Jul 7, 2020
| const tVal = val as InterfaceDeclaration; | ||
| const struct = tVal.getStructure(); | ||
| expect( | ||
| (struct.extends as string[])?.some(str => { |
There was a problem hiding this comment.
What happens if struct.extends isn't defined?
There was a problem hiding this comment.
It has to be defined, at least that's a guarantee when you call getStructure()
There was a problem hiding this comment.
In that case can you use ! instead of ?
ecraig12345
reviewed
Jul 7, 2020
packages/codemods/src/codeMods/__tests__/personaToAvatar/componentMod.test.ts
Outdated
Show resolved
Hide resolved
ecraig12345
reviewed
Jul 7, 2020
packages/codemods/src/codeMods/__tests__/personaToAvatar/propsMod.test.ts
Outdated
Show resolved
Hide resolved
ecraig12345
reviewed
Jul 7, 2020
packages/codemods/src/codeMods/__tests__/personaToAvatar/componentMod.test.ts
Outdated
Show resolved
Hide resolved
ecraig12345
reviewed
Jul 7, 2020
packages/codemods/src/codeMods/__tests__/utilities/importUtils.test.ts
Outdated
Show resolved
Hide resolved
ecraig12345
reviewed
Jul 7, 2020
packages/codemods/src/codeMods/__tests__/utilities/importUtils.test.ts
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jul 7, 2020
packages/codemods/src/codeMods/__tests__/utilities/importUtils.test.ts
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jul 7, 2020
xugao
reviewed
Jul 7, 2020
xugao
reviewed
Jul 7, 2020
packages/codemods/src/codeMods/mods/ComponentToCompat/CompatHelpers.ts
Outdated
Show resolved
Hide resolved
xugao
reviewed
Jul 7, 2020
packages/codemods/src/codeMods/__tests__/ComponentToCompat/ComponentToCompat.test.ts
Outdated
Show resolved
Hide resolved
ecraig12345
reviewed
Jul 8, 2020
ecraig12345
reviewed
Jul 8, 2020
xugao
reviewed
Jul 8, 2020
xugao
reviewed
Jul 8, 2020
packages/codemods/src/codeMods/mods/PersonaToAvatar/PersonaToAvatar.mod.ts
Outdated
Show resolved
Hide resolved
khmakoto
reviewed
Jul 8, 2020
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> Co-authored-by: Xu Gao <xugao0131@hotmail.com>
xugao
reviewed
Jul 8, 2020
ecraig12345
approved these changes
Jul 8, 2020
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Adds the basis for codemods. Work that this completes:
The primary files to focus on are
upgrade.tsandrunnerUtilities. These setup the framework for how codemods will run. Additional work still needs to be done to:Focus areas to test
(optional)