Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line chart: Remove Duplicate ID's for lines and circles #13897

Merged
merged 2 commits into from Jul 2, 2020
Merged

Line chart: Remove Duplicate ID's for lines and circles #13897

merged 2 commits into from Jul 2, 2020

Conversation

RajeshGoriga
Copy link
Contributor

@RajeshGoriga RajeshGoriga commented Jul 2, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Line chart: Remove Duplicate ID's for lines and circles
To fix this issue https://office.visualstudio.com/OC/_workitems/edit/4227510/ related to charting package

Focus areas to test

run axe tool on line chart

Microsoft Reviewers: Open in CodeFlow

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ac6f22c:

Sandbox Source
Fluent UI Button Configuration
blissful-booth-dycem Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 720 722 5000
ButtonNext mount 495 485 5000
Checkbox mount 1334 1291 5000
CheckboxBase mount 1107 1061 5000
CheckboxNext mount 1285 1313 5000
ChoiceGroup mount 4170 4148 5000
ComboBox mount 778 767 1000
CommandBar mount 6521 6402 1000
ContextualMenu mount 12311 12662 1000
DefaultButton mount 918 909 5000
DetailsRow mount 2943 2882 5000
DetailsRowFast mount 2941 2888 5000
DetailsRowNoStyles mount 2748 2778 5000
Dialog mount 1270 1299 1000
DocumentCardTitle mount 1512 1550 1000
Dropdown mount 2119 2103 5000
FocusZone mount 1491 1542 5000
IconButton mount 1431 1428 5000
Label mount 296 288 5000
Link mount 397 390 5000
LinkNext mount 386 396 5000
MenuButton mount 1215 1176 5000
Nav mount 2705 2694 1000
Panel mount 1166 1258 1000
Persona mount 725 702 1000
Pivot mount 1189 1175 1000
PivotNext mount 1148 1095 1000
PrimaryButton mount 1020 1022 5000
SearchBox mount 1077 1072 5000
SearchBoxNext mount 1124 1300 5000
Slider mount 1313 1310 5000
SliderNext mount 1701 1692 5000
Spinner mount 383 360 5000
SplitButton mount 2660 2578 5000
Stack mount 422 431 5000
StackWithIntrinsicChildren mount 1656 1629 5000
StackWithTextChildren mount 4152 4159 5000
TagPicker mount 2327 2365 5000
Text mount 355 354 5000
TextField mount 1214 1155 5000
ThemeProvider mount 2485 2422 5000
ThemeProvider virtual-rerender 438 432 5000
Toggle mount 706 710 5000
ToggleNext mount 716 679 5000
button mount 93 96 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.35 0.4 0.87:1 2000 696
🦄 Button.Fluent 0.09 0.15 0.6:1 5000 425
🔧 Checkbox.Fluent 0.53 0.28 1.89:1 1000 530
🦄 Dialog.Fluent 0.13 0.19 0.68:1 5000 628
🔧 Dropdown.Fluent 2.76 0.38 7.26:1 1000 2757
🔧 Icon.Fluent 0.11 0.04 2.75:1 5000 551
🦄 Image.Fluent 0.06 0.09 0.67:1 5000 303
🔧 Slider.Fluent 1.32 0.28 4.71:1 1000 1324
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 265
🦄 Tooltip.Fluent 0.09 16.86 0.01:1 5000 426

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CardMinimalPerf.default 463 420 1.1:1
ImageMinimalPerf.default 294 268 1.1:1
Dialog.Fluent 628 569 1.1:1
BoxMinimalPerf.default 277 256 1.08:1
FormMinimalPerf.default 329 306 1.08:1
FlexMinimalPerf.default 237 222 1.07:1
GridMinimalPerf.default 274 259 1.06:1
ListWith60ListItems.default 912 864 1.06:1
ToolbarMinimalPerf.default 784 743 1.06:1
VideoMinimalPerf.default 518 495 1.05:1
AnimationMinimalPerf.default 324 313 1.04:1
ButtonMinimalPerf.default 146 140 1.04:1
CarouselMinimalPerf.default 372 358 1.04:1
IconMinimalPerf.default 536 514 1.04:1
Checkbox.Fluent 530 512 1.04:1
ListNestedPerf.default 725 705 1.03:1
Image.Fluent 303 293 1.03:1
Tooltip.Fluent 426 413 1.03:1
AttachmentMinimalPerf.default 128 126 1.02:1
InputMinimalPerf.default 846 830 1.02:1
ReactionMinimalPerf.default 296 290 1.02:1
TableManyItemsPerf.default 1782 1743 1.02:1
TreeMinimalPerf.default 707 696 1.02:1
Dropdown.Fluent 2757 2703 1.02:1
AttachmentSlotsPerf.default 957 947 1.01:1
ChatDuplicateMessagesPerf.default 355 352 1.01:1
ChatMinimalPerf.default 492 486 1.01:1
DropdownManyItemsPerf.default 1153 1142 1.01:1
HeaderMinimalPerf.default 287 283 1.01:1
ItemLayoutMinimalPerf.default 987 980 1.01:1
LayoutMinimalPerf.default 321 319 1.01:1
LoaderMinimalPerf.default 602 599 1.01:1
MenuMinimalPerf.default 684 679 1.01:1
PopupMinimalPerf.default 551 545 1.01:1
RadioGroupMinimalPerf.default 320 318 1.01:1
SegmentMinimalPerf.default 272 269 1.01:1
SplitButtonMinimalPerf.default 3032 3000 1.01:1
TableMinimalPerf.default 322 320 1.01:1
TreeWith60ListItems.default 173 172 1.01:1
Button.Fluent 425 420 1.01:1
DialogMinimalPerf.default 621 623 1:1
EmbedMinimalPerf.default 1539 1537 1:1
HierarchicalTreeMinimalPerf.default 330 330 1:1
PortalMinimalPerf.default 100 100 1:1
RefMinimalPerf.default 169 169 1:1
TextMinimalPerf.default 276 276 1:1
ChatWithPopoverPerf.default 381 386 0.99:1
CheckboxMinimalPerf.default 2302 2325 0.99:1
LabelMinimalPerf.default 318 322 0.99:1
ProviderMergeThemesPerf.default 1562 1572 0.99:1
SliderMinimalPerf.default 1309 1328 0.99:1
CustomToolbarPrototype.default 3059 3101 0.99:1
TooltipMinimalPerf.default 597 605 0.99:1
Icon.Fluent 551 559 0.99:1
AlertMinimalPerf.default 232 236 0.98:1
AvatarMinimalPerf.default 356 363 0.98:1
ListCommonPerf.default 742 761 0.98:1
ListMinimalPerf.default 371 380 0.98:1
MenuButtonMinimalPerf.default 1222 1245 0.98:1
ProviderMinimalPerf.default 720 735 0.98:1
Slider.Fluent 1324 1350 0.98:1
AccordionMinimalPerf.default 125 129 0.97:1
DropdownMinimalPerf.default 2724 2817 0.97:1
HeaderSlotsPerf.default 591 610 0.97:1
StatusMinimalPerf.default 529 545 0.97:1
TextAreaMinimalPerf.default 356 368 0.97:1
ButtonSlotsPerf.default 484 504 0.96:1
Avatar.Fluent 696 724 0.96:1
Text.Fluent 265 279 0.95:1
DividerMinimalPerf.default 271 298 0.91:1

@size-auditor
Copy link

size-auditor bot commented Jul 2, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 70fde20da35fdb66574ec0f9f981737f113df7e3 (build)

Copy link
Contributor

@Raghurk Raghurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v2.3.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants