Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker: showDatePickerPopup should be public #13981

Merged
merged 6 commits into from Jul 10, 2020
Merged

DatePicker: showDatePickerPopup should be public #13981

merged 6 commits into from Jul 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 10, 2020 •
edited by ghost

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Make showDatePickerPopup public so that, date callout can be opened.

(give an overview)

Focus areas to test

(optional)

@ghost ghost requested review from evlevy and lorejoh12 as code owners July 10, 2020 05:42
@ghost
Copy link

ghost commented Jul 10, 2020 •
edited by ghost

CLA assistant check
All CLA requirements met.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4070c50:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 10, 2020 •
edited

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-next-DatePicker 173.746 kB 173.741 kB BelowBaseline     -5 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 8df4df38a9af3fe5dccf54c5db844af4805cfc83 (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Jul 10, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 866 862 5000
ButtonNext mount 545 565 5000
Checkbox mount 1535 1500 5000
CheckboxBase mount 1317 1300 5000
CheckboxNext mount 1534 1513 5000
ChoiceGroup mount 4821 4748 5000
ComboBox mount 879 908 1000
CommandBar mount 7423 7405 1000
ContextualMenu mount 12578 12754 1000
DefaultButton mount 1100 1078 5000
DetailsRow mount 3397 3496 5000
DetailsRowFast mount 3386 3454 5000
DetailsRowNoStyles mount 3260 3149 5000
Dialog mount 1393 1424 1000
DocumentCardTitle mount 1763 1806 1000
Dropdown mount 2417 2343 5000
FocusZone mount 1688 1714 5000
IconButton mount 1689 1678 5000
Label mount 318 316 5000
Link mount 410 420 5000
LinkNext mount 423 434 5000
MenuButton mount 1348 1340 5000
Nav mount 3033 3015 1000
Panel mount 1368 1392 1000
Persona mount 799 756 1000
Pivot mount 1321 1300 1000
PivotNext mount 1267 1261 1000
PrimaryButton mount 1193 1179 5000
SearchBox mount 1153 1192 5000
SearchBoxNext mount 1234 1216 5000
Slider mount 1387 1359 5000
SliderNext mount 1804 1774 5000
Spinner mount 405 424 5000
SplitButton mount 2904 2882 5000
Stack mount 510 487 5000
StackWithIntrinsicChildren mount 1826 1792 5000
StackWithTextChildren mount 4616 4632 5000
TagPicker mount 2574 2675 5000
Text mount 390 404 5000
TextField mount 1269 1295 5000
ThemeProvider mount 2860 2731 5000
ThemeProvider virtual-rerender 497 482 5000
Toggle mount 758 802 5000
ToggleNext mount 763 737 5000
button mount 107 106 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.42 0.47 0.89:1 2000 830
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 515
🔧 Checkbox.Fluent 0.62 0.34 1.82:1 1000 623
🦄 Dialog.Fluent 0.14 0.21 0.67:1 5000 723
🔧 Dropdown.Fluent 2.89 0.45 6.42:1 1000 2891
🔧 Icon.Fluent 0.13 0.05 2.6:1 5000 664
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 347
🔧 Slider.Fluent 1.53 0.33 4.64:1 1000 1530
🔧 Text.Fluent 0.06 0.02 3:1 5000 305
🦄 Tooltip.Fluent 0.1 16.12 0.01:1 5000 484

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 299 262 1.14:1
HeaderMinimalPerf.default 342 309 1.11:1
LabelMinimalPerf.default 400 365 1.1:1
AccordionMinimalPerf.default 143 134 1.07:1
FormMinimalPerf.default 389 363 1.07:1
IconMinimalPerf.default 611 570 1.07:1
BoxMinimalPerf.default 330 312 1.06:1
MenuMinimalPerf.default 831 783 1.06:1
TableMinimalPerf.default 391 370 1.06:1
AlertMinimalPerf.default 296 281 1.05:1
ButtonMinimalPerf.default 159 152 1.05:1
ListWith60ListItems.default 1066 1019 1.05:1
TreeWith60ListItems.default 214 203 1.05:1
Image.Fluent 347 330 1.05:1
LoaderMinimalPerf.default 739 713 1.04:1
SliderMinimalPerf.default 1555 1494 1.04:1
DropdownManyItemsPerf.default 701 679 1.03:1
LayoutMinimalPerf.default 363 352 1.03:1
ListCommonPerf.default 917 891 1.03:1
CardMinimalPerf.default 526 516 1.02:1
ChatDuplicateMessagesPerf.default 399 390 1.02:1
ChatWithPopoverPerf.default 431 424 1.02:1
ItemLayoutMinimalPerf.default 1224 1203 1.02:1
ProviderMinimalPerf.default 837 818 1.02:1
ReactionMinimalPerf.default 352 344 1.02:1
RefMinimalPerf.default 189 186 1.02:1
SplitButtonMinimalPerf.default 3599 3526 1.02:1
CustomToolbarPrototype.default 3666 3609 1.02:1
ToolbarMinimalPerf.default 916 896 1.02:1
TooltipMinimalPerf.default 745 729 1.02:1
TreeMinimalPerf.default 832 815 1.02:1
CheckboxMinimalPerf.default 2668 2645 1.01:1
DividerMinimalPerf.default 314 311 1.01:1
ImageMinimalPerf.default 350 347 1.01:1
PopupMinimalPerf.default 632 627 1.01:1
PortalMinimalPerf.default 118 117 1.01:1
ProviderMergeThemesPerf.default 1785 1766 1.01:1
AnimationMinimalPerf.default 366 366 1:1
AvatarMinimalPerf.default 466 467 1:1
ButtonSlotsPerf.default 565 566 1:1
CarouselMinimalPerf.default 423 424 1:1
InputMinimalPerf.default 1055 1056 1:1
MenuButtonMinimalPerf.default 1455 1456 1:1
RadioGroupMinimalPerf.default 395 394 1:1
Checkbox.Fluent 623 626 1:1
Dropdown.Fluent 2891 2877 1:1
Icon.Fluent 664 665 1:1
Slider.Fluent 1530 1528 1:1
DialogMinimalPerf.default 712 717 0.99:1
GridMinimalPerf.default 299 302 0.99:1
Avatar.Fluent 830 839 0.99:1
Dialog.Fluent 723 729 0.99:1
EmbedMinimalPerf.default 1732 1771 0.98:1
HierarchicalTreeMinimalPerf.default 381 390 0.98:1
SegmentMinimalPerf.default 306 313 0.98:1
TableManyItemsPerf.default 2049 2101 0.98:1
TextAreaMinimalPerf.default 434 444 0.98:1
Button.Fluent 515 523 0.98:1
ChatMinimalPerf.default 544 562 0.97:1
ListNestedPerf.default 853 875 0.97:1
VideoMinimalPerf.default 590 606 0.97:1
Text.Fluent 305 313 0.97:1
Tooltip.Fluent 484 498 0.97:1
AttachmentSlotsPerf.default 1076 1124 0.96:1
HeaderSlotsPerf.default 752 785 0.96:1
StatusMinimalPerf.default 596 622 0.96:1
DropdownMinimalPerf.default 2697 2841 0.95:1
ListMinimalPerf.default 427 448 0.95:1
TextMinimalPerf.default 303 330 0.92:1
AttachmentMinimalPerf.default 135 149 0.91:1

lorejoh12
lorejoh12 approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@lorejoh12 lorejoh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the build error with the public api file being out of date gets fixed

@dzearing dzearing changed the title Shrallap/datepickercalloutopenpublic DatePicker: showDatePickerPopup should be public Jul 10, 2020
@lorejoh12 lorejoh12 merged commit ec36a5c into microsoft:master Jul 10, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/date-time@v7.11.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evlevy evlevy Awaiting requested review from evlevy

Assignees

@mnajdova mnajdova

Labels
Component: DatePicker Package: date-time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@msft-github-bot @dzearing @lorejoh12 @srhyderabad @mnajdova @shrallap