Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix spelling mistake #13996

Merged
merged 2 commits into from Jul 13, 2020
Merged

docs: fix spelling mistake #13996

merged 2 commits into from Jul 13, 2020

Conversation

YanxinTang
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

change 'exta' to 'extra'

Focus areas to test

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3142a02:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 12, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ae46225e1b94e6b348daa23fe90d983a285ce4ad (build)

Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Before this can merge you’ll need to clone the repo and run yarn followed by yarn change to create a change file.

@ghost
Copy link

ghost commented Jul 13, 2020

CLA assistant check
All CLA requirements met.

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 860 904 5000
ButtonNext mount 552 546 5000
Checkbox mount 1497 1565 5000
CheckboxBase mount 1256 1277 5000
CheckboxNext mount 1611 1553 5000
ChoiceGroup mount 4856 4798 5000
ComboBox mount 910 897 1000
CommandBar mount 7435 7505 1000
ContextualMenu mount 13386 13217 1000
DefaultButton mount 1066 1068 5000
DetailsRow mount 3479 3523 5000
DetailsRowFast mount 3466 3471 5000
DetailsRowNoStyles mount 3226 3253 5000
Dialog mount 1503 1525 1000
DocumentCardTitle mount 1819 1767 1000
Dropdown mount 2529 2507 5000
FocusZone mount 1786 1769 5000
IconButton mount 1664 1692 5000
Label mount 328 331 5000
Link mount 433 429 5000
LinkNext mount 446 443 5000
MenuButton mount 1390 1391 5000
Nav mount 3218 3192 1000
Panel mount 1407 1409 1000
Persona mount 859 820 1000
Pivot mount 1386 1348 1000
PivotNext mount 1326 1349 1000
PrimaryButton mount 1185 1204 5000
SearchBox mount 1233 1234 5000
SearchBoxNext mount 1247 1303 5000
Slider mount 1422 1466 5000
SliderNext mount 1914 1848 5000
Spinner mount 424 452 5000
SplitButton mount 3061 3096 5000
Stack mount 488 504 5000
StackWithIntrinsicChildren mount 1917 1992 5000
StackWithTextChildren mount 4839 4809 5000
TagPicker mount 2654 2651 5000
Text mount 423 422 5000
TextField mount 1322 1329 5000
ThemeProvider mount 2933 3047 5000
ThemeProvider virtual-rerender 501 514 5000
Toggle mount 835 804 5000
ToggleNext mount 866 815 5000
button mount 117 106 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.44 1:1 2000 878
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 507
🔧 Checkbox.Fluent 0.63 0.31 2.03:1 1000 631
🦄 Dialog.Fluent 0.15 0.22 0.68:1 5000 760
🔧 Dropdown.Fluent 2.87 0.44 6.52:1 1000 2865
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 699
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 346
🔧 Slider.Fluent 1.59 0.35 4.54:1 1000 1594
🔧 Text.Fluent 0.06 0.03 2:1 5000 321
🦄 Tooltip.Fluent 0.1 17.34 0.01:1 5000 507

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
Icon.Fluent 699 626 1.12:1
GridMinimalPerf.default 321 293 1.1:1
IconMinimalPerf.default 633 577 1.1:1
AnimationMinimalPerf.default 395 370 1.07:1
DividerMinimalPerf.default 362 337 1.07:1
FlexMinimalPerf.default 257 241 1.07:1
LayoutMinimalPerf.default 372 349 1.07:1
ButtonMinimalPerf.default 174 164 1.06:1
FormMinimalPerf.default 382 360 1.06:1
ItemLayoutMinimalPerf.default 1227 1172 1.05:1
ListNestedPerf.default 856 819 1.05:1
Dialog.Fluent 760 725 1.05:1
AttachmentMinimalPerf.default 143 138 1.04:1
DropdownManyItemsPerf.default 774 742 1.04:1
InputMinimalPerf.default 1099 1054 1.04:1
MenuButtonMinimalPerf.default 1463 1413 1.04:1
RefMinimalPerf.default 206 198 1.04:1
Checkbox.Fluent 631 608 1.04:1
AttachmentSlotsPerf.default 1151 1121 1.03:1
AvatarMinimalPerf.default 466 452 1.03:1
ProviderMergeThemesPerf.default 1913 1852 1.03:1
TextMinimalPerf.default 323 313 1.03:1
ButtonSlotsPerf.default 596 587 1.02:1
ChatDuplicateMessagesPerf.default 427 419 1.02:1
LabelMinimalPerf.default 354 348 1.02:1
StatusMinimalPerf.default 638 626 1.02:1
TooltipMinimalPerf.default 732 717 1.02:1
AlertMinimalPerf.default 293 289 1.01:1
DialogMinimalPerf.default 754 747 1.01:1
EmbedMinimalPerf.default 1829 1809 1.01:1
HeaderMinimalPerf.default 339 334 1.01:1
ListMinimalPerf.default 428 424 1.01:1
LoaderMinimalPerf.default 723 714 1.01:1
ProviderMinimalPerf.default 855 843 1.01:1
RadioGroupMinimalPerf.default 393 389 1.01:1
TableManyItemsPerf.default 2074 2058 1.01:1
Avatar.Fluent 878 871 1.01:1
Slider.Fluent 1594 1584 1.01:1
ChatWithPopoverPerf.default 466 466 1:1
PopupMinimalPerf.default 646 643 1:1
ToolbarMinimalPerf.default 933 934 1:1
Dropdown.Fluent 2865 2877 1:1
CheckboxMinimalPerf.default 2873 2905 0.99:1
DropdownMinimalPerf.default 2979 2998 0.99:1
ListCommonPerf.default 903 908 0.99:1
ListWith60ListItems.default 1060 1067 0.99:1
ReactionMinimalPerf.default 341 345 0.99:1
TableMinimalPerf.default 366 370 0.99:1
CustomToolbarPrototype.default 3631 3653 0.99:1
Text.Fluent 321 325 0.99:1
Tooltip.Fluent 507 510 0.99:1
HierarchicalTreeMinimalPerf.default 383 392 0.98:1
ImageMinimalPerf.default 338 344 0.98:1
MenuMinimalPerf.default 800 819 0.98:1
SegmentMinimalPerf.default 302 309 0.98:1
SplitButtonMinimalPerf.default 3513 3576 0.98:1
TreeWith60ListItems.default 198 202 0.98:1
Button.Fluent 507 515 0.98:1
BoxMinimalPerf.default 332 343 0.97:1
CardMinimalPerf.default 520 538 0.97:1
CarouselMinimalPerf.default 439 453 0.97:1
TreeMinimalPerf.default 822 846 0.97:1
TextAreaMinimalPerf.default 450 471 0.96:1
Image.Fluent 346 361 0.96:1
SliderMinimalPerf.default 1493 1594 0.94:1
VideoMinimalPerf.default 565 600 0.94:1
ChatMinimalPerf.default 573 613 0.93:1
HeaderSlotsPerf.default 758 813 0.93:1
PortalMinimalPerf.default 116 128 0.91:1
AccordionMinimalPerf.default 124 140 0.89:1

@ecraig12345 ecraig12345 merged commit c3c2aa1 into microsoft:master Jul 13, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/fabric-website@v7.13.0 has been released which incorporates this pull request.:tada:

Handy links:

@YanxinTang YanxinTang deleted the patch-1 branch July 14, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants