Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grouped vertical bar chart method calling in did mount. #14137

Merged
merged 3 commits into from Jul 23, 2020
Merged

Grouped vertical bar chart method calling in did mount. #14137

merged 3 commits into from Jul 23, 2020

Conversation

jameelakowsar
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Calling grouped vertical bar chart method in did mount and updated height proprty as if negtiva values apper, then need to sent 0 to eliminate unwanted console warnings.

Focus areas to test

Grouped vertical bar chart.

Before fix

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd702df:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 21, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1e1838959a48481860b0d3acfefd71546b7036ec (build)

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 878 883 5000
ButtonNext mount 569 581 5000
Checkbox mount 1568 1540 5000
CheckboxBase mount 1278 1283 5000
CheckboxNext mount 1566 1581 5000
ChoiceGroup mount 4909 4877 5000
ComboBox mount 903 908 1000
CommandBar mount 7710 7761 1000
ContextualMenu mount 14682 14816 1000
DefaultButton mount 1081 1085 5000
DetailsRow mount 3545 3635 5000
DetailsRowFast mount 3535 3629 5000
DetailsRowNoStyles mount 3310 3364 5000
Dialog mount 1496 1468 1000
DocumentCardTitle mount 1828 1806 1000
Dropdown mount 2495 2549 5000
FocusZone mount 1834 1841 5000
IconButton mount 1739 1743 5000
Label mount 341 340 5000
Link mount 438 453 5000
LinkNext mount 477 480 5000
MenuButton mount 1460 1457 5000
Nav mount 3190 3252 1000
Panel mount 1430 1427 1000
Persona mount 869 840 1000
Pivot mount 1397 1411 1000
PivotNext mount 1364 1406 1000
PrimaryButton mount 1243 1251 5000
SearchBox mount 1260 1261 5000
SearchBoxNext mount 1326 1303 5000
Slider mount 1500 1499 5000
SliderNext mount 1907 1916 5000
SpinButton mount 4897 4919 5000
SpinButtonNext mount 5124 5007 5000
Spinner mount 436 416 5000
SplitButton mount 3126 3118 5000
Stack mount 533 504 5000
StackWithIntrinsicChildren mount 2017 1959 5000
StackWithTextChildren mount 5003 5019 5000
TagPicker mount 2732 2647 5000
Text mount 433 414 5000
TextField mount 1391 1351 5000
ThemeProvider mount 2995 3034 5000
ThemeProvider virtual-rerender 521 526 5000
Toggle mount 820 846 5000
ToggleNext mount 846 834 5000
button mount 109 117 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.43 0.46 0.93:1 2000 869
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 539
🔧 Checkbox.Fluent 0.64 0.33 1.94:1 1000 636
🎯 Dialog.Fluent 0.15 0.21 0.71:1 5000 732
🔧 Dropdown.Fluent 2.98 0.47 6.34:1 1000 2976
🔧 Icon.Fluent 0.13 0.05 2.6:1 5000 652
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 364
🔧 Slider.Fluent 1.66 0.37 4.49:1 1000 1657
🔧 Text.Fluent 0.06 0.03 2:1 5000 313
🦄 Tooltip.Fluent 0.1 19.7 0.01:1 5000 507

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 155 141 1.1:1
CarouselMinimalPerf.default 471 434 1.09:1
GridMinimalPerf.default 341 320 1.07:1
DropdownManyItemsPerf.default 748 709 1.06:1
ImageMinimalPerf.default 355 334 1.06:1
ReactionMinimalPerf.default 379 358 1.06:1
Image.Fluent 364 343 1.06:1
RefMinimalPerf.default 213 203 1.05:1
TableMinimalPerf.default 408 390 1.05:1
ButtonSlotsPerf.default 588 567 1.04:1
ListMinimalPerf.default 476 459 1.04:1
StatusMinimalPerf.default 678 650 1.04:1
TextMinimalPerf.default 333 321 1.04:1
TextAreaMinimalPerf.default 462 444 1.04:1
Button.Fluent 539 516 1.04:1
PortalMinimalPerf.default 121 118 1.03:1
ChatMinimalPerf.default 611 599 1.02:1
ChatWithPopoverPerf.default 479 470 1.02:1
DividerMinimalPerf.default 346 338 1.02:1
FormMinimalPerf.default 393 387 1.02:1
LabelMinimalPerf.default 393 384 1.02:1
LoaderMinimalPerf.default 733 722 1.02:1
MenuMinimalPerf.default 827 811 1.02:1
MenuButtonMinimalPerf.default 1525 1498 1.02:1
RadioGroupMinimalPerf.default 406 399 1.02:1
SegmentMinimalPerf.default 331 325 1.02:1
VideoMinimalPerf.default 606 596 1.02:1
Tooltip.Fluent 507 497 1.02:1
AvatarMinimalPerf.default 473 467 1.01:1
ButtonMinimalPerf.default 167 166 1.01:1
CheckboxMinimalPerf.default 2820 2794 1.01:1
ListWith60ListItems.default 1093 1079 1.01:1
PopupMinimalPerf.default 664 656 1.01:1
ToolbarMinimalPerf.default 927 921 1.01:1
Checkbox.Fluent 636 630 1.01:1
Dropdown.Fluent 2976 2949 1.01:1
AlertMinimalPerf.default 289 289 1:1
AnimationMinimalPerf.default 382 381 1:1
AttachmentMinimalPerf.default 152 152 1:1
AttachmentSlotsPerf.default 1113 1110 1:1
BoxMinimalPerf.default 329 330 1:1
DialogMinimalPerf.default 751 754 1:1
EmbedMinimalPerf.default 1870 1867 1:1
HeaderMinimalPerf.default 343 343 1:1
HierarchicalTreeMinimalPerf.default 404 406 1:1
ItemLayoutMinimalPerf.default 1214 1215 1:1
ListNestedPerf.default 877 874 1:1
ProviderMergeThemesPerf.default 1957 1956 1:1
IconMinimalPerf.default 621 621 1:1
TableManyItemsPerf.default 2207 2210 1:1
CustomToolbarPrototype.default 3824 3813 1:1
TreeMinimalPerf.default 856 858 1:1
Slider.Fluent 1657 1651 1:1
CardMinimalPerf.default 535 541 0.99:1
ChatDuplicateMessagesPerf.default 420 423 0.99:1
DropdownMinimalPerf.default 2910 2954 0.99:1
InputMinimalPerf.default 1316 1323 0.99:1
LayoutMinimalPerf.default 377 380 0.99:1
ListCommonPerf.default 934 941 0.99:1
ProviderMinimalPerf.default 920 928 0.99:1
SplitButtonMinimalPerf.default 3701 3727 0.99:1
Avatar.Fluent 869 877 0.99:1
SliderMinimalPerf.default 1586 1638 0.97:1
TooltipMinimalPerf.default 754 776 0.97:1
Dialog.Fluent 732 754 0.97:1
TreeWith60ListItems.default 211 220 0.96:1
HeaderSlotsPerf.default 751 789 0.95:1
Icon.Fluent 652 696 0.94:1
Text.Fluent 313 343 0.91:1
FlexMinimalPerf.default 279 309 0.9:1

@Raghurk Raghurk merged commit 68f77ba into microsoft:master Jul 23, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v2.7.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@xugao xugao

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jameelakowsar @msft-github-bot @Raghurk @xugao