-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FocusTrapZone: Adding aria-hidden to bumper elements so that they are not read by screen readers #14376
FocusTrapZone: Adding aria-hidden to bumper elements so that they are not read by screen readers #14376
Conversation
… not read by screen readers.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 821256f:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B Baseline commit: aea3a8be1e98123cf840bc245274b84621635f4c (build) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khmakoto
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
… not read by screen readers (microsoft#14376) #### Pull request checklist - [x] Addresses an existing issue: Fixes microsoft#14241 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR adds `aria-hidden='true'` to bumper elements in the `FocusTrapZone` component so they are not read by screen readers, as they are just there for functionality purposes and could confuse the users if read. #### Focus areas to test (optional)
Pull request checklist
$ yarn change
Description of changes
This PR adds
aria-hidden='true'
to bumper elements in theFocusTrapZone
component so they are not read by screen readers, as they are just there for functionality purposes and could confuse the users if read.Focus areas to test
(optional)