Fix input and label IDs not respected by choice group option. #14387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 92e9a09:
|
Asset size changes
Baseline commit: 7db0feacd08336094a1fec9f857621342f5303c7 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
ecraig12345
reviewed
Aug 7, 2020
There was a problem hiding this comment.
Thanks for this fix! A couple minor syntax suggestions but otherwise looks good.
@czearing Can you please include this change in your ChoiceGroup function component conversion PR too?
packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx
Outdated
Show resolved
Hide resolved
…iceGroup.base.tsx Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
…iceGroup.base.tsx Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
|
@ecraig12345 Done! |
ecraig12345
approved these changes
Aug 7, 2020
|
Not sure why the build was failing, but there's no way it was due to your change. I started a new build. |
|
Hello @ecraig12345! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
tmaster628
pushed a commit
to tmaster628/fluentui
that referenced
this pull request
Aug 12, 2020
…oft#14387) #### Pull request checklist - [x] Addresses an existing issue: Fixes microsoft#14386 - [x] Include a change request file using `$ yarn change` #### Description of changes Passed the correct input and label id's to ChoiceGroupOption. #### Focus areas to test Please refer to the issue linked above for more details.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Passed the correct input and label id's to ChoiceGroupOption.
Focus areas to test
Please refer to the issue linked above for more details.