Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ChatMessage): add read status indicator slot #14585

Merged
merged 11 commits into from
Aug 20, 2020
Merged

feat(ChatMessage): add read status indicator slot #14585

merged 11 commits into from
Aug 20, 2020

Conversation

assuncaocharles
Copy link
Contributor

@assuncaocharles assuncaocharles commented Aug 18, 2020 •
edited

Pull request checklist

Description of changes

This PR adds readStatusIndicator slot for ChatMessage:

Screenshot 2020-08-18 at 15 29 08

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Aug 18, 2020
@assuncaocharles assuncaocharles changed the title fix(ChatMessage): add read status indicator slot feat(ChatMessage): add read status indicator slot Aug 18, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented Aug 18, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 906 938 5000
ButtonNext mount 579 584 5000
Checkbox mount 1584 1588 5000
CheckboxBase mount 1294 1288 5000
CheckboxNext mount 1670 1660 5000
ChoiceGroup mount 5063 5035 5000
ChoiceGroupNext mount 5044 5045 5000
ComboBox mount 948 943 1000
CommandBar mount 7754 7729 1000
ContextualMenu mount 14074 14083 1000
DefaultButton mount 1127 1126 5000
DetailsRow mount 3584 3597 5000
DetailsRowFast mount 3540 3626 5000
DetailsRowNoStyles mount 3448 3339 5000
Dialog mount 1513 1552 1000
DocumentCardTitle mount 1856 1858 1000
Dropdown mount 2657 2605 5000
FocusZone mount 1830 1796 5000
IconButton mount 1766 1763 5000
Label mount 347 371 5000
Link mount 457 463 5000
LinkNext mount 509 490 5000
MenuButton mount 1443 1441 5000
Nav mount 3268 3285 1000
OverflowSet mount 1418 1382 5000
OverflowSetNext mount 1034 1059 5000
Panel mount 1526 1478 1000
Persona mount 841 864 1000
Pivot mount 1419 1599 1000
PivotNext mount 1382 1388 1000
PrimaryButton mount 1306 1310 5000
SearchBox mount 1341 1332 5000
SearchBoxNext mount 1303 1358 5000
Slider mount 1539 1517 5000
SliderNext mount 1959 1939 5000
SpinButton mount 5017 4972 5000
SpinButtonNext mount 5081 5120 5000
Spinner mount 446 430 5000
SplitButton mount 3212 3238 5000
Stack mount 531 562 5000
StackWithIntrinsicChildren mount 2002 1964 5000
StackWithTextChildren mount 5122 5022 5000
TagPicker mount 2814 2752 5000
Text mount 426 428 5000
TextField mount 1393 1418 5000
ThemeProvider mount 3785 3950 5000
ThemeProvider virtual-rerender 460 483 5000
Toggle mount 844 838 5000
ToggleNext mount 855 824 5000
button mount 124 120 5000

Perf Analysis (Fluent)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 131 45 2.91:1 analysis
ButtonUseCssPerf.default 62 45 1.38:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.5 0.9:1 2000 895
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 548
🔧 Checkbox.Fluent 0.67 0.37 1.81:1 1000 673
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 802
🔧 Dropdown.Fluent 3 0.48 6.25:1 1000 2995
🔧 Icon.Fluent 0.15 0.05 3:1 5000 747
🦄 Image.Fluent 0.07 0.12 0.58:1 5000 371
🔧 Slider.Fluent 1.65 0.36 4.58:1 1000 1648
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 336
🦄 Tooltip.Fluent 0.11 18.23 0.01:1 5000 528

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonUseCssNestingPerf.default 54 41 1.32:1
AttachmentMinimalPerf.default 168 147 1.14:1
AlertMinimalPerf.default 314 286 1.1:1
ReactionMinimalPerf.default 401 365 1.1:1
SkeletonMinimalPerf.default 414 378 1.1:1
ButtonMinimalPerf.default 177 163 1.09:1
DividerMinimalPerf.default 379 347 1.09:1
DropdownManyItemsPerf.default 830 761 1.09:1
CardMinimalPerf.default 581 540 1.08:1
PortalMinimalPerf.default 135 125 1.08:1
FlexMinimalPerf.default 294 276 1.07:1
RadioGroupMinimalPerf.default 425 399 1.07:1
IconMinimalPerf.default 677 634 1.07:1
Icon.Fluent 747 699 1.07:1
AnimationMinimalPerf.default 402 379 1.06:1
BoxMinimalPerf.default 352 333 1.06:1
ProviderMinimalPerf.default 988 929 1.06:1
RefMinimalPerf.default 221 208 1.06:1
TextMinimalPerf.default 345 327 1.06:1
ChatDuplicateMessagesPerf.default 444 423 1.05:1
ItemLayoutMinimalPerf.default 1293 1237 1.05:1
LayoutMinimalPerf.default 406 388 1.05:1
ProviderMergeThemesPerf.default 2062 1970 1.05:1
SegmentMinimalPerf.default 349 332 1.05:1
TooltipMinimalPerf.default 821 780 1.05:1
Checkbox.Fluent 673 639 1.05:1
ChatWithPopoverPerf.default 489 468 1.04:1
LoaderMinimalPerf.default 775 745 1.04:1
PopupMinimalPerf.default 693 669 1.04:1
VideoMinimalPerf.default 637 611 1.04:1
Button.Fluent 548 527 1.04:1
Dialog.Fluent 802 773 1.04:1
AvatarMinimalPerf.default 488 472 1.03:1
CarouselMinimalPerf.default 459 445 1.03:1
DialogMinimalPerf.default 789 765 1.03:1
EmbedMinimalPerf.default 1954 1900 1.03:1
ListMinimalPerf.default 496 480 1.03:1
SliderMinimalPerf.default 1640 1595 1.03:1
Image.Fluent 371 360 1.03:1
MenuButtonMinimalPerf.default 1573 1538 1.02:1
StatusMinimalPerf.default 666 655 1.02:1
TextAreaMinimalPerf.default 456 448 1.02:1
CustomToolbarPrototype.default 3894 3816 1.02:1
ChatMinimalPerf.default 610 601 1.01:1
HeaderMinimalPerf.default 355 350 1.01:1
InputMinimalPerf.default 1327 1310 1.01:1
LabelMinimalPerf.default 401 397 1.01:1
MenuMinimalPerf.default 847 841 1.01:1
SplitButtonMinimalPerf.default 3814 3780 1.01:1
TableMinimalPerf.default 408 402 1.01:1
Avatar.Fluent 895 886 1.01:1
Tooltip.Fluent 528 524 1.01:1
CheckboxMinimalPerf.default 2876 2884 1:1
DropdownMinimalPerf.default 3015 3019 1:1
GridMinimalPerf.default 338 338 1:1
TableManyItemsPerf.default 2221 2213 1:1
ToolbarMinimalPerf.default 955 953 1:1
TreeMinimalPerf.default 879 875 1:1
Dropdown.Fluent 2995 2995 1:1
Slider.Fluent 1648 1656 1:1
AttachmentSlotsPerf.default 1153 1169 0.99:1
FormMinimalPerf.default 401 406 0.99:1
ButtonSlotsPerf.default 603 617 0.98:1
ImageMinimalPerf.default 366 373 0.98:1
HeaderSlotsPerf.default 755 775 0.97:1
TreeWith60ListItems.default 208 214 0.97:1
Text.Fluent 336 348 0.97:1
AccordionMinimalPerf.default 144 151 0.95:1
ListWith60ListItems.default 968 1118 0.87:1
ListCommonPerf.default 664 934 0.71:1
ListNestedPerf.default 585 901 0.65:1

@size-auditor
Copy link

size-auditor bot commented Aug 18, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a95407790172cb25bad455e6d4cffb2bf12bc629 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 18, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 81457fe:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@layershifter
Copy link
Member

Just wondering, should it be just readIndicator or statusIndicator?

@assuncaocharles
Copy link
Contributor Author

assuncaocharles commented Aug 19, 2020 •
edited

Just wondering, should it be just readIndicator or statusIndicator?

I am ok renaming it to readIndicator or statusIndicator

edit: @layershifter renamed

@assuncaocharles
Copy link
Contributor Author

So @layershifter @mnajdova @pompomon

Can we go ahead and merge it?

mnajdova
mnajdova approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See last comments before merging please

@assuncaocharles assuncaocharles merged commit 28a2fcc into microsoft:master Aug 20, 2020
@assuncaocharles assuncaocharles deleted the feat/chat-message-read-status branch August 20, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompomon pompomon pompomon approved these changes

@mnajdova mnajdova mnajdova approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

Assignees

@khmakoto khmakoto

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@assuncaocharles @msft-github-bot @layershifter @pompomon @mnajdova @khmakoto