Make FocusTrapZone useful for focusing the first item in a virtual list #14606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasMichon
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
khmakoto,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 78d0f87:
|
Asset size changes
Baseline commit: 9bcc6172721b53c64d04556b2312b26e8c6e0278 (build) |
brwatt
approved these changes
Aug 19, 2020
ThomasMichon
force-pushed
the
details-list-focus
branch
from
e6887c5
to
c4b4815
Compare
Perf AnalysisNo significant results to display. All results
|
ThomasMichon
force-pushed
the
details-list-focus
branch
from
c4b4815
to
cd32a7e
Compare
ThomasMichon
force-pushed
the
details-list-focus
branch
from
cd32a7e
to
bb4914f
Compare
dzearing
reviewed
Sep 17, 2020
packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx
Outdated
Show resolved
Hide resolved
dzearing
reviewed
Sep 17, 2020
dzearing
reviewed
Sep 17, 2020
change/office-ui-fabric-react-2020-08-18-19-00-44-details-list-focus.json
Outdated
Show resolved
Hide resolved
dzearing
reviewed
Sep 17, 2020
packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.types.ts
Outdated
Show resolved
Hide resolved
ThomasMichon
force-pushed
the
details-list-focus
branch
from
bb4914f
to
e325fc2
Compare
ThomasMichon
requested review from
assuncaocharles and
chrisdholt
as code owners
khmakoto
previously requested changes
Sep 28, 2020
There was a problem hiding this comment.
Thanks for submitting this fix, but due to work we're currently doing to prepare master for our version 8 beta release, we're asking contributors to either wait a couple weeks to submit fixes (if it's not urgent) or submit to the new 7.0 branch (if it's urgent). See #15222 for more details.
ThomasMichon
force-pushed
the
details-list-focus
branch
from
e325fc2
to
9afcfdd
Compare
40 tasks
ThomasMichon
force-pushed
the
details-list-focus
branch
from
9afcfdd
to
7a7c232
Compare
ThomasMichon
force-pushed
the
details-list-focus
branch
from
7a7c232
to
b74ac1a
Compare
dzearing
reviewed
Oct 6, 2020
packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx
Show resolved
Hide resolved
ThomasMichon
force-pushed
the
details-list-focus
branch
2 times, most recently
from
9d1b183
to
eb7e7ec
Compare
khmakoto
approved these changes
Oct 12, 2020
|
Now that we're publishing beta versions of 8.0 please also port this to the master branch once it merges. |
ThomasMichon
force-pushed
the
details-list-focus
branch
from
eb7e7ec
to
6b98020
Compare
|
Hello @ThomasMichon! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Looks like some API updates are missing |
|
🎉 Handy links: |
|
🎉 Handy links: |
khmakoto
added a commit
to khmakoto/fluentui
that referenced
this pull request
Oct 29, 2021
2 tasks
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
…st (microsoft#20413) * Porting microsoft#14606 to v8. * Change files * Removing focus.ts changes. * Delete @fluentui-utilities-a66b0f6c-334f-4416-b397-75393f9d22a7.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Made some minor updates to
FocusTrapZoneso it can be leveraged to implement a common accessibility requirement: "Select the first row in the List". Unlike previous attempts at solving this issue, such as usinginitialFocusedIndexonDetailsList, this approach allows a host app to specify when and how it wants to focus an element, simply by providing the correct selector forfirstFocusableElementon aFocusTrapZoneand calling.focus()on its component ref after the content loads. The ideal selector to use is[data-selection-index="0"], which is the first content row according to theSelectionZone. This works well with bothDetailsListandTilesListwithout requiring either component to implement something custom.Focus areas to test
Example pages for
TilesListandDetailsListhave been updated to include the behavior and showcase its non-invasive impact.