Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ChatMessage): add prop to proptypes #14652

Closed
wants to merge 1 commit into from
Closed

fix(ChatMessage): add prop to proptypes #14652

wants to merge 1 commit into from

Conversation

assuncaocharles
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Hot fix for handled prop

Focus areas to test

(optional)

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Aug 20, 2020
@assuncaocharles assuncaocharles changed the title feat(ChatMessage): add proptype fix(ChatMessage): add prop to proptypes Aug 20, 2020
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 852 833 5000
ButtonNext mount 561 567 5000
Checkbox mount 1490 1501 5000
CheckboxBase mount 1198 1271 5000
CheckboxNext mount 1614 1580 5000
ChoiceGroup mount 4745 4741 5000
ChoiceGroupNext mount 4770 4768 5000
ComboBox mount 863 911 1000
CommandBar mount 7275 7319 1000
ContextualMenu mount 13405 13704 1000
DefaultButton mount 1056 1026 5000
DetailsRow mount 3384 3449 5000
DetailsRowFast mount 3381 3431 5000
DetailsRowNoStyles mount 3240 3227 5000
Dialog mount 1466 1488 1000
DocumentCardTitle mount 1719 1727 1000
Dropdown mount 2537 2505 5000
FocusZone mount 1735 1789 5000
IconButton mount 1648 1638 5000
Label mount 321 324 5000
Link mount 427 429 5000
LinkNext mount 448 465 5000
MenuButton mount 1417 1407 5000
Nav mount 3082 3048 1000
OverflowSet mount 1342 1316 5000
OverflowSetNext mount 998 998 5000
Panel mount 1417 1381 1000
Persona mount 821 816 1000
Pivot mount 1497 1372 1000
PivotNext mount 1340 1363 1000
PrimaryButton mount 1253 1215 5000
SearchBox mount 1255 1226 5000
SearchBoxNext mount 1287 1288 5000
Slider mount 1456 1440 5000
SliderNext mount 1901 1894 5000
SpinButton mount 4878 4816 5000
SpinButtonNext mount 5269 4902 5000
Spinner mount 405 410 5000
SplitButton mount 3171 3105 5000
Stack mount 478 509 5000
StackWithIntrinsicChildren mount 1879 1877 5000
StackWithTextChildren mount 4789 4778 5000
TagPicker mount 2719 2798 5000
Text mount 393 411 5000
TextField mount 1313 1315 5000
ThemeProvider mount 3683 3679 5000
ThemeProvider virtual-rerender 434 432 5000
Toggle mount 781 800 5000
ToggleNext mount 787 776 5000
button mount 107 113 5000

Perf Analysis (Fluent)

⚠️ 3 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 117 40 2.93:1 analysis
ButtonUseCssPerf.default 52 44 1.18:1 analysis
ListNestedPerf.default 573 839 0.68:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.42 0.43 0.98:1 2000 832
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 511
🔧 Checkbox.Fluent 0.62 0.34 1.82:1 1000 618
🎯 Dialog.Fluent 0.15 0.21 0.71:1 5000 745
🔧 Dropdown.Fluent 2.88 0.46 6.26:1 1000 2879
🔧 Icon.Fluent 0.13 0.05 2.6:1 5000 659
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 357
🔧 Slider.Fluent 1.55 0.35 4.43:1 1000 1551
🔧 Text.Fluent 0.06 0.03 2:1 5000 320
🦄 Tooltip.Fluent 0.1 17.17 0.01:1 5000 507

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonUseCssNestingPerf.default 52 41 1.27:1
Image.Fluent 357 313 1.14:1
ButtonMinimalPerf.default 173 153 1.13:1
PortalMinimalPerf.default 121 109 1.11:1
AccordionMinimalPerf.default 157 143 1.1:1
AttachmentMinimalPerf.default 156 142 1.1:1
ChatDuplicateMessagesPerf.default 436 397 1.1:1
CarouselMinimalPerf.default 450 414 1.09:1
RefMinimalPerf.default 213 196 1.09:1
AnimationMinimalPerf.default 381 354 1.08:1
FlexMinimalPerf.default 285 267 1.07:1
GridMinimalPerf.default 326 304 1.07:1
HeaderMinimalPerf.default 336 313 1.07:1
ProviderMergeThemesPerf.default 1938 1831 1.06:1
Button.Fluent 511 483 1.06:1
Icon.Fluent 659 622 1.06:1
Tooltip.Fluent 507 480 1.06:1
ChatMinimalPerf.default 576 551 1.05:1
LabelMinimalPerf.default 378 361 1.05:1
LayoutMinimalPerf.default 375 358 1.05:1
StatusMinimalPerf.default 643 611 1.05:1
DividerMinimalPerf.default 334 320 1.04:1
LoaderMinimalPerf.default 718 693 1.04:1
MenuMinimalPerf.default 808 779 1.04:1
PopupMinimalPerf.default 657 634 1.04:1
ProviderMinimalPerf.default 959 921 1.04:1
RadioGroupMinimalPerf.default 391 377 1.04:1
TableManyItemsPerf.default 2097 2021 1.04:1
CustomToolbarPrototype.default 3780 3629 1.04:1
Dialog.Fluent 745 716 1.04:1
Text.Fluent 320 309 1.04:1
AvatarMinimalPerf.default 444 429 1.03:1
ChatWithPopoverPerf.default 476 460 1.03:1
EmbedMinimalPerf.default 1878 1819 1.03:1
SegmentMinimalPerf.default 324 316 1.03:1
SliderMinimalPerf.default 1546 1508 1.03:1
IconMinimalPerf.default 651 633 1.03:1
TableMinimalPerf.default 372 360 1.03:1
ToolbarMinimalPerf.default 887 864 1.03:1
TreeMinimalPerf.default 836 811 1.03:1
VideoMinimalPerf.default 578 560 1.03:1
Avatar.Fluent 832 808 1.03:1
Checkbox.Fluent 618 602 1.03:1
Dropdown.Fluent 2879 2803 1.03:1
FormMinimalPerf.default 384 375 1.02:1
ImageMinimalPerf.default 333 326 1.02:1
ItemLayoutMinimalPerf.default 1196 1170 1.02:1
ListMinimalPerf.default 452 441 1.02:1
MenuButtonMinimalPerf.default 1461 1431 1.02:1
ReactionMinimalPerf.default 372 364 1.02:1
SkeletonMinimalPerf.default 376 367 1.02:1
TooltipMinimalPerf.default 756 740 1.02:1
BoxMinimalPerf.default 316 313 1.01:1
DialogMinimalPerf.default 725 718 1.01:1
InputMinimalPerf.default 1287 1268 1.01:1
TextMinimalPerf.default 315 313 1.01:1
AttachmentSlotsPerf.default 1086 1082 1:1
TreeWith60ListItems.default 203 204 1:1
CheckboxMinimalPerf.default 2680 2706 0.99:1
DropdownManyItemsPerf.default 720 724 0.99:1
HeaderSlotsPerf.default 723 734 0.99:1
SplitButtonMinimalPerf.default 3595 3621 0.99:1
TextAreaMinimalPerf.default 419 425 0.99:1
ButtonSlotsPerf.default 557 570 0.98:1
CardMinimalPerf.default 506 516 0.98:1
DropdownMinimalPerf.default 2839 2921 0.97:1
AlertMinimalPerf.default 275 285 0.96:1
Slider.Fluent 1551 1614 0.96:1
ListWith60ListItems.default 918 1038 0.88:1
ListCommonPerf.default 644 909 0.71:1

@size-auditor
Copy link

size-auditor bot commented Aug 21, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 133cb47d985143631d1c62807f2295a8c04beccf (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 686705f:

Sandbox Source
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@khmakoto khmakoto

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@assuncaocharles @msft-github-bot @khmakoto