Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Breadcrumb): add spec #14780

Merged
merged 8 commits into from
Nov 23, 2020
Merged

feat(Breadcrumb): add spec #14780

merged 8 commits into from
Nov 23, 2020

Conversation

assuncaocharles
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

This PR adds a proposal for Breadcrumb implementation

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 27, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 26ba129:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Aug 27, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 828 842 5000
BaseButtonCompat mount 935 942 5000
Breadcrumb mount 40301 40296 5000
Checkbox mount 1538 1505 5000
CheckboxBase mount 1299 1261 5000
ChoiceGroup mount 4860 4894 5000
ComboBox mount 1030 976 1000
CommandBar mount 9794 9810 1000
ContextualMenu mount 5900 5937 1000
DefaultButtonCompat mount 1143 1143 5000
DetailsRow mount 3677 3669 5000
DetailsRowFast mount 3720 3730 5000
DetailsRowNoStyles mount 3527 3510 5000
Dialog mount 1472 1458 1000
DocumentCardTitle mount 1699 1741 1000
Dropdown mount 3350 3339 5000
FocusTrapZone mount 1797 1788 5000
FocusZone mount 1759 1819 5000
IconButtonCompat mount 1790 1826 5000
Label mount 343 332 5000
Layer mount 1807 1768 5000
Link mount 477 468 5000
MenuButtonCompat mount 1529 1529 5000
MessageBar mount 1971 1963 5000
Nav mount 3269 3307 1000
OverflowSet mount 1040 1046 5000
Panel mount 1396 1445 1000
Persona mount 850 851 1000
Pivot mount 1376 1417 1000
PrimaryButtonCompat mount 1305 1295 5000
Rating mount 7753 7735 5000
SearchBox mount 1374 1395 5000
Shimmer mount 2633 2639 5000
Slider mount 1905 1900 5000
SpinButton mount 4957 5071 5000
Spinner mount 406 402 5000
SplitButtonCompat mount 3160 3184 5000
Stack mount 512 523 5000
StackWithIntrinsicChildren mount 1625 1615 5000
StackWithTextChildren mount 4813 4817 5000
SwatchColorPicker mount 10411 10387 5000
Tabs mount 1388 1422 1000
TagPicker mount 2975 2834 5000
TeachingBubble mount 11405 11450 5000
Text mount 436 428 5000
TextField mount 1390 1385 5000
ThemeProvider mount 2080 2084 5000
ThemeProvider virtual-rerender 632 626 5000
Toggle mount 821 817 5000
button mount 649 691 5000
buttonNative mount 109 101 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.5 0.94:1 2000 945
🦄 Button.Fluent 0.13 0.25 0.52:1 5000 635
🔧 Checkbox.Fluent 0.63 0.36 1.75:1 1000 633
🎯 Dialog.Fluent 0.17 0.21 0.81:1 5000 828
🔧 Dropdown.Fluent 2.9 0.41 7.07:1 1000 2896
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 773
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 422
🔧 Slider.Fluent 1.59 0.44 3.61:1 1000 1585
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 387
🦄 Tooltip.Fluent 0.11 0.86 0.13:1 5000 562

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 232 200 1.16:1
FormMinimalPerf.default 484 445 1.09:1
RefMinimalPerf.default 245 224 1.09:1
AvatarMinimalPerf.default 520 480 1.08:1
LayoutMinimalPerf.default 450 418 1.08:1
GridMinimalPerf.default 382 362 1.06:1
PortalMinimalPerf.default 169 159 1.06:1
TooltipMinimalPerf.default 862 813 1.06:1
AttachmentMinimalPerf.default 178 170 1.05:1
CardMinimalPerf.default 616 586 1.05:1
ChatMinimalPerf.default 691 655 1.05:1
ListMinimalPerf.default 530 507 1.05:1
SegmentMinimalPerf.default 407 388 1.05:1
Button.Fluent 635 602 1.05:1
ChatWithPopoverPerf.default 498 481 1.04:1
MenuButtonMinimalPerf.default 1633 1576 1.04:1
Icon.Fluent 773 744 1.04:1
AnimationMinimalPerf.default 431 417 1.03:1
ButtonUseCssPerf.default 880 853 1.03:1
CarouselMinimalPerf.default 487 471 1.03:1
FlexMinimalPerf.default 327 319 1.03:1
InputMinimalPerf.default 1365 1324 1.03:1
TableMinimalPerf.default 450 435 1.03:1
ButtonMinimalPerf.default 199 196 1.02:1
ChatDuplicateMessagesPerf.default 441 431 1.02:1
DividerMinimalPerf.default 408 400 1.02:1
EmbedMinimalPerf.default 4245 4181 1.02:1
PopupMinimalPerf.default 717 705 1.02:1
TableManyItemsPerf.default 2346 2309 1.02:1
Avatar.Fluent 945 925 1.02:1
Dialog.Fluent 828 811 1.02:1
AttachmentSlotsPerf.default 1161 1155 1.01:1
ButtonSlotsPerf.default 611 607 1.01:1
DropdownManyItemsPerf.default 783 778 1.01:1
DropdownMinimalPerf.default 2894 2876 1.01:1
HeaderMinimalPerf.default 410 405 1.01:1
HeaderSlotsPerf.default 852 842 1.01:1
ItemLayoutMinimalPerf.default 1351 1342 1.01:1
ListNestedPerf.default 606 602 1.01:1
LoaderMinimalPerf.default 748 743 1.01:1
ProviderMinimalPerf.default 1020 1007 1.01:1
SliderMinimalPerf.default 1599 1590 1.01:1
SplitButtonMinimalPerf.default 3929 3871 1.01:1
CustomToolbarPrototype.default 3851 3796 1.01:1
ToolbarMinimalPerf.default 995 985 1.01:1
Text.Fluent 387 385 1.01:1
Tooltip.Fluent 562 559 1.01:1
ButtonOverridesMissPerf.default 1743 1739 1:1
ButtonUseCssNestingPerf.default 1103 1102 1:1
DatepickerMinimalPerf.default 47105 47013 1:1
DialogMinimalPerf.default 810 806 1:1
ListCommonPerf.default 692 690 1:1
MenuMinimalPerf.default 894 898 1:1
RadioGroupMinimalPerf.default 486 485 1:1
ReactionMinimalPerf.default 452 454 1:1
CheckboxMinimalPerf.default 2850 2878 0.99:1
ListWith60ListItems.default 938 945 0.99:1
ProviderMergeThemesPerf.default 1964 1986 0.99:1
SkeletonMinimalPerf.default 466 472 0.99:1
TextMinimalPerf.default 397 403 0.99:1
Checkbox.Fluent 633 642 0.99:1
Dropdown.Fluent 2896 2911 0.99:1
Image.Fluent 422 425 0.99:1
AccordionMinimalPerf.default 166 170 0.98:1
AlertMinimalPerf.default 327 334 0.98:1
BoxMinimalPerf.default 387 394 0.98:1
LabelMinimalPerf.default 451 458 0.98:1
TextAreaMinimalPerf.default 537 548 0.98:1
TreeMinimalPerf.default 924 939 0.98:1
Slider.Fluent 1585 1625 0.98:1
ImageMinimalPerf.default 407 419 0.97:1
StatusMinimalPerf.default 768 792 0.97:1
IconMinimalPerf.default 680 729 0.93:1
VideoMinimalPerf.default 650 702 0.93:1

@size-auditor
Copy link

size-auditor bot commented Aug 27, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9905793196352ae3309f961a5a533051cc4bb779 (build)

@msft-github-bot
Copy link
Contributor

Hello @assuncaocharles!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@layershifter layershifter merged commit 27ce3ec into microsoft:master Nov 23, 2020
@assuncaocharles assuncaocharles deleted the feat/breadcrumb-proposal branch November 23, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

@pompomon pompomon Awaiting requested review from pompomon

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

Assignees
No one assigned
Labels
AutoMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@assuncaocharles @msft-github-bot @ling1726 @layershifter