fix: centered the indeterminate indicator inside the checkbox component #14836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ed851559770bc8aa7348ac4e93e63f17fa27c9bc (build) |
khamudom
force-pushed
the
users/khamu/indeterminate-indicator
branch
from
f92d105
to
2ca6da7
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 80939d5:
|
chrisdholt
requested changes
Sep 1, 2020
Comment on lines
+71
to
+75
| top: 50%; | ||
| left: 50%; | ||
| width: 50%; | ||
| height: 50%; | ||
| transform: translate(-50%, -50%); |
There was a problem hiding this comment.
Can you run yarn change to generate a change report so this can be published correctly? That will help the build pass as well :).
chrisdholt
approved these changes
Sep 18, 2020
khamudom
force-pushed
the
users/khamu/indeterminate-indicator
branch
from
7282684
to
80939d5
Compare
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Update to center the indicator by setting top and left to 50% and shifting it up and left by half of its own width and height, because the indicator is off by a pixel.
Focus areas to test
(optional)