Add ie11 to browser list for screener tests #14890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is exactly what my PR was... which will fail on some things. We need a way to opt in specific tests |
|
https://screener.io/v2/docs/include-exclude @dzearing Found something that could be useful, just wanted to make sure that ie11 was able to be added to the screener tests. Will update the PR with includeRules |
|
@tomi-msft sounds good! |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 3346b09e82b41f6b5b96fe1a94c8d122b3a4625b (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1a07cb2:
|
xugao
reviewed
Oct 13, 2020
| @@ -14,6 +14,9 @@ storiesOf('Button Next', module) | |||
| .addDecorator(story => ( | |||
| <Screener | |||
| steps={new Steps() | |||
| .executeScript( | |||
| 'const script=document.createElement(\'script\');script.src="https://cdn.jsdelivr.net/gh/nuxodin/ie11CustomProperties@4.1.0/ie11CustomProperties.min.js";document.head.appendChild(script);location.reload();', | |||
There was a problem hiding this comment.
location.reload();
You are reloading the page; the new page will not have the script after reloading
There was a problem hiding this comment.
why do you need to reload? the script will execute before we render the button. that way the button should have the styles
There was a problem hiding this comment.
actually, steps are executed after stories are rendered. so this will not work :) we need a way to inject and execute the script before the stories render
There was a problem hiding this comment.
https://storybook.js.org/docs/react/configure/story-rendering#adding-to-head this might be what we want
|
@tomi-msft is it valid? As I remember we decided to not use a polyfill for IE11... Can you please check? |
|
This is resolved, ill close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)