Set font-family inherit on button and input elements #15172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xugao
requested review from
evlevy,
khmakoto,
lorejoh12 and
pompomon
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4443aa9:
|
Asset size changes
Baseline commit: 261dea7a150115ce904768724cbeac80ded20382 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
lorejoh12
approved these changes
Sep 23, 2020
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Currently,
Fabriccomponent appliesfont-family: inheritforbutton,inputandtextareahere.This causes a specificity issue because they will win over component-level styles. see example here.
This change adds
font-family: inheritto component styles so they are styled correctly without the styles fromFabric.This change does not remove styles from
Fabric, since it can be a breaking change for users. However, in the long term, we will not have these styles by default inThemeProvider(a replacement ofFabric).Focus areas to test
(optional)