Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing storybook build task that was preventing PR deploy sites from being bundled correctly #15226

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Fixing storybook build task that was preventing PR deploy sites from being bundled correctly #15226

merged 4 commits into from
Sep 25, 2020

Conversation

khmakoto
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

This PR fixes the storybook build task that was preventing PR deploy sites from being bundled correctly

Focus areas to test

(optional)

ecraig12345
ecraig12345 reviewed Sep 24, 2020
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out! A few suggestions.

scripts/just.config.ts Outdated Show resolved Hide resolved
scripts/just.config.ts Outdated Show resolved Hide resolved
scripts/storybook/webpack.config.js Outdated Show resolved Hide resolved
scripts/tasks/storybookTask.js Outdated Show resolved Hide resolved
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 24, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b2203b:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 24, 2020 •
edited

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 242e7b2

Possible causes

  • The baseline build 242e7b2 is broken
  • The Size Auditor run for the baseline build 242e7b2 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Sep 24, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 864 845 5000
BaseButton mount 912 911 5000
Breadcrumb mount 41789 41589 5000
BreadcrumbNext mount 160190 160400 5000
ButtonNext mount 581 582 5000
Checkbox mount 1531 1542 5000
CheckboxBase mount 1263 1290 5000
CheckboxNext mount 1502 1483 5000
ChoiceGroup mount 4892 4976 5000
ChoiceGroupNext mount 9473 9537 5000
ComboBox mount 938 921 1000
CommandBar mount 7719 7627 1000
ContextualMenu mount 13340 13192 1000
DefaultButton mount 1145 1133 5000
DetailsRow mount 3529 3576 5000
DetailsRowFast mount 3528 3528 5000
DetailsRowNoStyles mount 3384 3334 5000
Dialog mount 1469 1456 1000
DocumentCardTitle mount 1828 1810 1000
Dropdown mount 2546 2524 5000
FocusZone mount 1818 1826 5000
IconButton mount 1756 1752 5000
Label mount 346 348 5000
Layer mount 1936 1960 5000
LayerNext mount 1875 1837 5000
Link mount 443 462 5000
LinkNext mount 456 468 5000
MenuButton mount 1494 1454 5000
MessageBar mount 2067 2118 5000
MessageBarNext mount 2067 2069 5000
Nav mount 3250 3269 1000
OverflowSet mount 1402 1376 5000
OverflowSetNext mount 1057 1032 5000
Panel mount 1494 1435 1000
Persona mount 841 831 1000
Pivot mount 1436 1467 1000
PivotNext mount 1385 1390 1000
PrimaryButton mount 1283 1281 5000
Rating mount 7480 7563 5000
RatingNext mount 7426 7467 5000
SearchBox mount 1272 1312 5000
SearchBoxNext mount 1278 1315 5000
Shimmer mount 2553 2617 5000
ShimmerNext mount 2568 2489 5000
Slider mount 1463 1520 5000
SliderNext mount 1895 1911 5000
SpinButton mount 4942 4916 5000
SpinButtonNext mount 5138 5089 5000
Spinner mount 430 436 5000
SplitButton mount 3170 3116 5000
Stack mount 502 534 5000
StackWithIntrinsicChildren mount 1915 1917 5000
StackWithTextChildren mount 4962 5006 5000
SwatchColorPicker mount 10310 10321 5000
SwatchColorPickerNext mount 10189 10189 5000
TagPicker mount 2728 2751 5000
TeachingBubble mount 50637 50663 5000
TeachingBubbleNext mount 11510 11470 5000
Text mount 437 429 5000
TextField mount 1363 1381 5000
ThemeProvider mount 3206 3220 5000
ThemeProvider virtual-rerender 595 611 5000
Toggle mount 840 826 5000
ToggleNext mount 804 804 5000
button mount 117 120 5000

Perf Analysis (Fluent)

⚠️ 5 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1699 43 39.51:1 analysis
ButtonUseCssNestingPerf.default 1076 45 23.91:1 analysis
ButtonUseCssPerf.default 830 44 18.86:1 analysis
ChatWithPopoverPerf.default 478 455 1.05:1 analysis
ListCommonPerf.default 663 946 0.7:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.49 0.92:1 2000 892
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 580
🔧 Checkbox.Fluent 0.64 0.35 1.83:1 1000 640
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 821
🔧 Dropdown.Fluent 2.95 0.46 6.41:1 1000 2945
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 740
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 407
🔧 Slider.Fluent 1.62 0.36 4.5:1 1000 1616
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 377
🦄 Tooltip.Fluent 0.11 16.44 0.01:1 5000 566

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 179 117 1.53:1
RefMinimalPerf.default 238 196 1.21:1
Text.Fluent 377 313 1.2:1
Image.Fluent 407 341 1.19:1
HeaderMinimalPerf.default 383 326 1.17:1
TextAreaMinimalPerf.default 516 441 1.17:1
FlexMinimalPerf.default 305 262 1.16:1
GridMinimalPerf.default 366 316 1.16:1
SkeletonMinimalPerf.default 444 384 1.16:1
DividerMinimalPerf.default 382 331 1.15:1
FormMinimalPerf.default 431 374 1.15:1
ReactionMinimalPerf.default 415 362 1.15:1
StatusMinimalPerf.default 742 647 1.15:1
TextMinimalPerf.default 373 323 1.15:1
AnimationMinimalPerf.default 432 379 1.14:1
BoxMinimalPerf.default 381 334 1.14:1
ButtonMinimalPerf.default 177 155 1.14:1
ImageMinimalPerf.default 403 354 1.14:1
RadioGroupMinimalPerf.default 444 390 1.14:1
SegmentMinimalPerf.default 370 328 1.13:1
ChatMinimalPerf.default 647 580 1.12:1
LabelMinimalPerf.default 446 397 1.12:1
LayoutMinimalPerf.default 421 375 1.12:1
AccordionMinimalPerf.default 163 147 1.11:1
AttachmentMinimalPerf.default 160 144 1.11:1
PopupMinimalPerf.default 727 653 1.11:1
TableMinimalPerf.default 430 387 1.11:1
CardMinimalPerf.default 585 531 1.1:1
ProviderMinimalPerf.default 976 885 1.1:1
Button.Fluent 580 527 1.1:1
TooltipMinimalPerf.default 830 761 1.09:1
Dialog.Fluent 821 751 1.09:1
ListMinimalPerf.default 493 458 1.08:1
TreeMinimalPerf.default 892 825 1.08:1
Avatar.Fluent 892 829 1.08:1
Icon.Fluent 740 686 1.08:1
Tooltip.Fluent 566 523 1.08:1
AvatarMinimalPerf.default 492 459 1.07:1
DialogMinimalPerf.default 802 748 1.07:1
MenuMinimalPerf.default 880 826 1.07:1
MenuButtonMinimalPerf.default 1583 1481 1.07:1
ToolbarMinimalPerf.default 960 895 1.07:1
AlertMinimalPerf.default 307 290 1.06:1
ChatDuplicateMessagesPerf.default 429 406 1.06:1
ProviderMergeThemesPerf.default 2016 1900 1.06:1
HeaderSlotsPerf.default 793 757 1.05:1
AttachmentSlotsPerf.default 1173 1125 1.04:1
CarouselMinimalPerf.default 462 444 1.04:1
EmbedMinimalPerf.default 1919 1851 1.04:1
CustomToolbarPrototype.default 3868 3703 1.04:1
CheckboxMinimalPerf.default 2902 2805 1.03:1
ItemLayoutMinimalPerf.default 1282 1247 1.03:1
LoaderMinimalPerf.default 748 727 1.03:1
SplitButtonMinimalPerf.default 3765 3661 1.03:1
Checkbox.Fluent 640 624 1.03:1
ButtonSlotsPerf.default 598 588 1.02:1
IconMinimalPerf.default 656 640 1.02:1
TableManyItemsPerf.default 2185 2143 1.02:1
VideoMinimalPerf.default 606 595 1.02:1
Slider.Fluent 1616 1589 1.02:1
DropdownManyItemsPerf.default 742 735 1.01:1
DropdownMinimalPerf.default 2968 2937 1.01:1
InputMinimalPerf.default 1300 1294 1:1
SliderMinimalPerf.default 1583 1579 1:1
Dropdown.Fluent 2945 2938 1:1
TreeWith60ListItems.default 207 209 0.99:1
ListWith60ListItems.default 941 1075 0.88:1
ListNestedPerf.default 595 871 0.68:1

dzearing
dzearing reviewed Sep 25, 2020
View reviewed changes
Copy link
Member

@dzearing dzearing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally, A++++++ would recommend

ecraig12345
ecraig12345 approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dzearing dzearing merged commit e224fe7 into microsoft:master Sep 25, 2020
@khmakoto khmakoto deleted the prDeploySites branch September 25, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@dzearing dzearing dzearing approved these changes

@layershifter layershifter Awaiting requested review from layershifter

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

Assignees

@miroslavstastny miroslavstastny

Labels
Area: Build System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@khmakoto @msft-github-bot @dzearing @ecraig12345 @miroslavstastny