Renaming @fluentui/examples to @fluentui/react-examples #15254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khmakoto
requested review from
dzearing,
Jahnp,
layershifter and
miroslavstastny
as code owners
ecraig12345
approved these changes
Sep 25, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 37bd2eb:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cedca7c:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 369c7a1f7f9a4b6a8379eece7b4812e5e0675ebb (build) |
|
Really weird storybook issue here... https://screener.io/v2/states/Skgr32fUL.microsoft-fluentui/reactExamples/1024x768/Chrome/activityitem-root-default-0 Trying a new build since I don't think it's related to this change.
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR renames the
@fluentui/examplespackage to@fluentui/react-examplesto be more inline with the rest of the repo. It also updates all imports and references to it as well as thelint-filesandlint-stagedrules that checked for the examples, docs and snapshots to be moved toreact-examples.Focus areas to test
(optional)