Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TextField react-next changes back to main package #15370

Merged
merged 7 commits into from
Oct 7, 2020
Merged

Move TextField react-next changes back to main package #15370

merged 7 commits into from
Oct 7, 2020

Conversation

ecraig12345
Copy link
Member

@ecraig12345 ecraig12345 commented Oct 5, 2020 •
edited

Pull request checklist

Description of changes

Move TextField "next" changes back to the main package: MaskedTextField function component conversion and some small prop changes (mostly from #14829).

Delete Breadcrumb from react-next since it wasn't converted yet.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 5, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1bc8d4b:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@ecraig12345
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 6, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 822 854 5000
BaseButton mount 935 911 5000
Breadcrumb mount 42241 42407 5000
ButtonNext mount 564 589 5000
Checkbox mount 1548 1532 5000
CheckboxBase mount 1284 1256 5000
CheckboxNext mount 1514 1535 5000
ChoiceGroup mount 4886 4935 5000
ChoiceGroupNext mount 9593 9628 5000
ComboBox mount 943 926 1000
CommandBar mount 7773 7845 1000
ContextualMenu mount 14524 14415 1000
DefaultButton mount 1151 1179 5000
DetailsRow mount 3689 3692 5000
DetailsRowFast mount 3702 3712 5000
DetailsRowNoStyles mount 3487 3509 5000
Dialog mount 1507 1525 1000
DocumentCardTitle mount 1827 1908 1000
Dropdown mount 2624 2639 5000
FocusTrapZone mount 1768 1747 5000
FocusTrapZoneNext mount 1822 1830 5000
FocusZone mount 1860 1791 5000
IconButton mount 1788 1753 5000
Label mount 358 350 5000
Layer mount 1914 1915 5000
LayerNext mount 1951 1917 5000
Link mount 480 477 5000
LinkNext mount 466 463 5000
MenuButton mount 1487 1480 5000
MessageBar mount 2104 2105 5000
MessageBarNext mount 2061 2075 5000
Nav mount 3258 3265 1000
OverflowSet mount 1410 1457 5000
OverflowSetNext mount 1051 1049 5000
Panel mount 1472 1454 1000
Persona mount 860 843 1000
Pivot mount 1434 1435 1000
PivotNext mount 1431 1401 1000
PrimaryButton mount 1291 1291 5000
Rating mount 7592 7620 5000
RatingNext mount 7549 7344 5000
SearchBox mount 1273 1254 5000
SearchBoxNext mount 1316 1329 5000
Shimmer mount 2553 2599 5000
ShimmerNext mount 2535 2535 5000
Slider mount 1925 1893 5000
SliderNext mount 1910 1899 5000
SpinButton mount 5041 5039 5000
SpinButtonNext mount 5127 5080 5000
Spinner mount 430 447 5000
SplitButton mount 3205 3199 5000
Stack mount 508 515 5000
StackWithIntrinsicChildren mount 1899 1881 5000
StackWithTextChildren mount 4915 4904 5000
SwatchColorPicker mount 10433 10421 5000
SwatchColorPickerNext mount 10283 10337 5000
TagPicker mount 2692 2657 5000
TeachingBubble mount 51074 51118 5000
TeachingBubbleNext mount 11601 11693 5000
Text mount 426 408 5000
TextField mount 1351 1379 5000
ThemeProvider mount 1629 1635 5000
ThemeProvider virtual-rerender 654 627 5000
Toggle mount 821 803 5000
ToggleNext mount 800 800 5000
button mount 123 117 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.45 0.49 0.92:1 2000 898
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 579
🔧 Checkbox.Fluent 0.67 0.34 1.97:1 1000 669
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 810
🔧 Dropdown.Fluent 2.96 0.47 6.3:1 1000 2956
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 725
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 378
🔧 Slider.Fluent 1.63 0.43 3.79:1 1000 1628
🔧 Text.Fluent 0.08 0.04 2:1 5000 380
🦄 Tooltip.Fluent 0.11 17.86 0.01:1 5000 573

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatDuplicateMessagesPerf.default 456 430 1.06:1
FlexMinimalPerf.default 327 310 1.05:1
PortalMinimalPerf.default 178 170 1.05:1
TableMinimalPerf.default 453 434 1.04:1
TooltipMinimalPerf.default 850 818 1.04:1
Slider.Fluent 1628 1561 1.04:1
Text.Fluent 380 367 1.04:1
AvatarMinimalPerf.default 492 478 1.03:1
ButtonMinimalPerf.default 190 185 1.03:1
LabelMinimalPerf.default 449 435 1.03:1
PopupMinimalPerf.default 731 711 1.03:1
Checkbox.Fluent 669 651 1.03:1
EmbedMinimalPerf.default 1966 1924 1.02:1
HeaderMinimalPerf.default 393 385 1.02:1
ImageMinimalPerf.default 412 403 1.02:1
LayoutMinimalPerf.default 428 420 1.02:1
ListMinimalPerf.default 523 512 1.02:1
MenuButtonMinimalPerf.default 1611 1580 1.02:1
RadioGroupMinimalPerf.default 455 447 1.02:1
TextMinimalPerf.default 373 367 1.02:1
AnimationMinimalPerf.default 427 424 1.01:1
AttachmentMinimalPerf.default 169 167 1.01:1
ButtonOverridesMissPerf.default 1720 1704 1.01:1
ButtonUseCssPerf.default 830 824 1.01:1
DropdownMinimalPerf.default 2947 2927 1.01:1
FormMinimalPerf.default 447 441 1.01:1
GridMinimalPerf.default 362 358 1.01:1
InputMinimalPerf.default 1337 1323 1.01:1
LoaderMinimalPerf.default 759 749 1.01:1
ProviderMergeThemesPerf.default 2123 2107 1.01:1
ReactionMinimalPerf.default 429 425 1.01:1
SegmentMinimalPerf.default 384 382 1.01:1
CustomToolbarPrototype.default 3959 3929 1.01:1
TreeMinimalPerf.default 900 890 1.01:1
AttachmentSlotsPerf.default 1143 1148 1:1
ButtonSlotsPerf.default 614 616 1:1
CarouselMinimalPerf.default 470 472 1:1
CheckboxMinimalPerf.default 2910 2901 1:1
DialogMinimalPerf.default 809 812 1:1
DividerMinimalPerf.default 384 384 1:1
HeaderSlotsPerf.default 812 810 1:1
ItemLayoutMinimalPerf.default 1300 1304 1:1
ListWith60ListItems.default 940 944 1:1
MenuMinimalPerf.default 889 892 1:1
RefMinimalPerf.default 248 248 1:1
SplitButtonMinimalPerf.default 3799 3812 1:1
StatusMinimalPerf.default 749 750 1:1
IconMinimalPerf.default 709 710 1:1
TableManyItemsPerf.default 2194 2190 1:1
ToolbarMinimalPerf.default 969 966 1:1
Avatar.Fluent 898 894 1:1
Button.Fluent 579 578 1:1
Icon.Fluent 725 727 1:1
ButtonUseCssNestingPerf.default 1112 1124 0.99:1
ProviderMinimalPerf.default 1023 1032 0.99:1
SkeletonMinimalPerf.default 430 433 0.99:1
SliderMinimalPerf.default 1605 1620 0.99:1
TextAreaMinimalPerf.default 505 508 0.99:1
VideoMinimalPerf.default 619 627 0.99:1
Dialog.Fluent 810 817 0.99:1
Dropdown.Fluent 2956 2999 0.99:1
Tooltip.Fluent 573 579 0.99:1
BoxMinimalPerf.default 382 391 0.98:1
ChatMinimalPerf.default 625 638 0.98:1
ListNestedPerf.default 574 584 0.98:1
TreeWith60ListItems.default 206 213 0.97:1
AccordionMinimalPerf.default 165 171 0.96:1
AlertMinimalPerf.default 302 313 0.96:1
ChatWithPopoverPerf.default 469 491 0.96:1
DropdownManyItemsPerf.default 746 776 0.96:1
CardMinimalPerf.default 575 604 0.95:1
ListCommonPerf.default 645 681 0.95:1
Image.Fluent 378 396 0.95:1

@size-auditor
Copy link

size-auditor bot commented Oct 6, 2020 •
edited

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-ColorPicker 84.223 kB 84.249 kB ExceedsBaseline     26 bytes
office-ui-fabric-react fluentui-react-DatePicker 201.971 kB 201.997 kB ExceedsBaseline     26 bytes
office-ui-fabric-react fluentui-react-TextField 73.887 kB 73.366 kB BelowBaseline     -521 bytes
office-ui-fabric-react fluentui-react-next-TextField 73.41 kB  Deleted       BelowBaseline     -73.41 kB
office-ui-fabric-react fluentui-react-next-Breadcrumb 190.576 kB  Deleted       BelowBaseline     -190.576 kB

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 0ba5359b12c1e186f9577ad1a90fb9a628e7b9ed (build)

@ecraig12345
Copy link
Member Author

/az

@ecraig12345 ecraig12345 closed this Oct 7, 2020
@ecraig12345 ecraig12345 reopened this Oct 7, 2020
@ecraig12345 ecraig12345 merged commit 02a94bd into microsoft:master Oct 7, 2020
@ecraig12345 ecraig12345 deleted the move-textfield branch October 7, 2020 04:24
@ecraig12345 ecraig12345 mentioned this pull request Oct 15, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmakoto khmakoto khmakoto approved these changes

@JasonGore JasonGore Awaiting requested review from JasonGore

@xugao xugao Awaiting requested review from xugao

@czearing czearing Awaiting requested review from czearing

Assignees

@tomi-msft tomi-msft

Labels
Component: Breadcrumb Component: TextField
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ecraig12345 @msft-github-bot @khmakoto @tomi-msft