Moving OverflowSet to @fluentui/react-internal package #15389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czearing
requested review from
JasonGore,
micahgodbolt and
xugao
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a1e715c:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: 1e626b101db22df0f12bf04f42be6e94c1c5fdcb (build) |
|
Looks like this will require some updates in the charting package to use new props. |
…eat/react-internal-overflowset # Conflicts: # packages/react-next/etc/react-next.api.md
…eat/react-internal-overflowset
ecraig12345
reviewed
Oct 8, 2020
| @@ -827,10 +824,11 @@ exports[`Component Examples renders CommandBar.Basic.Example.tsx correctly 1`] = | |||
| </div> | |||
| <div | |||
| className= | |||
| ms-OverflowSet-overflowButton | |||
| ms-CommandBar-primaryCommand | |||
There was a problem hiding this comment.
Do you know why this class name change happened?
There was a problem hiding this comment.
Thanks for catching this! getNativeProps was placed incorrectly in the wrapper div and was not applying the className properly.
There was a problem hiding this comment.
Nice to see the snapshot tests being useful! :)
There was a problem hiding this comment.
Hmm original question still stands though--why did the class name change (even after the update to native props location)?
There was a problem hiding this comment.
I updated the pr and it should be good now. The snapshot change was due to ButtonGrid applying {...props} after the classNames and then applying and overwriting them.
The remaining snapshot changes for VerticalBarChart,AreaChart, OverflowSet, and ReizeGroup are due to the FocusZone removal from OverflowSet and id updates:
…eat/react-internal-overflowset
…ct-internal snapshots
ecraig12345
reviewed
Oct 8, 2020
| @@ -197,11 +197,6 @@ export class AreaChartMultipleExample extends React.Component<{}, IAreaChartBasi | |||
| legendsOverflowText={'Overflow Items'} | |||
| yAxisTickFormat={d3.format('$,')} | |||
| legendProps={{ | |||
There was a problem hiding this comment.
Just to confirm, did you check out these examples to verify that they still work as before (even without the FocusZone)? You can compare with the PR deploy site of charting in master. http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/heads/master/
There was a problem hiding this comment.
I don't see any behavior changes in the Charting components after the FocusZone removal.
…eat/react-internal-overflowset
ecraig12345
approved these changes
Oct 10, 2020
| @@ -1,4 +1,4 @@ | |||
| @import '../../common/common'; | |||
| @import '~@fluentui/common-styles/dist/sass/common'; | |||
There was a problem hiding this comment.
I think we can delete this file--I don't see any references to it
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
OverflowSetfrom react-next to react-internal (including function component conversion from Updating OverflowSet to a function component inside React-Next #13077).OverflowSetin react-internal.OverflowSetNext.OverflowSet.