Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move v8 coachmark changes from react-next to react #15400

Merged
merged 4 commits into from
Oct 7, 2020
Merged

Move v8 coachmark changes from react-next to react #15400

merged 4 commits into from
Oct 7, 2020

Conversation

ecraig12345
Copy link
Member

Pull request checklist

Description of changes

Moving Coachmark function component conversion from #13626 and other v8 changes back to the main package.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 7, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6d19f38:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 7, 2020 •
edited

Perf Analysis

Scenario Render type Master Ticks PR Ticks Iterations Status
StackWithTextChildren mount 5004 4946 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 840 821 5000
BaseButton mount 933 930 5000
Breadcrumb mount 42721 42498 5000
ButtonNext mount 533 539 5000
Checkbox mount 1528 1520 5000
CheckboxBase mount 1275 1263 5000
CheckboxNext mount 1527 1509 5000
ChoiceGroup mount 4732 4669 5000
ComboBox mount 929 955 1000
CommandBar mount 7844 7781 1000
ContextualMenu mount 14350 14244 1000
DefaultButton mount 1156 1141 5000
DetailsRow mount 3638 3718 5000
DetailsRowFast mount 3660 3695 5000
DetailsRowNoStyles mount 3510 3508 5000
Dialog mount 1464 1519 1000
DocumentCardTitle mount 1837 1834 1000
Dropdown mount 2644 2664 5000
FocusTrapZone mount 1764 1774 5000
FocusTrapZoneNext mount 1839 1811 5000
FocusZone mount 1837 1838 5000
IconButton mount 1810 1797 5000
Label mount 355 346 5000
Layer mount 1912 1897 5000
LayerNext mount 1881 1936 5000
Link mount 489 485 5000
LinkNext mount 494 475 5000
MenuButton mount 1438 1485 5000
MessageBar mount 2115 2057 5000
Nav mount 3295 3301 1000
OverflowSet mount 1430 1404 5000
OverflowSetNext mount 1079 1032 5000
Panel mount 1463 1471 1000
Persona mount 862 903 1000
Pivot mount 1412 1427 1000
PivotNext mount 1406 1434 1000
PrimaryButton mount 1332 1316 5000
Rating mount 7546 7650 5000
RatingNext mount 7553 7531 5000
SearchBox mount 1290 1266 5000
SearchBoxNext mount 1303 1277 5000
Shimmer mount 2607 2574 5000
ShimmerNext mount 2561 2574 5000
Slider mount 1912 1928 5000
SliderNext mount 1932 1951 5000
SpinButton mount 5091 5024 5000
SpinButtonNext mount 5163 5125 5000
Spinner mount 431 432 5000
SplitButton mount 3251 3279 5000
Stack mount 521 511 5000
StackWithIntrinsicChildren mount 1897 2007 5000
StackWithTextChildren mount 5004 4946 5000 Possible regression
SwatchColorPicker mount 10300 10401 5000
TagPicker mount 2785 2750 5000
TeachingBubble mount 50997 51461 5000
TeachingBubbleNext mount 11848 11679 5000
Text mount 428 450 5000
TextField mount 1353 1387 5000
ThemeProvider mount 1946 1942 5000
ThemeProvider virtual-rerender 621 638 5000
Toggle mount 803 804 5000
ToggleNext mount 823 828 5000
button mount 114 130 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.53 0.83:1 2000 881
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 581
🔧 Checkbox.Fluent 0.67 0.35 1.91:1 1000 669
🎯 Dialog.Fluent 0.16 0.23 0.7:1 5000 794
🔧 Dropdown.Fluent 2.97 0.48 6.19:1 1000 2971
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 725
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 396
🔧 Slider.Fluent 1.61 0.47 3.43:1 1000 1611
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 408
🦄 Tooltip.Fluent 0.12 18.56 0.01:1 5000 596

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AnimationMinimalPerf.default 463 408 1.13:1
SegmentMinimalPerf.default 409 366 1.12:1
Text.Fluent 408 366 1.11:1
FlexMinimalPerf.default 354 321 1.1:1
AttachmentMinimalPerf.default 174 159 1.09:1
RefMinimalPerf.default 264 243 1.09:1
TreeWith60ListItems.default 216 200 1.08:1
ButtonSlotsPerf.default 637 595 1.07:1
AttachmentSlotsPerf.default 1179 1117 1.06:1
ChatWithPopoverPerf.default 516 488 1.06:1
DropdownManyItemsPerf.default 811 766 1.06:1
BoxMinimalPerf.default 390 373 1.05:1
LabelMinimalPerf.default 450 427 1.05:1
PortalMinimalPerf.default 174 165 1.05:1
CardMinimalPerf.default 606 585 1.04:1
HeaderSlotsPerf.default 815 786 1.04:1
MenuMinimalPerf.default 905 874 1.04:1
ReactionMinimalPerf.default 429 411 1.04:1
Tooltip.Fluent 596 571 1.04:1
CarouselMinimalPerf.default 468 456 1.03:1
ItemLayoutMinimalPerf.default 1362 1325 1.03:1
IconMinimalPerf.default 714 692 1.03:1
ButtonOverridesMissPerf.default 1798 1763 1.02:1
ButtonUseCssPerf.default 839 826 1.02:1
DialogMinimalPerf.default 831 811 1.02:1
EmbedMinimalPerf.default 1974 1936 1.02:1
ImageMinimalPerf.default 412 403 1.02:1
ListNestedPerf.default 619 607 1.02:1
SkeletonMinimalPerf.default 438 429 1.02:1
SplitButtonMinimalPerf.default 3914 3828 1.02:1
TextAreaMinimalPerf.default 509 497 1.02:1
TooltipMinimalPerf.default 866 848 1.02:1
Checkbox.Fluent 669 659 1.02:1
AccordionMinimalPerf.default 167 165 1.01:1
GridMinimalPerf.default 374 372 1.01:1
LayoutMinimalPerf.default 432 428 1.01:1
SliderMinimalPerf.default 1693 1674 1.01:1
StatusMinimalPerf.default 748 737 1.01:1
TableMinimalPerf.default 433 428 1.01:1
Button.Fluent 581 578 1.01:1
CheckboxMinimalPerf.default 2916 2911 1:1
HeaderMinimalPerf.default 402 403 1:1
PopupMinimalPerf.default 722 723 1:1
ProviderMergeThemesPerf.default 2138 2134 1:1
CustomToolbarPrototype.default 4039 4047 1:1
TreeMinimalPerf.default 966 967 1:1
VideoMinimalPerf.default 655 657 1:1
Icon.Fluent 725 725 1:1
ListCommonPerf.default 675 685 0.99:1
MenuButtonMinimalPerf.default 1629 1640 0.99:1
ProviderMinimalPerf.default 1076 1086 0.99:1
TextMinimalPerf.default 381 384 0.99:1
ToolbarMinimalPerf.default 965 976 0.99:1
ButtonUseCssNestingPerf.default 1112 1134 0.98:1
DropdownMinimalPerf.default 2979 3032 0.98:1
LoaderMinimalPerf.default 750 765 0.98:1
RadioGroupMinimalPerf.default 449 457 0.98:1
Dialog.Fluent 794 811 0.98:1
Dropdown.Fluent 2971 3025 0.98:1
AlertMinimalPerf.default 313 322 0.97:1
AvatarMinimalPerf.default 492 505 0.97:1
ButtonMinimalPerf.default 180 186 0.97:1
ChatDuplicateMessagesPerf.default 439 454 0.97:1
ChatMinimalPerf.default 653 670 0.97:1
FormMinimalPerf.default 449 462 0.97:1
InputMinimalPerf.default 1333 1375 0.97:1
Slider.Fluent 1611 1659 0.97:1
DividerMinimalPerf.default 394 410 0.96:1
ListMinimalPerf.default 497 516 0.96:1
ListWith60ListItems.default 934 971 0.96:1
Image.Fluent 396 413 0.96:1
TableManyItemsPerf.default 2143 2248 0.95:1
Avatar.Fluent 881 927 0.95:1

@size-auditor
Copy link

size-auditor bot commented Oct 7, 2020 •
edited

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-PositioningContainer 70.601 kB 68.546 kB BelowBaseline     -2.055 kB
office-ui-fabric-react fluentui-react-Coachmark 92.023 kB 88.759 kB BelowBaseline     -3.264 kB
office-ui-fabric-react fluentui-react-next-Coachmark 84.892 kB  Deleted       BelowBaseline     -84.892 kB

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 66ba3997a888bc97e0ec33fc752f3be553d5ccf0 (build)

@ecraig12345 ecraig12345 merged commit 44f5d80 into microsoft:master Oct 7, 2020
@ecraig12345 ecraig12345 deleted the move-coachmark branch October 7, 2020 21:00
@ecraig12345 ecraig12345 mentioned this pull request Oct 15, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschect joschect joschect approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Component: Coachmark PR: API Modified PR: Possible Perf Regression 🐌
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ecraig12345 @msft-github-bot @joschect @tomi-msft