Partial theme merging fixes (for ThemeProvider) and update createTheme to use Theme/PartialTheme (7.0) #15452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
Area: Theming
Component: Theme
needs cherry-pick
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 503044a:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
dzearing
reviewed
Oct 9, 2020
Asset size changes
Baseline commit: 40edbe0aa78c0d1a56a3609318431fb4ceb4abe5 (build) |
dzearing
approved these changes
Oct 9, 2020
xugao
added a commit
to xugao/office-ui-fabric-react
that referenced
this pull request
Oct 9, 2020
…e to use Theme/PartialTheme (7.0) (microsoft#15452) * Update theme package * update theme-provider * tweak vr test to improve test coverage * Change files * fixes * more fixes, remove deprecated semantic slots * fix perf * fixes and cleanups * resolve comments * unmake breaking change * Change files * fix snapshots
2 tasks
xugao
added a commit
that referenced
this pull request
Oct 9, 2020
…e to use Theme/PartialTheme (7.0) (#15452) (#15326) * Update theme package * update theme-provider * tweak vr test to improve test coverage * Change files * fixes * more fixes, remove deprecated semantic slots * fix perf * fixes and cleanups * resolve comments * unmake breaking change * Change files * fix snapshots
xugao
removed
the
needs cherry-pick
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Theme/PartialThemeinstead ofITheme/IPartialThemetokensinThemeasinternaland updated its typing to be partial. This is because whencreatedThemereturns the fullTheme. We don't necessarily have to create fullTokensin that case, we can just passtokensthrough.getTokens. This is causing nestedThemeProvidernot working forreact-button(modified screener tests to cover this case).FunctionComponent<ThemeProviderProps>toThemeProvider. This is to have cleaner public API, instead of relying ofReact.forwardReftyping.mergeThemesimplementation to merge partial/full theme on top of a full theme. And use that in bothcreateThemeanduseThemeProviderState. (Note: this is a breaking change. however, I think it's safe to make since this is recently moved fromreact-theme-providertothemeand I don't think anyone but our code is using this)Focus areas to test
(optional)