Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charting: Grouped vertical bar chart code refactor. #15468

Merged
merged 10 commits into from Oct 31, 2020

Conversation

jameelakowsar
Copy link
Contributor

@jameelakowsar jameelakowsar commented Oct 12, 2020

Pull request checklist

Description of changes

In the process of restructure of the Groped vertical bar chart,

  • Removed d3 related graph structure and updated with rectangles.

  • Implemented with Cartesian chart(Common component)

  • YMinValue and YMaxValue support added

  • Added support of yAxisTickFormat.

  • Customized callout support implemented.

  • Code cleanup

  • Snapshot and basic level unit test cases added

  • Deprecated below props(Made them as default props).

    - showYAxisGridLines
    - showXAxisPath
    - showYAxisPath
    - showXAxisGridLines
    - legendColor
    

Note: As RTL support and word wrap of x axis already implemented for this chart, Now it's working as like previous. Attacked screenshots.

Focus areas to test

Grouped vertical bar chart

Grouped vertical bar chart with custom callout

image

yMax value support - with 100000 as Max value

image

RTL Support

image

Test link: http://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/pull/15468/merge/charting/dist/index.html#/examples/GroupedVerticalBarChart

Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) added 3 commits October 12, 2020 17:21
@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 12, 2020
@jameelakowsar jameelakowsar changed the title charting: charting: Grouped vertical bar chart code refactor. Oct 12, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85928b9:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 12, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 924 927 5000
Breadcrumb mount 39507 39256 5000
Checkbox mount 1559 1671 5000
CheckboxBase mount 1349 1308 5000
ChoiceGroup mount 5048 5057 5000
ComboBox mount 910 884 1000
CommandBar mount 7431 7371 1000
ContextualMenu mount 12438 12562 1000
DefaultButton mount 1163 1137 5000
DetailsRow mount 3561 3622 5000
DetailsRowFast mount 3583 3582 5000
DetailsRowNoStyles mount 3392 3386 5000
Dialog mount 1488 1480 1000
DocumentCardTitle mount 1719 1776 1000
Dropdown mount 2566 2626 5000
FocusTrapZone mount 1718 1681 5000
FocusZone mount 1763 1740 5000
IconButton mount 1830 1800 5000
Label mount 331 327 5000
Layer mount 1939 1945 5000
Link mount 443 439 5000
MenuButton mount 1496 1516 5000
MessageBar mount 1965 1998 5000
Nav mount 3278 3256 1000
OverflowSet mount 1398 1362 5000
Panel mount 1401 1433 1000
Persona mount 807 812 1000
Pivot mount 1411 1421 1000
PrimaryButton mount 1286 1294 5000
Rating mount 7689 7786 5000
SearchBox mount 1290 1312 5000
Shimmer mount 2617 2656 5000
Slider mount 1473 1505 5000
SpinButton mount 5153 5009 5000
Spinner mount 402 400 5000
SplitButton mount 3333 3323 5000
Stack mount 506 522 5000
StackWithIntrinsicChildren mount 1527 1540 5000
StackWithTextChildren mount 4908 4891 5000
SwatchColorPicker mount 10448 10527 5000
TagPicker mount 2849 2859 5000
TeachingBubble mount 47674 47726 5000
Text mount 433 438 5000
TextField mount 1418 1458 5000
Toggle mount 816 829 5000
button mount 101 101 5000

@size-auditor
Copy link

size-auditor bot commented Oct 12, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e631d61d95d145043bfa3f08ae0b4a1ae0bf8d5a (build)

@khmakoto
Copy link
Member

Now that we're publishing beta versions of 8.0 please also port this to the master branch once it merges.

@jameelakowsar jameelakowsar marked this pull request as ready for review October 28, 2020 04:26
@Raghurk Raghurk merged commit 0033f85 into microsoft:7.0 Oct 31, 2020
@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-examples@v0.8.7 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v4.9.0 has been released which incorporates this pull request.:tada:

Handy links:

@kubkon kubkon moved this from Charting to In progress in Version 8 cherry-picks Jan 26, 2021
@kubkon
Copy link
Contributor

kubkon commented Jan 26, 2021

cc @ecraig12345: Ported to v8 in #15838

@kubkon kubkon moved this from In progress to Done in Version 8 cherry-picks Jan 26, 2021
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants