Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Vertical stacked bar chart unit test cases. #15522

Merged
merged 4 commits into from
Oct 22, 2020
Merged

Charting: Vertical stacked bar chart unit test cases. #15522

merged 4 commits into from
Oct 22, 2020

Conversation

jameelakowsar
Copy link
Contributor

Pull request checklist

Description of changes

Implemented basic unit test cases and snapshot test cases to the vertical stacked bar chart.

Focus areas to test

Vertical stacked bar chart

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 15, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 15, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 131d976:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-next-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 15, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 867 888 5000
BaseButton mount 933 961 5000
Breadcrumb mount 39251 39404 5000
ButtonNext mount 712 686 5000
Checkbox mount 1628 1616 5000
CheckboxBase mount 1359 1370 5000
ChoiceGroup mount 5158 5113 5000
ComboBox mount 923 910 1000
CommandBar mount 7535 7436 1000
ContextualMenu mount 12339 12388 1000
DefaultButton mount 1158 1150 5000
DetailsRow mount 3680 3716 5000
DetailsRowFast mount 3636 3645 5000
DetailsRowNoStyles mount 3517 3561 5000
Dialog mount 1500 1561 1000
DocumentCardTitle mount 1720 1734 1000
Dropdown mount 2631 2691 5000
FocusTrapZone mount 1702 1709 5000
FocusZone mount 1809 1788 5000
IconButton mount 1846 1788 5000
Label mount 332 329 5000
Layer mount 1964 2004 5000
Link mount 453 458 5000
MenuButton mount 1486 1568 5000
MessageBar mount 2014 2027 5000
Nav mount 3263 3285 1000
OverflowSet mount 1415 1411 5000
Panel mount 1426 1463 1000
Persona mount 859 841 1000
Pivot mount 1422 1430 1000
PrimaryButton mount 1332 1302 5000
Rating mount 7829 8001 5000
SearchBox mount 1331 1342 5000
Shimmer mount 2682 2687 5000
Slider mount 1538 1482 5000
SpinButton mount 5043 5140 5000
Spinner mount 410 419 5000
SplitButton mount 3240 3220 5000
Stack mount 514 519 5000
StackWithIntrinsicChildren mount 1654 1652 5000
StackWithTextChildren mount 4998 4966 5000
SwatchColorPicker mount 10489 10468 5000
TagPicker mount 2779 2823 5000
TeachingBubble mount 47424 47444 5000
Text mount 510 448 5000
TextField mount 1428 1473 5000
ThemeProvider mount 1653 1629 5000
ThemeProvider virtual-rerender 608 627 5000
Toggle mount 839 829 5000
button mount 123 115 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.48 0.98:1 2000 931
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 603
🔧 Checkbox.Fluent 0.66 0.37 1.78:1 1000 664
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 827
🔧 Dropdown.Fluent 2.94 0.48 6.13:1 1000 2943
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 762
🎯 Image.Fluent 0.09 0.11 0.82:1 5000 440
🔧 Slider.Fluent 1.62 0.36 4.5:1 1000 1615
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 406
🦄 Tooltip.Fluent 0.12 14.46 0.01:1 5000 579

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AlertMinimalPerf.default 334 0 Infinity:1
AnimationMinimalPerf.default 423 0 Infinity:1
AttachmentMinimalPerf.default 191 0 Infinity:1
AttachmentSlotsPerf.default 1175 0 Infinity:1
AvatarMinimalPerf.default 504 0 Infinity:1
BoxMinimalPerf.default 414 0 Infinity:1
ButtonMinimalPerf.default 185 0 Infinity:1
ButtonOverridesMissPerf.default 1740 0 Infinity:1
ButtonSlotsPerf.default 643 0 Infinity:1
ButtonUseCssPerf.default 895 0 Infinity:1
ButtonUseCssNestingPerf.default 1100 0 Infinity:1
CardMinimalPerf.default 612 0 Infinity:1
CarouselMinimalPerf.default 467 0 Infinity:1
ChatDuplicateMessagesPerf.default 438 0 Infinity:1
ChatMinimalPerf.default 667 0 Infinity:1
ChatWithPopoverPerf.default 479 0 Infinity:1
DialogMinimalPerf.default 822 0 Infinity:1
DividerMinimalPerf.default 410 0 Infinity:1
DropdownManyItemsPerf.default 808 0 Infinity:1
DropdownMinimalPerf.default 2924 0 Infinity:1
EmbedMinimalPerf.default 2027 0 Infinity:1
GridMinimalPerf.default 386 0 Infinity:1
HeaderMinimalPerf.default 419 0 Infinity:1
HeaderSlotsPerf.default 850 0 Infinity:1
ImageMinimalPerf.default 433 0 Infinity:1
ItemLayoutMinimalPerf.default 1357 0 Infinity:1
LabelMinimalPerf.default 447 0 Infinity:1
LayoutMinimalPerf.default 441 0 Infinity:1
ListCommonPerf.default 713 0 Infinity:1
ListMinimalPerf.default 536 0 Infinity:1
ListNestedPerf.default 619 0 Infinity:1
ListWith60ListItems.default 975 0 Infinity:1
LoaderMinimalPerf.default 749 0 Infinity:1
MenuMinimalPerf.default 914 0 Infinity:1
MenuButtonMinimalPerf.default 1701 0 Infinity:1
PopupMinimalPerf.default 731 0 Infinity:1
ProviderMinimalPerf.default 1063 0 Infinity:1
RadioGroupMinimalPerf.default 469 0 Infinity:1
ReactionMinimalPerf.default 432 0 Infinity:1
SegmentMinimalPerf.default 412 0 Infinity:1
SkeletonMinimalPerf.default 452 0 Infinity:1
SliderMinimalPerf.default 1588 0 Infinity:1
SplitButtonMinimalPerf.default 3912 0 Infinity:1
StatusMinimalPerf.default 815 0 Infinity:1
IconMinimalPerf.default 783 0 Infinity:1
TableManyItemsPerf.default 2356 0 Infinity:1
TableMinimalPerf.default 463 0 Infinity:1
TextMinimalPerf.default 401 0 Infinity:1
TextAreaMinimalPerf.default 537 0 Infinity:1
CustomToolbarPrototype.default 3896 0 Infinity:1
ToolbarMinimalPerf.default 1030 0 Infinity:1
TooltipMinimalPerf.default 830 0 Infinity:1
TreeMinimalPerf.default 955 0 Infinity:1
TreeWith60ListItems.default 219 0 Infinity:1
VideoMinimalPerf.default 699 0 Infinity:1
Avatar.Fluent 931 0 Infinity:1
Button.Fluent 603 0 Infinity:1
Dialog.Fluent 827 0 Infinity:1
Dropdown.Fluent 2943 0 Infinity:1
Icon.Fluent 762 0 Infinity:1
Image.Fluent 440 0 Infinity:1
Slider.Fluent 1615 0 Infinity:1
Text.Fluent 406 0 Infinity:1
Tooltip.Fluent 579 0 Infinity:1
CheckboxMinimalPerf.default 2889 1 2889:1
ProviderMergeThemesPerf.default 2023 1 2023:1
InputMinimalPerf.default 1344 1 1344:1
Checkbox.Fluent 664 1 664:1
FormMinimalPerf.default 490 1 490:1
FlexMinimalPerf.default 335 1 335:1
RefMinimalPerf.default 248 1 248:1
PortalMinimalPerf.default 170 1 170:1
AccordionMinimalPerf.default 158 1 158:1

@size-auditor
Copy link

size-auditor bot commented Oct 15, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2fd16da12abaf088fa5e301df5e5dd802bc3d392 (build)

@khmakoto khmakoto mentioned this pull request Oct 15, 2020
Closed
40 tasks
@jameelakowsar jameelakowsar marked this pull request as ready for review October 16, 2020 03:58
@Raghurk Raghurk merged commit 5f0d65e into microsoft:7.0 Oct 22, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v4.8.1 has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto mentioned this pull request Oct 27, 2020
Merged
2 tasks
ecraig12345 pushed a commit that referenced this pull request Oct 27, 2020
@khmakoto
Charting: Adding tests for VerticalStackedBarChart (#15709)
79c9a4c 
Cherry-pick of #15522.
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Adding tests for VerticalStackedBarChart (microsoft#15709)
48cd06f 
Cherry-pick of microsoft#15522.
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jameelakowsar @msft-github-bot @Raghurk @ecraig12345 @tomi-msft