Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Unit test cases to the Stacked bar chart and Multi stacked bar charts. #15578

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Charting: Unit test cases to the Stacked bar chart and Multi stacked bar charts. #15578

merged 3 commits into from
Oct 22, 2020

Conversation

jameelakowsar
Copy link
Contributor

Pull request checklist

Description of changes

Added snapshot and basic prop unit test cases to the Stacked bar chart and Multi stacked bar chart.

Focus areas to test

Stacked bar chart
Multi stacked bar chart.

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 18, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f7778b0:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-next-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 881 868 5000
BaseButton mount 978 969 5000
Breadcrumb mount 41898 42096 5000
ButtonNext mount 730 750 5000
Checkbox mount 1722 1671 5000
CheckboxBase mount 1451 1331 5000
ChoiceGroup mount 5292 5321 5000
ComboBox mount 963 968 1000
CommandBar mount 7858 7788 1000
ContextualMenu mount 13276 13328 1000
DefaultButton mount 1219 1217 5000
DetailsRow mount 3807 3842 5000
DetailsRowFast mount 3876 3767 5000
DetailsRowNoStyles mount 3706 3607 5000
Dialog mount 1575 1614 1000
DocumentCardTitle mount 1813 1846 1000
Dropdown mount 2755 2778 5000
FocusTrapZone mount 1776 1790 5000
FocusZone mount 1829 1850 5000
IconButton mount 1873 1924 5000
Label mount 347 346 5000
Layer mount 2057 2039 5000
Link mount 497 459 5000
MenuButton mount 1557 1612 5000
MessageBar mount 2140 2117 5000
Nav mount 3418 3493 1000
OverflowSet mount 1445 1448 5000
Panel mount 1520 1495 1000
Persona mount 858 873 1000
Pivot mount 1468 1482 1000
PrimaryButton mount 1368 1428 5000
Rating mount 8270 8183 5000
SearchBox mount 1361 1414 5000
Shimmer mount 2784 2775 5000
Slider mount 1600 1561 5000
SpinButton mount 5283 5297 5000
Spinner mount 425 435 5000
SplitButton mount 3349 3309 5000
Stack mount 541 543 5000
StackWithIntrinsicChildren mount 1645 1663 5000
StackWithTextChildren mount 5070 5078 5000
SwatchColorPicker mount 10721 10673 5000
TagPicker mount 2860 2882 5000
TeachingBubble mount 51189 50921 5000
Text mount 448 475 5000
TextField mount 1502 1505 5000
ThemeProvider mount 1723 1758 5000
ThemeProvider virtual-rerender 645 646 5000
Toggle mount 903 858 5000
button mount 120 124 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.5 0.51 0.98:1 2000 992
🦄 Button.Fluent 0.13 0.22 0.59:1 5000 650
🔧 Checkbox.Fluent 0.68 0.37 1.84:1 1000 677
🎯 Dialog.Fluent 0.17 0.24 0.71:1 5000 863
🔧 Dropdown.Fluent 3.02 0.5 6.04:1 1000 3023
🔧 Icon.Fluent 0.17 0.06 2.83:1 5000 827
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 450
🔧 Slider.Fluent 1.64 0.4 4.1:1 1000 1640
🔧 Text.Fluent 0.09 0.03 3:1 5000 433
🦄 Tooltip.Fluent 0.12 16.05 0.01:1 5000 604

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 180 0 Infinity:1
AlertMinimalPerf.default 349 0 Infinity:1
AnimationMinimalPerf.default 449 0 Infinity:1
AttachmentMinimalPerf.default 208 0 Infinity:1
AttachmentSlotsPerf.default 1269 0 Infinity:1
AvatarMinimalPerf.default 525 0 Infinity:1
BoxMinimalPerf.default 428 0 Infinity:1
ButtonMinimalPerf.default 225 0 Infinity:1
ButtonOverridesMissPerf.default 1781 0 Infinity:1
ButtonSlotsPerf.default 656 0 Infinity:1
ButtonUseCssPerf.default 885 0 Infinity:1
ButtonUseCssNestingPerf.default 1147 0 Infinity:1
CardMinimalPerf.default 659 0 Infinity:1
CarouselMinimalPerf.default 498 0 Infinity:1
ChatDuplicateMessagesPerf.default 456 0 Infinity:1
ChatMinimalPerf.default 723 0 Infinity:1
ChatWithPopoverPerf.default 501 0 Infinity:1
DialogMinimalPerf.default 886 0 Infinity:1
DividerMinimalPerf.default 434 0 Infinity:1
DropdownManyItemsPerf.default 850 0 Infinity:1
DropdownMinimalPerf.default 2989 0 Infinity:1
EmbedMinimalPerf.default 2092 0 Infinity:1
FlexMinimalPerf.default 342 0 Infinity:1
FormMinimalPerf.default 497 0 Infinity:1
GridMinimalPerf.default 414 0 Infinity:1
HeaderMinimalPerf.default 453 0 Infinity:1
HeaderSlotsPerf.default 882 0 Infinity:1
ImageMinimalPerf.default 435 0 Infinity:1
InputMinimalPerf.default 1394 0 Infinity:1
ItemLayoutMinimalPerf.default 1473 0 Infinity:1
LabelMinimalPerf.default 501 0 Infinity:1
LayoutMinimalPerf.default 467 0 Infinity:1
ListMinimalPerf.default 570 0 Infinity:1
ListNestedPerf.default 643 0 Infinity:1
ListWith60ListItems.default 1023 0 Infinity:1
LoaderMinimalPerf.default 784 0 Infinity:1
MenuMinimalPerf.default 1016 0 Infinity:1
MenuButtonMinimalPerf.default 1704 0 Infinity:1
PopupMinimalPerf.default 743 0 Infinity:1
ProviderMergeThemesPerf.default 2086 0 Infinity:1
ProviderMinimalPerf.default 1037 0 Infinity:1
RadioGroupMinimalPerf.default 531 0 Infinity:1
ReactionMinimalPerf.default 472 0 Infinity:1
SegmentMinimalPerf.default 417 0 Infinity:1
SkeletonMinimalPerf.default 500 0 Infinity:1
SliderMinimalPerf.default 1622 0 Infinity:1
SplitButtonMinimalPerf.default 4019 0 Infinity:1
IconMinimalPerf.default 754 0 Infinity:1
TableManyItemsPerf.default 2413 0 Infinity:1
TableMinimalPerf.default 492 0 Infinity:1
TextMinimalPerf.default 428 0 Infinity:1
TextAreaMinimalPerf.default 573 0 Infinity:1
CustomToolbarPrototype.default 3949 0 Infinity:1
ToolbarMinimalPerf.default 1068 0 Infinity:1
TooltipMinimalPerf.default 871 0 Infinity:1
TreeMinimalPerf.default 988 0 Infinity:1
TreeWith60ListItems.default 215 0 Infinity:1
VideoMinimalPerf.default 709 0 Infinity:1
Avatar.Fluent 992 0 Infinity:1
Button.Fluent 650 0 Infinity:1
Dropdown.Fluent 3023 0 Infinity:1
Image.Fluent 450 0 Infinity:1
Slider.Fluent 1640 0 Infinity:1
Text.Fluent 433 0 Infinity:1
Tooltip.Fluent 604 0 Infinity:1
CheckboxMinimalPerf.default 3023 1 3023:1
Dialog.Fluent 863 1 863:1
StatusMinimalPerf.default 832 1 832:1
Icon.Fluent 827 1 827:1
ListCommonPerf.default 749 1 749:1
Checkbox.Fluent 677 1 677:1
RefMinimalPerf.default 238 1 238:1
PortalMinimalPerf.default 185 1 185:1

@size-auditor
Copy link

size-auditor bot commented Oct 18, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2fd16da12abaf088fa5e301df5e5dd802bc3d392 (build)

@jameelakowsar jameelakowsar marked this pull request as ready for review October 19, 2020 04:11
@khmakoto khmakoto mentioned this pull request Oct 19, 2020
Closed
40 tasks
@Raghurk Raghurk merged commit eb82a0c into microsoft:7.0 Oct 22, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v4.8.1 has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto mentioned this pull request Oct 27, 2020
Merged
2 tasks
ecraig12345 pushed a commit that referenced this pull request Oct 27, 2020
@khmakoto
Charting: Adding tests for StackedBarChart and MultiStackedBarChart (#…
766f500 
…15708)

Cherry-pick of #15578.
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Adding tests for StackedBarChart and MultiStackedBarChart (m…
89fcf8d 
…icrosoft#15708)

Cherry-pick of microsoft#15578.
@ecraig12345 ecraig12345 added this to Charting in Version 8 cherry-picks Jan 26, 2021
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Jan 26, 2021
@ecraig12345 ecraig12345 removed this from Charting in Version 8 cherry-picks Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jameelakowsar @msft-github-bot @Raghurk @ecraig12345 @tomi-msft