Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: Horizontal bar chart basic unit test cases #15579

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Charting: Horizontal bar chart basic unit test cases #15579

merged 5 commits into from
Oct 22, 2020

Conversation

jameelakowsar
Copy link
Contributor

Pull request checklist

Description of changes

Added snapshot and basic unit test cases to the Horizontal bar chart.

Focus areas to test

Horizontal bar chart

@msft-github-bot msft-github-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Oct 18, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 18, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9ae6df4:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-next-template Configuration
codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Oct 18, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
Avatar mount 841 882 5000
BaseButton mount 900 925 5000
Breadcrumb mount 43649 42960 5000
ButtonNext mount 669 684 5000
Checkbox mount 1582 1614 5000
CheckboxBase mount 1274 1291 5000
ChoiceGroup mount 5002 4912 5000
ComboBox mount 980 951 1000
CommandBar mount 7999 7979 1000
ContextualMenu mount 16738 16294 1000
DefaultButton mount 1112 1167 5000
DetailsRow mount 3720 3747 5000
DetailsRowFast mount 3648 3718 5000
DetailsRowNoStyles mount 3641 3548 5000
Dialog mount 1562 1550 1000
DocumentCardTitle mount 1871 1875 1000
Dropdown mount 2664 2574 5000
FocusTrapZone mount 1757 1753 5000
FocusZone mount 1802 1838 5000
IconButton mount 1781 1765 5000
Label mount 338 343 5000
Layer mount 2060 2004 5000
Link mount 474 461 5000
MenuButton mount 1451 1507 5000
MessageBar mount 2148 2057 5000
Nav mount 3262 3327 1000
OverflowSet mount 1428 1470 5000
Panel mount 1446 1453 1000
Persona mount 889 902 1000
Pivot mount 1417 1458 1000
PrimaryButton mount 1313 1289 5000
Rating mount 7653 7611 5000
SearchBox mount 1296 1251 5000
Shimmer mount 2642 2607 5000
Slider mount 1501 1495 5000
SpinButton mount 5169 5189 5000
Spinner mount 429 432 5000
SplitButton mount 3270 3261 5000
Stack mount 524 516 5000
StackWithIntrinsicChildren mount 1627 1628 5000
StackWithTextChildren mount 4644 4738 5000
SwatchColorPicker mount 10482 10663 5000
TagPicker mount 2764 2771 5000
TeachingBubble mount 51352 51855 5000
Text mount 432 443 5000
TextField mount 1412 1436 5000
ThemeProvider mount 1730 1734 5000
ThemeProvider virtual-rerender 667 642 5000
Toggle mount 864 853 5000
button mount 126 126 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.48 0.5 0.96:1 2000 952
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 606
🔧 Checkbox.Fluent 0.65 0.35 1.86:1 1000 652
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 823
🔧 Dropdown.Fluent 3.09 0.48 6.44:1 1000 3093
🔧 Icon.Fluent 0.15 0.07 2.14:1 5000 759
🎯 Image.Fluent 0.08 0.11 0.73:1 5000 388
🔧 Slider.Fluent 1.57 0.39 4.03:1 1000 1572
🔧 Text.Fluent 0.08 0.04 2:1 5000 419
🦄 Tooltip.Fluent 0.12 20.21 0.01:1 5000 593

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 166 0 Infinity:1
AlertMinimalPerf.default 340 0 Infinity:1
AnimationMinimalPerf.default 436 0 Infinity:1
AttachmentMinimalPerf.default 169 0 Infinity:1
AttachmentSlotsPerf.default 1201 0 Infinity:1
AvatarMinimalPerf.default 496 0 Infinity:1
ButtonMinimalPerf.default 189 0 Infinity:1
ButtonOverridesMissPerf.default 1727 0 Infinity:1
ButtonSlotsPerf.default 642 0 Infinity:1
ButtonUseCssPerf.default 829 0 Infinity:1
CardMinimalPerf.default 576 0 Infinity:1
CarouselMinimalPerf.default 465 0 Infinity:1
ChatDuplicateMessagesPerf.default 440 0 Infinity:1
ChatMinimalPerf.default 656 0 Infinity:1
ChatWithPopoverPerf.default 490 0 Infinity:1
CheckboxMinimalPerf.default 2955 0 Infinity:1
DialogMinimalPerf.default 838 0 Infinity:1
DropdownManyItemsPerf.default 757 0 Infinity:1
DropdownMinimalPerf.default 2970 0 Infinity:1
EmbedMinimalPerf.default 1965 0 Infinity:1
FlexMinimalPerf.default 328 0 Infinity:1
FormMinimalPerf.default 422 0 Infinity:1
GridMinimalPerf.default 369 0 Infinity:1
HeaderSlotsPerf.default 808 0 Infinity:1
ImageMinimalPerf.default 387 0 Infinity:1
InputMinimalPerf.default 1379 0 Infinity:1
ItemLayoutMinimalPerf.default 1368 0 Infinity:1
LayoutMinimalPerf.default 426 0 Infinity:1
ListCommonPerf.default 747 0 Infinity:1
ListMinimalPerf.default 549 0 Infinity:1
ListNestedPerf.default 630 0 Infinity:1
ListWith60ListItems.default 983 0 Infinity:1
LoaderMinimalPerf.default 750 0 Infinity:1
MenuMinimalPerf.default 919 0 Infinity:1
MenuButtonMinimalPerf.default 1587 0 Infinity:1
PopupMinimalPerf.default 803 0 Infinity:1
PortalMinimalPerf.default 173 0 Infinity:1
ProviderMergeThemesPerf.default 2168 0 Infinity:1
ProviderMinimalPerf.default 1068 0 Infinity:1
RadioGroupMinimalPerf.default 475 0 Infinity:1
RefMinimalPerf.default 258 0 Infinity:1
SegmentMinimalPerf.default 390 0 Infinity:1
SliderMinimalPerf.default 1621 0 Infinity:1
StatusMinimalPerf.default 767 0 Infinity:1
TableManyItemsPerf.default 2213 0 Infinity:1
TableMinimalPerf.default 451 0 Infinity:1
TextMinimalPerf.default 387 0 Infinity:1
ToolbarMinimalPerf.default 980 0 Infinity:1
TooltipMinimalPerf.default 842 0 Infinity:1
TreeMinimalPerf.default 917 0 Infinity:1
TreeWith60ListItems.default 222 0 Infinity:1
Avatar.Fluent 952 0 Infinity:1
Checkbox.Fluent 652 0 Infinity:1
Dialog.Fluent 823 0 Infinity:1
Icon.Fluent 759 0 Infinity:1
Image.Fluent 388 0 Infinity:1
Text.Fluent 419 0 Infinity:1
Tooltip.Fluent 593 0 Infinity:1
CustomToolbarPrototype.default 4158 1 4158:1
SplitButtonMinimalPerf.default 3852 1 3852:1
Dropdown.Fluent 3093 1 3093:1
Slider.Fluent 1572 1 1572:1
ButtonUseCssNestingPerf.default 1123 1 1123:1
IconMinimalPerf.default 750 1 750:1
VideoMinimalPerf.default 672 1 672:1
Button.Fluent 606 1 606:1
TextAreaMinimalPerf.default 505 1 505:1
SkeletonMinimalPerf.default 438 1 438:1
LabelMinimalPerf.default 431 1 431:1
HeaderMinimalPerf.default 406 1 406:1
DividerMinimalPerf.default 387 1 387:1
BoxMinimalPerf.default 381 1 381:1
ReactionMinimalPerf.default 440 2 220:1

@size-auditor
Copy link

size-auditor bot commented Oct 18, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2fd16da12abaf088fa5e301df5e5dd802bc3d392 (build)

Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) added 2 commits October 18, 2020 18:10
@khmakoto khmakoto mentioned this pull request Oct 19, 2020
Closed
40 tasks
@Raghurk Raghurk merged commit 1eaf34e into microsoft:7.0 Oct 22, 2020
@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v4.8.1 has been released which incorporates this pull request.:tada:

Handy links:

@khmakoto khmakoto mentioned this pull request Oct 27, 2020
Merged
2 tasks
ecraig12345 pushed a commit that referenced this pull request Oct 27, 2020
@khmakoto
Charting: Adding HorizontalBarChart tests (#15706)
ec27806 
Cherry-pick of #15579.
SethDonohue pushed a commit to SethDonohue/fluentui that referenced this pull request Nov 2, 2020
@khmakoto
Charting: Adding HorizontalBarChart tests (microsoft#15706)
baa8c22 
Cherry-pick of microsoft#15579.
@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees

@tomi-msft tomi-msft

Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jameelakowsar @msft-github-bot @Raghurk @ecraig12345 @tomi-msft